Re: [siprec] WGLC for draft-ietf-siprec-callflows-06

"Ram Mohan R (rmohanr)" <rmohanr@cisco.com> Mon, 30 May 2016 12:58 UTC

Return-Path: <rmohanr@cisco.com>
X-Original-To: siprec@ietfa.amsl.com
Delivered-To: siprec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D4A1B12D540 for <siprec@ietfa.amsl.com>; Mon, 30 May 2016 05:58:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.947
X-Spam-Level:
X-Spam-Status: No, score=-15.947 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jNng_oxUPKjn for <siprec@ietfa.amsl.com>; Mon, 30 May 2016 05:58:55 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A9B5912D50E for <siprec@ietf.org>; Mon, 30 May 2016 05:58:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5047; q=dns/txt; s=iport; t=1464613135; x=1465822735; h=from:to:cc:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=RKF/gs9BGXpk+3L/LH4+vPoDHXU25d/BYcb+KlH1BXk=; b=LUHy8r1WYZ01BxmdDGD/cs1vgRGoxUrB7vYD+UNWXSh+yd96gzevsJSu tnDdNqI4kGAFMwKu77Y9kOUiMS01jrWz9dpUdkivwOlBWAHvTPgw00Wyv jY+wcN/6VEo59y7RtP6FZxSdAmT5KsQTxPrXuTuIPZelblwFAzw+ysRd1 Y=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CHBAB1OExX/4oNJK1aA4M8Vn0GphWHeotvAQ2BOj8XC4UlSgKBLjgUAQEBAQEBAWUnhEUBAQEEAQEBawsMBgEIEQMBAlAGCx0KBAENBYgVAxcOt1ENhB8BAQEBAQEBAQEBAQEBAQEBAQEBAQEcinSCQ4F9BxomhRsFjWU4iWczAYV/gniDL4F5gWmET4dJgRuHZIdnAR4BAUKDbW6IPn8BAQE
X-IronPort-AV: E=Sophos;i="5.26,389,1459814400"; d="scan'208";a="107506894"
Received: from alln-core-5.cisco.com ([173.36.13.138]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 May 2016 12:58:54 +0000
Received: from XCH-RTP-018.cisco.com (xch-rtp-018.cisco.com [64.101.220.158]) by alln-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id u4UCwsr8011254 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 30 May 2016 12:58:54 GMT
Received: from xch-rtp-017.cisco.com (64.101.220.157) by XCH-RTP-018.cisco.com (64.101.220.158) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Mon, 30 May 2016 08:58:53 -0400
Received: from xch-rtp-017.cisco.com ([64.101.220.157]) by XCH-RTP-017.cisco.com ([64.101.220.157]) with mapi id 15.00.1104.009; Mon, 30 May 2016 08:58:53 -0400
From: "Ram Mohan R (rmohanr)" <rmohanr@cisco.com>
To: Dmitry Andreyev <Dmitry.Andreyev@nice.com>, "siprec@ietf.org" <siprec@ietf.org>
Thread-Topic: [siprec] WGLC for draft-ietf-siprec-callflows-06
Thread-Index: AQHRunME0nq/5vSeGEiiXwLBOUZlTg==
Date: Mon, 30 May 2016 12:58:53 +0000
Message-ID: <D3723689.5E117%rmohanr@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.6.4.160422
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.65.46.103]
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <5EE1EAE6C3AF6C43891D4AAFB89A9570@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/siprec/KS08wNjZfQU4-C7QV8yx4PbLumE>
Cc: Uri Frieder <Uri.Frieder@nice.com>
Subject: Re: [siprec] WGLC for draft-ietf-siprec-callflows-06
X-BeenThere: siprec@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SIP Recording Working Group Discussion List <siprec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/siprec>, <mailto:siprec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/siprec/>
List-Post: <mailto:siprec@ietf.org>
List-Help: <mailto:siprec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/siprec>, <mailto:siprec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 May 2016 12:58:58 -0000

(Including the mailing list)

Hi Dimitry,

Thanks for your feedback.  This is a very good review and I see you are
able to find errors which is not easy to spot.
I will go ahead and fix them and send the diffs soon.

Regards,
Ram



-----Original Message-----
From: Dmitry Andreyev <Dmitry.Andreyev@nice.com>
Date: Monday, 30 May 2016 at 4:37 PM
To: Cisco Employee <rmohanr@cisco.com>
Cc: "leon.portman@gmail.com" <leon.portman@gmail.com>, Uri Frieder
<Uri.Frieder@nice.com>, Yaron Pdut <Yaron.Pdut@nice.com>
Subject: RE: FW: [siprec] WGLC for draft-ietf-siprec-callflows-06

>Hi Ram,
>
>I have reviewed the draft and below are my comments
>
>
>Opening and closing XML tags do not match
>
>Page 12, 25 
>
>         <participantsessionassoc
>            participant_id="Atnm1ZRnOC6Pm5MApkrDzQ=="
>            session_id="hVpd7YQgRW2nD22h7q60JQ==">
>            <associate-time>2013-12-16T23:41:07Z</associate-time>
>         </participantsession>
>
>
>Page 14, 18, 28
>
>            <disasociate-time>2010-12-16T23:41:07Z</disassociate-time>
>
>Page 30
>
><sipSession>33c77aac7deb414cbc8c10f363fccb71
>            ;remote=a358d2b81a444a8c8fb05950cef331e7</sipSessionID>
>
>
>XML schema issues
>
>Page 10 ­ ³send² should be before ³recv²
>
>            <participantstreamassoc
>             participant_id="srfBElmCRp2QB23b7Mpk0w==">
>             <recv>8zc6e0lYTlWIINA6GR+3ag==</recv>
>             <recv>EiXGlc+4TruqqoDaNE76ag==</recv>
>             <send>i1Pz3to5hGk8fuXl+PbwCw==</send>
>             <send>UAAMm5GRQKSCMVvLyl4rFw==</send>
>            </participantstreamassoc>
>
>
>Page 13 ­ ³nameIDaor² must be ³nameID aor²
>
>         <participant
>            participant_id="Atnm1ZRnOC6Pm5MApkrDzQ==">
>            <nameIDaor="sip:carol@example.com">
>             <name xml:lang="it">Carol</name>
>           </nameID>
>         </participant>
>
>
>Page 14, 18, 28 ­ wrong case in element value. Must be ³partial²
>
>             <datamode>Partial</datamode>
>
>
>Page 17, 19, 29 ­ wrong order of elements ³sipSessionID² must be before
>³start-time²
>
>          <session session_id="bfLZ+NTFEeCNxQTuRyQBmw==">
>            <start-time>2010-12-16T23:41:07Z</start-time>
>            <sipSessionID>3363127f0d084c10876dddd4f8e5eeb9
>            ;remote=2272bb7e70fe41dba0025ae9a26d54cf</sipSessionID>
>          </session>
>
>Page 19 - wrong order of elements ³participantsessionassoc² must be
>first, then ³participantstreamassoc²
>
>          <participantstreamassoc
>             participant_id="srfBElmCRp2QB23b7Mpk0w==">
>             <send>i1Pz3to5hGk8fuXl+PbwCw==</send>
>             <recv>i1Pz3to5hGk8fuXl+PbwCw==</recv>
>          </participantstreamassoc>
>          <participantsessionassoc
>              participant_id="zSfPoSvdSDCmU3A3TRDxAw=="
>                   session_id="hVpd7YQgRW2nD22h7q60JQ==">
>             <associate-time>2010-12-16T23:41:07Z</associate-time>
>          </participantsessionassoc>
>
>
>Page 29 ­ "zzlafnvvjlCHllaHF6mn8kkSS==" is not a valid Base64 string
>
>         <session session_id="zzlafnvvjlCHllaHF6mn8kkSS==">
>
>Page 29 ­ wrong order, ³sipSessionID² must be before ³group-ref²
>
>             <group-ref>7+OTCyoxTmqmqyA/1weDAg==</group-ref>
>            <start-time>2010-12-16T23:41:07Z</start-time>
>             <sipSessionID>fa3b60f27e91441e84c55a9a0095f075
>             ;remote=a358d2b81a444a8c8fb05950cef331e7</sipSessionID>
>
>
>MIME headers issues
>
>Page 5, 19, 22, 23, 26 ­ there must be a blank line between
>³Content-Disposition² MIME header and the XML text.
>
>Content-Type: application/rs-metadata
>Content-Disposition: recording-session
><?xml version="1.0" encoding="UTF-8"?>
>
>
>Hope this helps,
>
>Dmitry Andreyev
>System Architect 
>R&D Recording & Platform Apps Group
>NICE Systems Israel
> 
>(T) +972-9-775-3032
>Dmitry.Andreyev@nice.com
>www.nice.com
>
>
>
>-----Original Message-----
>From: siprec <siprec-bounces@ietf.org> on behalf of "Hutton, Andrew"
><andrew.hutton@unify.com>
>Date: Tuesday, 17 May 2016 at 4:45 PM
>To: "siprec@ietf.org" <siprec@ietf.org>
>Subject: [siprec] WGLC for draft-ietf-siprec-callflows-06
>
>>This message starts a working group last call (WGLC) for
>>https://tools.ietf.org/html/draft-ietf-siprec-callflows-06.
>>
>>Please review the draft in detail and send comments to the SIPREC
>>mailing list.
>>
>>The WGLC will last 3 weeks and will therefore end on the 7th of June
>>2016.
>>
>>The SIPREC metadata and protocols draft are very close to done so now
>>is a good time to review the call flows again.
>>
>>Regards
>>Andy and Brian (SIPREC Co-Chairs).
>>
>>
>>_______________________________________________
>>siprec mailing list
>>siprec@ietf.org
>>https://www.ietf.org/mailman/listinfo/siprec
>