[Softwires] Secdir last call review of draft-ietf-softwire-yang-14

Phillip Hallam-Baker <hallam@gmail.com> Mon, 07 January 2019 16:22 UTC

Return-Path: <hallam@gmail.com>
X-Original-To: softwires@ietf.org
Delivered-To: softwires@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id ACC94126C7E; Mon, 7 Jan 2019 08:22:14 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Phillip Hallam-Baker <hallam@gmail.com>
To: <secdir@ietf.org>
Cc: softwires@ietf.org, draft-ietf-softwire-yang.all@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.89.2
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <154687813459.23265.13403466946569558605@ietfa.amsl.com>
Date: Mon, 07 Jan 2019 08:22:14 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/BqswzR21hQTDt99hbftwX6cB9ig>
Subject: [Softwires] Secdir last call review of draft-ietf-softwire-yang-14
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.29
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 16:22:15 -0000

Reviewer: Phillip Hallam-Baker
Review result: Has Nits

The document describes a schema and has appropriately identified the read/write
security concerns arising from it.

One issue that I thing could be usefully spelled out is that the use of
automated tools to decode structures of this type is not merely a programming
convenience. Attempts to parse length delimited objects nested in length
delimited structures using handwritten code is error prone and has led to
introduction of numerous buffer overrun vulnerabilities.