Re: [Softwires] Last Call: <draft-ietf-softwire-yang-06.txt> (YANG Modules for IPv4-in-IPv6 Address plus Port Softwires) to Proposed Standard
<mohamed.boucadair@orange.com> Mon, 22 October 2018 14:06 UTC
Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: softwires@ietfa.amsl.com
Delivered-To: softwires@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 650F512896A; Mon, 22 Oct 2018 07:06:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level:
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5Zd2uWoLyCL0; Mon, 22 Oct 2018 07:06:49 -0700 (PDT)
Received: from orange.com (mta136.mail.business.static.orange.com [80.12.70.36]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B993A130E35; Mon, 22 Oct 2018 07:05:58 -0700 (PDT)
Received: from opfednr06.francetelecom.fr (unknown [xx.xx.xx.70]) by opfednr24.francetelecom.fr (ESMTP service) with ESMTP id 42dylh40LWz1yGC; Mon, 22 Oct 2018 15:58:08 +0200 (CEST)
Received: from Exchangemail-eme2.itn.ftgroup (unknown [xx.xx.31.27]) by opfednr06.francetelecom.fr (ESMTP service) with ESMTP id 42dylh2RfkzDq7L; Mon, 22 Oct 2018 15:58:08 +0200 (CEST)
Received: from OPEXCLILMA3.corporate.adroot.infra.ftgroup ([fe80::60a9:abc3:86e6:2541]) by OPEXCLILM7C.corporate.adroot.infra.ftgroup ([fe80::8007:17b:c3b4:d68b%19]) with mapi id 14.03.0415.000; Mon, 22 Oct 2018 15:58:08 +0200
From: mohamed.boucadair@orange.com
To: tom petch <daedulus@btconnect.com>, "ietf@ietf.org" <ietf@ietf.org>
CC: "softwires@ietf.org" <softwires@ietf.org>, "softwire-chairs@ietf.org" <softwire-chairs@ietf.org>, "draft-ietf-softwire-yang@ietf.org" <draft-ietf-softwire-yang@ietf.org>, "jiangsheng@huawei.com" <jiangsheng@huawei.com>
Thread-Topic: Last Call: <draft-ietf-softwire-yang-06.txt> (YANG Modules for IPv4-in-IPv6 Address plus Port Softwires) to Proposed Standard
Thread-Index: AQHUVlqQnNxPR9IrokuKmtHmCXfJNKUrZelQ
Date: Mon, 22 Oct 2018 13:58:07 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B93302E01867F@OPEXCLILMA3.corporate.adroot.infra.ftgroup>
References: <153805000273.26427.17737657568994190653.idtracker@ietfa.amsl.com> <005501d45746$079c5480$4001a8c0@gateway.2wire.net> <022801d45979$9499a880$4001a8c0@gateway.2wire.net>
In-Reply-To: <022801d45979$9499a880$4001a8c0@gateway.2wire.net>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.168.234.4]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/R5zmueW6hWhsD38iIaKihEn85_Q>
Subject: Re: [Softwires] Last Call: <draft-ietf-softwire-yang-06.txt> (YANG Modules for IPv4-in-IPv6 Address plus Port Softwires) to Proposed Standard
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Oct 2018 14:06:53 -0000
Re-, Please see inline. Cheers, Med > -----Message d'origine----- > De : tom petch [mailto:daedulus@btconnect.com] > Envoyé : lundi 1 octobre 2018 13:27 > À : ietf@ietf.org > Cc : softwires@ietf.org; softwire-chairs@ietf.org; draft-ietf-softwire- > yang@ietf.org; jiangsheng@huawei.com > Objet : Re: Last Call: <draft-ietf-softwire-yang-06.txt> (YANG Modules for > IPv4-in-IPv6 Address plus Port Softwires) to Proposed Standard > > Some more thoughts on this I-D > > No mention of NMDA - I see the IESG asking for such a statement in > Abstract and in the body of an I-D [Med] Added to the introduction: The adopts the Network Management Datastore Architecture (NMDA) [RFC8342]. > > Abbreviations are expanded but on the nth use, not the first use e.g. > BR, PSID; they probably should be expanded on first use within the YANG > module as well. [Med] Will double check this. > > ' Please update the "revision" date of the YANG module.' There are > three of them:-) [Med] OK. > > Terminology is problematic especially as it seems inconsistent with the > Normatively Referenced RFC7596, RFC7597, RFC7599. > > Customer Premises Equipment (CEs .. > CE is a well known abbreviations for Customer Edge, as oppposed to > Provider Edge, and this is not meant here. Indeed, RFC7599 uses CE for > Customer Edge. Customer Premises Equipment is widely abbreviated to > CPE. RFC7596, a Normative Reference, has 'Customer Premises Equipment > (CPE)' which I should be used here. [Med] Added: (a.k.a., CPE). Actually, we just went with CE used in RFC7599. > > In places, it is 'MAP-E, and MAP-T', elsewhere 'MAP-E or MAP-T'. Does > feature 'algorithm' mean both are supported or just one, and if one, how > can the user tell? [Med] Feature 'algorithm' means 'MAP-E and/or MAP-T' is supported. Nevertheless, when it comes to actual configuration, only MAP-E or MAP-T parameters can be conveyed. This is hinted by the data-plane clause. > > The description clause of 'module ietf-softwire-common' is misleading. > The introductory sentence of the section accurately describes the module > as common definitions but the description clause claims to configure > Lw4o6, MAP-E and MAP-T which it seems wrong. [Med] Fixed. > > 'algorithm' is widely (mis?)used in this I-D. The Normative Reference > RFC7597 is much easier to follow since it mostly talks of 'Mapping > Algorithm' or 'Mapping Rule'. [Med] Added: For simplicity, "algorithm" is used to refer to "mapping algorithm" [RFC7599]. I think > case algorithm { > if-feature algorithm; > container algo-instances { > list algo-instance { > with > grouping algorithm-instance { > in softwire-common and > case algorithm { > if-feature algorithm; > container algorithm { > if-feature algorithm; > need a different term or terms. [Med] OK. Went for: case algo { if-feature algorithm-mode; container algo-instances { list algo-instances { Likewise > case binding { > if-feature binding; > container binding { > if-feature binding; > list bind-instance { > for binding. A widely used, and helpful convention is to have a list > the plural - interfaces - and entries singular - interface; that would [Med] Went for list bind-instances. > help here. And what does > if-feature algorithm; > add that > if-feature algorithm; > does not? > [Med] Removed one if-feature statement. > BR is a well known abbreviation for Border Router; here it used for MAP > Border Relay and while RFC7599 says 'A MAP BR may also be referred to as > simply a "BR" within the context of MAP.', I think that the context here > is wider - the modules are not just MAP - and the term should be 'MAP > BR' not just 'BR'. [Med] Added: The document uses BR to refer to MAP BR [RFC7599] or Lightweight 4over6 BR [RFC7596]. > > After my previous message > ietfa.amsl.com. > gave me a bounce message for > yong@csnet1.cs.tsinghua.edu.cn> > > Overall, I get a slight flavour that this is written by those intimately > acquainted with the technology (although not so much with the RFC!) for > similar readers. > > Tom Petch >
- [Softwires] Last Call: <draft-ietf-softwire-yang-… The IESG
- Re: [Softwires] Last Call: <draft-ietf-softwire-y… tom petch
- Re: [Softwires] Last Call: <draft-ietf-softwire-y… tom petch
- Re: [Softwires] Last Call: <draft-ietf-softwire-y… tom petch
- Re: [Softwires] Last Call: <draft-ietf-softwire-y… mohamed.boucadair
- Re: [Softwires] Last Call: <draft-ietf-softwire-y… mohamed.boucadair
- Re: [Softwires] Last Call: <draft-ietf-softwire-y… mohamed.boucadair
- Re: [Softwires] Last Call: <draft-ietf-softwire-y… tom petch