IETF Logo Mail Archive

Re: [Softwires] Issue with ietf-dslite@2017-11-15.yang and yangdump-pro

Benoit Claise <bclaise@cisco.com> Wed, 27 December 2017 14:29 UTC

Return-Path: <bclaise@cisco.com>
X-Original-To: softwires@ietfa.amsl.com
Delivered-To: softwires@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 02E4D129C5D; Wed, 27 Dec 2017 06:29:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id koh9mBF9ooeV; Wed, 27 Dec 2017 06:29:27 -0800 (PST)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 317D3129C59; Wed, 27 Dec 2017 06:29:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=14421; q=dns/txt; s=iport; t=1514384966; x=1515594566; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to; bh=9sQXqdtVIL1L7kS7T9tVXoJH5Rz0FrWOOxmJTISX8Iw=; b=azLNG/gjoE/ErH8EBZaO+5SAQ/3pOMQ3+m4oAR0zTjoN6wEgmLtcopzG FRCTjgR2L7mAk7r8KFTmG+UYzJyfIBr7+hCID9g/OZ6jCFUraefwTx2UD m0e1Rq/JomQanCO2rp5ZoXgS4IOR1ci4x3uCmW4PLGU4OL+wRal1KpGzM E=;
X-IronPort-AV: E=Sophos;i="5.45,464,1508803200"; d="scan'208,217";a="1089424"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Dec 2017 14:29:24 +0000
Received: from [10.55.221.36] (ams-bclaise-nitro3.cisco.com [10.55.221.36]) by aer-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id vBRETOY5022551; Wed, 27 Dec 2017 14:29:24 GMT
To: mohamed.boucadair@orange.com, Andy Bierman <andy@yumaworks.com>
Cc: "draft-ietf-softwire-dslite-yang@ietf.org" <draft-ietf-softwire-dslite-yang@ietf.org>, Mahesh Jethanandani <mjethanandani@gmail.com>, "softwires@ietf.org" <softwires@ietf.org>, Benoit Claise <bclaise@cisco.com>
References: <10bf60a6-84bb-af3d-1789-09ca02794f46@cisco.com> <CABCOCHQkjNSte2ONpT4zRzbEzNtm7sUtEd9TwPcmoe_nz09fJA@mail.gmail.com> <787AE7BB302AE849A7480A190F8B93300A07D70F@OPEXCLILMA3.corporate.adroot.infra.ftgroup>
From: Benoit Claise <bclaise@cisco.com>
Message-ID: <2afbabf4-2538-ed09-1bd5-419c7f984e0c@cisco.com>
Date: Wed, 27 Dec 2017 15:29:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <787AE7BB302AE849A7480A190F8B93300A07D70F@OPEXCLILMA3.corporate.adroot.infra.ftgroup>
Content-Type: multipart/alternative; boundary="------------6554A02FCD9369A33BDFE57D"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/TSstvLYNSm-0ibjfcQtPqCC4ngk>
Subject: Re: [Softwires] Issue with ietf-dslite@2017-11-15.yang and yangdump-pro
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Dec 2017 14:29:29 -0000

Hi Med,

Thanks.
With the latest yangdump-pro, there is a new error for 
ietf-softwire-ce@2017-11-14.yang
See http://www.claise.be/IETFYANGPageCompilation.html

Regards, B.
>
> Hi Andy, Benoit,
>
> Thank you for investigating this.
>
> A new version which fixes this issue is available online. A diff is 
> available at: 
> https://www.ietf.org/rfcdiff?url2=draft-ietf-softwire-dslite-yang-11
>
> Cheers,
>
> Med
>
> *De :*Andy Bierman [mailto:andy@yumaworks.com]
> *Envoyé :* samedi 18 novembre 2017 22:23
> *À :* Benoit Claise
> *Cc :* draft-ietf-softwire-dslite-yang@ietf.org; Mahesh Jethanandani
> *Objet :* Re: Issue with ietf-dslite@2017-11-15.yang and yangdump-pro
>
> Hi,
>
> yangdump-pro is correct. Every other compiler missed it...
>
> 9.10.2.  The identityref's "base" Statement
>    The "base" statement, which is a substatement to the "type"
>    statement, MUST be present at least once if the type is
>    "identityref".  The argument is the name of an identity, as defined
>    by an "identity" statement.  If a prefix is present on the identity
>    name, it refers to an identity defined in the module that was
>    imported with that prefix. *Otherwise, an identity with the matching*
> *   name MUST be defined in the current module or an included submodule.*
>
> Using ietf-dslite@2017-11-15.yang 
> <mailto:ietf-dslite@2017-11-15.yang>and ietf-nat@2017-11-15.yang 
> <mailto:ietf-nat@2017-11-15.yang>
>
> When I change 'natp44' to 'nat:natp44' in both when-stmts:
>
> andy@andy-homedev:~/Desktop/FD1289/IETF$ yangdump-pro 
> ietf-dslite@2017-11-15.yang <mailto:ietf-dslite@2017-11-15.yang>modpath=.
>
> *** /home/andy/Desktop/FD1289/IETF/ietf-dslite@2017-11-15.yang 
> <mailto:/home/andy/Desktop/FD1289/IETF/ietf-dslite@2017-11-15.yang>
>
> *** 0 Errors, 0 Warnings
>
> andy@andy-homedev:~/Desktop/FD1289/IETF$
>
> Andy
>
> On Sat, Nov 18, 2017 at 11:07 AM, Benoit Claise <bclaise@cisco.com 
> <mailto:bclaise@cisco.com>> wrote:
>
> Hi Andy,
>
> Can you please have a look at ietf-dslite@2017-11-15.yang 
> <mailto:ietf-dslite@2017-11-15.yang>at 
> http://www.claise.be/IETFYANGPageCompilation.html.
> yangdump-pro reports a new error, while the other validators are fine.
>
> Copying Mahesh, as YANG doctor.
>
> Regards, Benoit
>

v2.23.0 | Report a Bug | By Email