Re: [Softwires] I-D Action: draft-ietf-softwire-map-dhcp-11.txt

Ole Troan <otroan@employees.org> Fri, 06 March 2015 20:23 UTC

Return-Path: <otroan@employees.org>
X-Original-To: softwires@ietfa.amsl.com
Delivered-To: softwires@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DA6711A6FFC for <softwires@ietfa.amsl.com>; Fri, 6 Mar 2015 12:23:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.411
X-Spam-Level:
X-Spam-Status: No, score=-1.411 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, J_CHICKENPOX_74=0.6, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vFf9jqkc7xYL for <softwires@ietfa.amsl.com>; Fri, 6 Mar 2015 12:23:41 -0800 (PST)
Received: from banjo.employees.org (banjo.employees.org [198.137.202.19]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 723EB1A6EDE for <softwires@ietf.org>; Fri, 6 Mar 2015 12:23:41 -0800 (PST)
Received: from banjo.employees.org (localhost [127.0.0.1]) by banjo.employees.org (Postfix) with ESMTP id D05F36087; Fri, 6 Mar 2015 12:23:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=employees.org; h=subject :mime-version:content-type:from:in-reply-to:date:cc:message-id :references:to; s=selector1; bh=lgb90fZR64MLxnfH4+g/I8ExJXA=; b= NS4X/1Q6O2tekHwTZTer1WncxlvdBtLZqwqYnzHbCTvSmSZE7ayPGVFY/Jc2nVDw 5fwWS4MufiF5NEYjKLR7ZDDbumeNqb0cYrWVauurj+vl6Ti5mg21nXWasITqqS5F U4jbVWh2Qwymu9GXCUXxetviRbGBXRmtISPs5kknwaQ=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=employees.org; h=subject :mime-version:content-type:from:in-reply-to:date:cc:message-id :references:to; q=dns; s=selector1; b=dH7RlLOfW4cF1zukXJlWGkpGvF 4DR4nay37YqtPC4OdR0tvckWOQW6LW7QKBsnYYpvcU+s7b6PnKReusIGL0ZmYqwB Kxzwe7KaGSlSu4wDyfs7avqAFlzGAw5PR1iZJzNzngzpawvoEdoHfWPN/lm2M0mZ GQWI1jujlxmm2w/MU=
Received: from gomlefisk.localdomain (77.18.141.216.tmi.telenormobil.no [77.18.141.216]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: otroan) by banjo.employees.org (Postfix) with ESMTPSA id 32C036028; Fri, 6 Mar 2015 12:23:39 -0800 (PST)
Received: from [IPv6:::1] (unknown [IPv6:::1]) by gomlefisk.localdomain (Postfix) with ESMTP id D02833FF7704; Fri, 6 Mar 2015 21:23:36 +0100 (CET)
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2087\))
Content-Type: multipart/signed; boundary="Apple-Mail=_160FF0DA-961E-4F0B-BFCB-326AAA4E71DE"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail 2.5b5
From: Ole Troan <otroan@employees.org>
In-Reply-To: <54f94d08.1121320a.5027.152a@mx.google.com>
Date: Fri, 06 Mar 2015 21:23:35 +0100
Message-Id: <83F98EB1-5D94-436A-8EEF-E720F7D26BA9@employees.org>
References: <20141114095154.19022.64483.idtracker@ietfa.amsl.com> <54f94d08.1121320a.5027.152a@mx.google.com>
To: Leaf Yeh <leaf.yeh.sdo@gmail.com>
X-Mailer: Apple Mail (2.2087)
Archived-At: <http://mailarchive.ietf.org/arch/msg/softwires/XfHcHVI-Aod9VQfjdCbn-KsGqH0>
Cc: softwires@ietf.org
Subject: Re: [Softwires] I-D Action: draft-ietf-softwire-map-dhcp-11.txt
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Mar 2015 20:23:43 -0000

Leaf,

> 
> Nits found in draft-ietf-softwire-map-dhcp-11:
> 
> a. In sec. 4.4, "o  option-length: 4"
> 
> Per the format defined for OPTION_S46_V4V6BIND, the value of the
> option-length should be variable. I guess the above text is wrongly copied
> from other place.

thanks, that was definitely a bug! I will get this fixed.

> b. In sec. 4.5,
> "  The OPTION_S46_PORTPARAMS option with an
>   explicit PSID MUST be discarded if the S46 CE isn't configured with a
>   full IPv4 address (e.g.  IPv4 prefix)."
> 
> I prefer to replace the above "a full IPv4 address" to be "a shared IPv4
> address". We can get the address sharing information from the calculation on
> the 'ea-len' and 'prefix4-len' got from OPTION_S46_RULE, i.e. PSID-length =
> q = o - p = o - (32-r) != 0.  Right?

this text is trying to cover the misconfiguration case where CE is assigned an IPv4 prefix (e.g. /24) and a PSID. that doesn’t work, as one can not have “shared IPv4 subnets, only individual addresses”.

> c. In sec. 4.1,
> "  o  F-Flag: 1 bit field that specifies whether the rule is to be used
>      for forwarding (FMR).  If set, this rule is used as a FMR, if not
>      set this rule is a BMR only and MUST NOT be used for forwarding.
>      Note: A BMR can also be used as an FMR for forwarding if the
>      F-flag is set.  The BMR rule is determined by a longest-prefix
>      match of the Rule-IPv6-prefix against the End-User IPv6
>      prefix(es)."
> 
> I guess if F-Flag=0, i.e. not set, this rule is a BMR only, and is not a
> FMR. That might means hub & spoke mode, right? If yes, I guess we need more
> words on the hub & spoke mode in this section. Right?

yes, that means H&S mode. I believe we had this discussion on the mailing list earlier, and that we came to the conclusion that we didn’t want to “re-specify” the MAP mechanism in the MAP DHCP draft, so the “more words” should be in the base specification.

> d. In sec. 8,
> "  Such
>   a client MUST include the S46 Container option(s) that it is
>   configured for in its ORO in SOLICIT, REQUEST, RENEW, REBIND and
>   INFORMATION-REQUEST messages. "
> 
> I prefer the above words could be " Such a client MUST include the codes of
> the S46 Container option(s)...in its ORO…".

I agree it is worded a bit awkwardly.
what about:
"Such a client MUST request the S46 Container option(s) that it is configured for in its ORO…"

> e. In sec. 4.5,
> "  o  offset: (PSID offset) 8 bits long field that specifies the numeric
>      value for the S46 algorithm's excluded port range/offset bits
>      (A-bits), as per section 5.1.1 of [I-D.ietf-softwire-map]. "
> 
> I prefer to replace the above "A-bits " to be "a-bits" per
> I-D.ietf-softwire-map.  'A' looks like the value in the field, while 'a' is
> the number of the bits.

ack.

> f. In sec. 4.4,
> "  o  bind-ipv6-prefix: a variable length field specifying the IPv6
>      prefix or address for the S46. "
> 
> I prefer to replace the above "the S46" to be "the S46 CE". Right?

right.

> g. In sec. 3,
> "  MAP-E uses RFC2473 [RFC2473] IPv4 over IPv6 tunnelling,
>   while MAP-T uses NAT64 [RFC6145] based translation."
> 
> We only need 1x RFC2473 here.  :-)

you just can’t have enough RFC2473! ;-)

I think the length bug above warrants a quick revision. if no-one objects I’ll also include the other editorial issues that Leaf found.

cheers,
Ole



> 
> 
> Best Regards,
> Leaf
> 
> 
> 
> -----Original Message-----
> From: Softwires [mailto:softwires-bounces@ietf.org] On Behalf Of
> internet-drafts@ietf.org
> Sent: Friday, November 14, 2014 5:52 PM
> To: i-d-announce@ietf.org
> Cc: softwires@ietf.org
> Subject: [Softwires] I-D Action: draft-ietf-softwire-map-dhcp-11.txt
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories.
> This draft is a work item of the Softwires Working Group of the IETF.
> 
>        Title           : DHCPv6 Options for configuration of Softwire
> Address and Port Mapped Clients
>        Authors         : Tomek Mrugalski
>                          Ole Troan
>                          Ian Farrer
>                          Simon Perreault
>                          Wojciech Dec
>                          Congxiao Bao
>                          Leaf Y. Yeh
>                          Xiaohong Deng
> 	Filename        : draft-ietf-softwire-map-dhcp-11.txt
> 	Pages           : 18
> 	Date            : 2014-11-14
> 
> Abstract:
>   This document specifies DHCPv6 options, termed Softwire46 options,
>   for the provisioning of Softwire46 Customer Edge (CE) devices.
>   Softwire46 is a collective term used to refer to architectures based
>   on the notion of IPv4 Address+Port (A+P) for providing IPv4
>   connectivity across an IPv6 network.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-softwire-map-dhcp/
> 
> There's also a htmlized version available at:
> http://tools.ietf.org/html/draft-ietf-softwire-map-dhcp-11
> 
> A diff from the previous version is available at:
> http://www.ietf.org/rfcdiff?url2=draft-ietf-softwire-map-dhcp-11
> 
> 
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
> 
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
> 
> _______________________________________________
> Softwires mailing list
> Softwires@ietf.org
> https://www.ietf.org/mailman/listinfo/softwires
>