IETF Logo Mail Archive

Re: [Softwires] Ignas Bagdonas' No Objection on draft-ietf-softwire-dslite-yang-16: (with COMMENT)

<mohamed.boucadair@orange.com> Mon, 28 May 2018 07:30 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: softwires@ietfa.amsl.com
Delivered-To: softwires@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A954E126CBF; Mon, 28 May 2018 00:30:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aO4-CQdzRv4A; Mon, 28 May 2018 00:30:09 -0700 (PDT)
Received: from orange.com (mta135.mail.business.static.orange.com [80.12.70.35]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1027C126BFD; Mon, 28 May 2018 00:30:09 -0700 (PDT)
Received: from opfednr02.francetelecom.fr (unknown [xx.xx.xx.66]) by opfednr24.francetelecom.fr (ESMTP service) with ESMTP id 9D462404AE; Mon, 28 May 2018 09:30:07 +0200 (CEST)
Received: from Exchangemail-eme2.itn.ftgroup (unknown [xx.xx.31.18]) by opfednr02.francetelecom.fr (ESMTP service) with ESMTP id 7C79312007C; Mon, 28 May 2018 09:30:07 +0200 (CEST)
Received: from OPEXCLILMA3.corporate.adroot.infra.ftgroup ([fe80::60a9:abc3:86e6:2541]) by OPEXCLILM34.corporate.adroot.infra.ftgroup ([fe80::cba:56d0:a732:ef5a%19]) with mapi id 14.03.0389.001; Mon, 28 May 2018 09:30:07 +0200
From: mohamed.boucadair@orange.com
To: Ignas Bagdonas <ibagdona@gmail.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-softwire-dslite-yang@ietf.org" <draft-ietf-softwire-dslite-yang@ietf.org>, Ian Farrer <ianfarrer@gmx.com>, "softwire-chairs@ietf.org" <softwire-chairs@ietf.org>, "ianfarrer@gmx.com" <ianfarrer@gmx.com>, "softwires@ietf.org" <softwires@ietf.org>
Thread-Topic: Ignas Bagdonas' No Objection on draft-ietf-softwire-dslite-yang-16: (with COMMENT)
Thread-Index: AQHT81aFqP2EWFm4ZESdF9jr0nAo3qREuDsQ
Date: Mon, 28 May 2018 07:30:06 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B93302DF2044A@OPEXCLILMA3.corporate.adroot.infra.ftgroup>
References: <152716310361.29842.14622549682397531789.idtracker@ietfa.amsl.com>
In-Reply-To: <152716310361.29842.14622549682397531789.idtracker@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.168.234.2]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/aAIAuwNgTaDM9hToS8Wgi3PwHGA>
Subject: Re: [Softwires] Ignas Bagdonas' No Objection on draft-ietf-softwire-dslite-yang-16: (with COMMENT)
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 May 2018 07:30:11 -0000

Hi Ignas, 

Thank you for the review. 

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : Ignas Bagdonas [mailto:ibagdona@gmail.com]
> Envoyé : jeudi 24 mai 2018 13:58
> À : The IESG
> Cc : draft-ietf-softwire-dslite-yang@ietf.org; Ian Farrer; softwire-
> chairs@ietf.org; ianfarrer@gmx.com; softwires@ietf.org
> Objet : Ignas Bagdonas' No Objection on draft-ietf-softwire-dslite-yang-16:
> (with COMMENT)
> 
> Ignas Bagdonas has entered the following ballot position for
> draft-ietf-softwire-dslite-yang-16: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-softwire-dslite-yang/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Nit: model vs module. While there are no strict requirements for terminology,
> it appears that dominant term used in YANG documents is model and not module.
> The reasoning would be that model defines a module and the logic description
> of
> it, while module is strictly a formal YANG code.
> 

[Med] As per https://www.ietf.org/mail-archive/web/netmod/current/msg15324.html, both "YANG data model" and "YANG module" are valid terms. I will double check the document to fix any inconsistent use of the terms.  

> Nit: s/rate-lmite/rate limit

[Med] Fixed. 

> 
> uint8 max-softwires-per-subscriber: Is the storage space large enough here?

[Med] This is implementation- and deployment-specific. 

> RFC
> 7785 recommends 1, but it does not appear to set upper limit. If practical
> deployment scenarios will be an order of magnitude lower than 255 then likely
> it is not a problem.
> 

[Med] We are not setting any max because this is deployment-specific. 

> date-and-time last-address-change: Is the granularity of yang:date-and-time
> enough for this use?
> 

[Med] Yes.

v2.23.0 | Report a Bug | By Email