[Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-03

Andy Bierman via Datatracker <noreply@ietf.org> Wed, 03 April 2019 18:53 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: softwires@ietf.org
Delivered-To: softwires@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 30BC212013F; Wed, 3 Apr 2019 11:53:29 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Andy Bierman via Datatracker <noreply@ietf.org>
To: <yang-doctors@ietf.org>
Cc: softwires@ietf.org, draft-ietf-softwire-iftunnel.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.94.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Andy Bierman <andy@yumaworks.com>
Message-ID: <155431760907.22784.16246569281973305806@ietfa.amsl.com>
Date: Wed, 03 Apr 2019 11:53:29 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/hAzTfmnTGrpeQ4QHWrXq_eWg-S0>
Subject: [Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-03
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.29
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Apr 2019 18:53:29 -0000

Reviewer: Andy Bierman
Review result: Ready with Nits

The iana-tunnel-type module has no errors or nits of any kind.
The ietf-extension-example module has no errors of any kind, and 1 nit.
The document appears to follow all YANG usage guidelines (but 1) correctly.

I have a minor comment about the example module. I guess it has to use <CODE
BEGINS>. (The <EXAMPLE BEGINS> discussion did not go anywhere).

This module looks a little too real to average users, especially after tools
extract it from the RFC and put it in the YangModels repo under the
standard/ietf/RFC directory.

You should rename the ietf-extension-example module to
example-iftunnel-extension (or anything starting with "example-"). The module
should not begin with "ietf-" unless it is a real module.