Re: [Softwires] Issue with ietf-dslite@2017-11-15.yang and yangdump-pro

Andy Bierman <andy@yumaworks.com> Fri, 29 December 2017 17:17 UTC

Return-Path: <andy@yumaworks.com>
X-Original-To: softwires@ietfa.amsl.com
Delivered-To: softwires@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9EA0F12D810 for <softwires@ietfa.amsl.com>; Fri, 29 Dec 2017 09:17:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yumaworks-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sSa_9rcvd26J for <softwires@ietfa.amsl.com>; Fri, 29 Dec 2017 09:17:45 -0800 (PST)
Received: from mail-lf0-x233.google.com (mail-lf0-x233.google.com [IPv6:2a00:1450:4010:c07::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E2836120725 for <softwires@ietf.org>; Fri, 29 Dec 2017 09:17:44 -0800 (PST)
Received: by mail-lf0-x233.google.com with SMTP id c19so28793660lfg.3 for <softwires@ietf.org>; Fri, 29 Dec 2017 09:17:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yumaworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oJehDcYdFjoIKSyop7fKNnu/jPNj3eMQaXaG7E/eyRc=; b=PANT/NjTVByGVX5DY6VRbTmOb5vqKQ04clUPa4Y1P9shp4MhbbUUnRkQPL2YS30VJ6 f8MwpYzY++m2tzRQbZg8uOym7H5aIushQ7P3uiLq4WkaWpNgdAvDzOuUe/dabbGZLJxN N+suQinuTlCMYBCDPy9FX9D6LL0CyYs5SZXrn30ee+JBqIZi6NCyrpOXkCTkS3wbYXRH E0NDzRoiGfZhFyT+uCvNsRZbYN0e1y02e9HHIgBnU6PJq6HrSaMsCi/iL2zy9y9konbC DwJ3ui3108TtpWz0Z8Wb0R+DSVzP0x6iR7tGspa+pnSQ0MkLJTaRnctwT6+5CA46uFsh HV3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oJehDcYdFjoIKSyop7fKNnu/jPNj3eMQaXaG7E/eyRc=; b=XkvGp1C6zmzr1lap6+mNQh+ha+BbN9Kkvhx4955CJjYso7KQ7zHRgKdo+5xue9UbsQ 4SyVtn96mnrFOCr/ZTeVP/aSKPlC9wYngYkc0CXVpZat4MwWiZWjM/w0HHQZajQcJ/5g I0oKbYdyH7WFzCNrfutmV2xtKJPD4NUZOfIV6FGcajxRgY8sKFynEiy/tLb5k1gEjZvc GlLDD2IcSsptoCMwNz0N5PNR4JqAVbtklO53Ew3mCpATYI9M4Bm8orED5iGs8HAxqORr Xgu3WJQnBj4WcNsGfLnA+9HGQswAZ3bAszsa8ealvOEW+0IYluRb6oc4TpdDAI/esIbL 35aw==
X-Gm-Message-State: AKGB3mLh5yMvSnx5u708qeOtOt/YGvgQIEuDx3FM7du3UU4JJE1E6VoL UuK/Nm/DkV7MJ+UzBNEPWc//Samj2HML9HLUDEg+Tg==
X-Google-Smtp-Source: ACJfBosrAAN1893wZHFmPlB02q4SGd5rQKZjFSVz+uvgMdhAiZ57Fht3rFM/7SK5MVzxzZd5iLWcOatrt1sKXcYG/XI=
X-Received: by 10.46.83.9 with SMTP id h9mr21054833ljb.68.1514567863101; Fri, 29 Dec 2017 09:17:43 -0800 (PST)
MIME-Version: 1.0
Received: by 10.25.95.22 with HTTP; Fri, 29 Dec 2017 09:17:42 -0800 (PST)
In-Reply-To: <84D216F2-5D16-4EB5-B756-9AA6100D8F14@gmail.com>
References: <10bf60a6-84bb-af3d-1789-09ca02794f46@cisco.com> <CABCOCHQkjNSte2ONpT4zRzbEzNtm7sUtEd9TwPcmoe_nz09fJA@mail.gmail.com> <787AE7BB302AE849A7480A190F8B93300A07D70F@OPEXCLILMA3.corporate.adroot.infra.ftgroup> <2afbabf4-2538-ed09-1bd5-419c7f984e0c@cisco.com> <84D216F2-5D16-4EB5-B756-9AA6100D8F14@gmail.com>
From: Andy Bierman <andy@yumaworks.com>
Date: Fri, 29 Dec 2017 09:17:42 -0800
Message-ID: <CABCOCHRBph1m_TbQ-OdC1c3Y4G-19Ybxip=s2PK1NbDWY6feQA@mail.gmail.com>
To: Mahesh Jethanandani <mjethanandani@gmail.com>
Cc: Benoit Claise <bclaise@cisco.com>, mohamed.boucadair@orange.com, "draft-ietf-softwire-dslite-yang@ietf.org" <draft-ietf-softwire-dslite-yang@ietf.org>, "softwires@ietf.org" <softwires@ietf.org>
Content-Type: multipart/alternative; boundary="f4030436096e77fec305617dcfac"
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/i0wG5oW4UbTe4Zffv2tpKUGV1Ec>
Subject: Re: [Softwires] Issue with ietf-dslite@2017-11-15.yang and yangdump-pro
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 17:17:47 -0000

Hi,

I removed the warnings from our code.
Now doing what YANG says to do.
Ignoring child node different status than parent.
This does not seem to count as a reference.


Andy



On Fri, Dec 29, 2017 at 3:40 AM, Mahesh Jethanandani <
mjethanandani@gmail.com> wrote:

> Hi Benoit,
>
> Please ignore my last E-mail. You are referencing ietf-software-ce model
> and I was confused about the e-mail subject line referencing ietf-dslite
> model.
>
> I would agree with Andy about publishing a warning when the reference is
> in the other model.
>
> Med, in the meantime, for the dslite model, can you replace the =
> expression in the 'when' statement with 'derived-from'. Thanks.
>
> Mahesh Jethanandani
> mjethanandani@gmail.com
>
> On Dec 27, 2017, at 11:29 AM, Benoit Claise <bclaise@cisco.com> wrote:
>
> Hi Med,
>
> Thanks.
> With the latest yangdump-pro, there is a new error for
> ietf-softwire-ce@2017-11-14.yang
> See http://www.claise.be/IETFYANGPageCompilation.html
>
> Regards, B.
>
> Hi Andy, Benoit,
>
>
>
> Thank you for investigating this.
>
>
>
> A new version which fixes this issue is available online. A diff is
> available at: https://www.ietf.org/rfcdiff?url2=draft-ietf-softwire-
> dslite-yang-11
>
>
>
> Cheers,
>
> Med
>
>
>
> *De :* Andy Bierman [mailto:andy@yumaworks.com <andy@yumaworks.com>]
> *Envoyé :* samedi 18 novembre 2017 22:23
> *À :* Benoit Claise
> *Cc :* draft-ietf-softwire-dslite-yang@ietf.org; Mahesh Jethanandani
> *Objet :* Re: Issue with ietf-dslite@2017-11-15.yang and yangdump-pro
>
>
>
> Hi,
>
>
>
> yangdump-pro is correct. Every other compiler missed it...
>
>
>
> 9.10.2.  The identityref's "base" Statement
>
>
>
>    The "base" statement, which is a substatement to the "type"
>
>    statement, MUST be present at least once if the type is
>
>    "identityref".  The argument is the name of an identity, as defined
>
>    by an "identity" statement.  If a prefix is present on the identity
>
>    name, it refers to an identity defined in the module that was
>
>    imported with that prefix.  *Otherwise, an identity with the matching*
>
> *   name MUST be defined in the current module or an included submodule.*
>
>
>
> Using ietf-dslite@2017-11-15.yang and ietf-nat@2017-11-15.yang
>
>
>
> When I change 'natp44' to 'nat:natp44' in both when-stmts:
>
>
>
> andy@andy-homedev:~/Desktop/FD1289/IETF$ yangdump-pro
> ietf-dslite@2017-11-15.yang modpath=.
>
>
>
> *** /home/andy/Desktop/FD1289/IETF/ietf-dslite@2017-11-15.yang
>
> *** 0 Errors, 0 Warnings
>
>
>
> andy@andy-homedev:~/Desktop/FD1289/IETF$
>
>
>
>
>
> Andy
>
>
>
>
>
> On Sat, Nov 18, 2017 at 11:07 AM, Benoit Claise <bclaise@cisco.com> wrote:
>
> Hi Andy,
>
> Can you please have a look at ietf-dslite@2017-11-15.yang at
> http://www.claise.be/IETFYANGPageCompilation.html .
> yangdump-pro reports a new error, while the other validators are fine.
>
> Copying Mahesh, as YANG doctor.
>
> Regards, Benoit
>
>
>
>
>
>