Re: [Softwires] Issue with ietf-dslite@2017-11-15.yang and yangdump-pro

Mahesh Jethanandani <mjethanandani@gmail.com> Fri, 29 December 2017 11:40 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: softwires@ietfa.amsl.com
Delivered-To: softwires@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3012212D84C; Fri, 29 Dec 2017 03:40:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QWRcFHEgd4fp; Fri, 29 Dec 2017 03:40:47 -0800 (PST)
Received: from mail-ot0-x235.google.com (mail-ot0-x235.google.com [IPv6:2607:f8b0:4003:c0f::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A3DBB126BFD; Fri, 29 Dec 2017 03:40:47 -0800 (PST)
Received: by mail-ot0-x235.google.com with SMTP id d44so27967575otd.12; Fri, 29 Dec 2017 03:40:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:in-reply-to:mime-version:content-transfer-encoding :message-id:cc:from:subject:date:to; bh=u52s5VkVwmAPqWkEtW+9KpZXS1n4mLtx7SM4dJBfFq8=; b=jSR4WKPNrp92UB0CmZQS0g17lnLBXzEsoIlD1Rxn4LCZkC0574A8qBsW7JNthucydU 5SImMbmVt4FvfGqkv19681imf5XpbPxsnuZjdugFlONdGdp43SMjXpQ9tgfRSnU9jI16 jsV4bqABPVacqy+xqmExWJrvjelfAutdVQE3lmHDaEUeu6LC/HSlpw9UPeHQMuglZOTG JWXHaVUy4RhWk+z1BF+t/Lxy37ztPHgP33TvZmcxjRhvDIh6sYJ0cZbK2T9BbmKmflvx ETOolxXAkH8QBz7KisTX/fcJHNYsVrsIG7ICk8asbI7yNqTVIya4E4NnMjKlBIChAuY/ RELQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:in-reply-to:mime-version :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=u52s5VkVwmAPqWkEtW+9KpZXS1n4mLtx7SM4dJBfFq8=; b=uWoWHV9aymrLiDWR8E6fW1SmsP4wbGjCnff2uSBdomjl9+r51IuNMr17py6YM7aDJv ZxQEJnEcwQpP/7zENjaaeuxytXqNnUIbx/hTLF20jKrIvmgJviXKwDBemzWBeuQN6t1w 3xhaknH54lsY9i01i99DPbwkaNRVlsn9XuHEUqOO5RWQfzUJEsjHd6pTZ+KaIsczCRx7 R3Ri6K/Hz2mhXcpdQ0wt5r29uaoSNog2BQTgHl/phPvxQU9NgljleFdzptdRfxKpnLOJ Y6Y8e2ftSxtGWPFjr1y99YPML4MXF0AaZNlyylai3N1mBmSGXW87pn9a0fTu4H2RSn15 LK9Q==
X-Gm-Message-State: AKGB3mIR5WDK3KHchQbF/XYhCSUwfvACzch8UKKfi7w/jXB9OO/wzJ02 ovWUERO7KWxzlSrzus8EvGQ=
X-Google-Smtp-Source: ACJfBovBEBvyOkCY2sqgEAy6PVZTVmFhsfkPTGP1gxpyiAF+FQDsetbH7hPsn5Aj5eH/54gHLPRgPA==
X-Received: by 10.157.16.18 with SMTP id h18mr14957551ote.352.1514547646985; Fri, 29 Dec 2017 03:40:46 -0800 (PST)
Received: from [172.20.10.2] ([172.56.7.255]) by smtp.gmail.com with ESMTPSA id 79sm4276526oth.14.2017.12.29.03.40.44 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Dec 2017 03:40:46 -0800 (PST)
References: <10bf60a6-84bb-af3d-1789-09ca02794f46@cisco.com> <CABCOCHQkjNSte2ONpT4zRzbEzNtm7sUtEd9TwPcmoe_nz09fJA@mail.gmail.com> <787AE7BB302AE849A7480A190F8B93300A07D70F@OPEXCLILMA3.corporate.adroot.infra.ftgroup> <2afbabf4-2538-ed09-1bd5-419c7f984e0c@cisco.com>
In-Reply-To: <2afbabf4-2538-ed09-1bd5-419c7f984e0c@cisco.com>
Mime-Version: 1.0 (1.0)
Content-Transfer-Encoding: 7bit
Content-Type: multipart/alternative; boundary="Apple-Mail-8D7CB92B-D763-421A-8E1A-6E1D98BEF1D5"
Message-Id: <84D216F2-5D16-4EB5-B756-9AA6100D8F14@gmail.com>
Cc: mohamed.boucadair@orange.com, Andy Bierman <andy@yumaworks.com>, "draft-ietf-softwire-dslite-yang@ietf.org" <draft-ietf-softwire-dslite-yang@ietf.org>, "softwires@ietf.org" <softwires@ietf.org>
X-Mailer: iPad Mail (13G36)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Date: Fri, 29 Dec 2017 08:40:19 -0300
To: Benoit Claise <bclaise@cisco.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/oOaWAfU5On33DAxIch7BBH5MYBw>
Subject: Re: [Softwires] Issue with ietf-dslite@2017-11-15.yang and yangdump-pro
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 11:40:50 -0000

Hi Benoit,

Please ignore my last E-mail. You are referencing ietf-software-ce model and I was confused about the e-mail subject line referencing ietf-dslite model.

I would agree with Andy about publishing a warning when the reference is in the other model.

Med, in the meantime, for the dslite model, can you replace the = expression in the 'when' statement with 'derived-from'. Thanks.

Mahesh Jethanandani
mjethanandani@gmail.com

> On Dec 27, 2017, at 11:29 AM, Benoit Claise <bclaise@cisco.com> wrote:
> 
> Hi Med,
> 
> Thanks.
> With the latest yangdump-pro, there is a new error for ietf-softwire-ce@2017-11-14.yang
> See http://www.claise.be/IETFYANGPageCompilation.html
> 
> Regards, B.
>> Hi Andy, Benoit,
>>  
>> Thank you for investigating this.
>>  
>> A new version which fixes this issue is available online. A diff is available at: https://www.ietf.org/rfcdiff?url2=draft-ietf-softwire-dslite-yang-11
>>  
>> Cheers,
>> Med
>>  
>> De : Andy Bierman [mailto:andy@yumaworks.com] 
>> Envoyé : samedi 18 novembre 2017 22:23
>> À : Benoit Claise
>> Cc : draft-ietf-softwire-dslite-yang@ietf.org; Mahesh Jethanandani
>> Objet : Re: Issue with ietf-dslite@2017-11-15.yang and yangdump-pro
>>  
>> Hi,
>>  
>> yangdump-pro is correct. Every other compiler missed it...
>>  
>> 9.10.2.  The identityref's "base" Statement
>>  
>>    The "base" statement, which is a substatement to the "type"
>>    statement, MUST be present at least once if the type is
>>    "identityref".  The argument is the name of an identity, as defined
>>    by an "identity" statement.  If a prefix is present on the identity
>>    name, it refers to an identity defined in the module that was
>>    imported with that prefix.  Otherwise, an identity with the matching
>>    name MUST be defined in the current module or an included submodule.
>>  
>> Using ietf-dslite@2017-11-15.yang and ietf-nat@2017-11-15.yang
>>  
>> When I change 'natp44' to 'nat:natp44' in both when-stmts:
>>  
>> andy@andy-homedev:~/Desktop/FD1289/IETF$ yangdump-pro ietf-dslite@2017-11-15.yang modpath=.
>>  
>> *** /home/andy/Desktop/FD1289/IETF/ietf-dslite@2017-11-15.yang
>> *** 0 Errors, 0 Warnings
>>  
>> andy@andy-homedev:~/Desktop/FD1289/IETF$ 
>>  
>>  
>> Andy
>>  
>>  
>> On Sat, Nov 18, 2017 at 11:07 AM, Benoit Claise <bclaise@cisco.com> wrote:
>> Hi Andy,
>> 
>> Can you please have a look at ietf-dslite@2017-11-15.yang at http://www.claise.be/IETFYANGPageCompilation.html .
>> yangdump-pro reports a new error, while the other validators are fine.
>> 
>> Copying Mahesh, as YANG doctor.
>> 
>> Regards, Benoit
>> 
>