[Softwires] Suresh Krishnan's Discuss on draft-ietf-softwire-map-radius-24: (with DISCUSS and COMMENT)

Suresh Krishnan via Datatracker <noreply@ietf.org> Thu, 13 June 2019 03:14 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: softwires@ietf.org
Delivered-To: softwires@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1B741120073; Wed, 12 Jun 2019 20:14:16 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Suresh Krishnan via Datatracker <noreply@ietf.org>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-softwire-map-radius@ietf.org, Yong Cui <cuiyong@tsinghua.edu.cn>, Ian Farrer <ianfarrer@gmx.com>, softwire-chairs@ietf.org, ianfarrer@gmx.com, softwires@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.97.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Suresh Krishnan <suresh@kaloom.com>
Message-ID: <156039565603.27176.8339230655144973930.idtracker@ietfa.amsl.com>
Date: Wed, 12 Jun 2019 20:14:16 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/pRwhiGdGxjT4nEQycPSsz7fFIV4>
Subject: [Softwires] Suresh Krishnan's Discuss on draft-ietf-softwire-map-radius-24: (with DISCUSS and COMMENT)
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.29
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Jun 2019 03:14:16 -0000

Suresh Krishnan has entered the following ballot position for
draft-ietf-softwire-map-radius-24: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-softwire-map-radius/



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

I am really glad to see this document getting published. It has been a long
while in the making.

This should be easy to clear but I would like to make sure that the calculation
used here to determine TLV lengths is accurate.

* In Sections 3.1.3.3., 3.1.4.1., 3.1.4.2., 3.1.5.2, 3.3.3. the TLV-Length is
shown to be 4+length of the contents of the TLV-Data (either the ipv6pref or
the ipv4pref). Maybe I am missing something, but I think this should be
2+length of the contents of the TLV-Data instead.

Can you please clarify how you arrived at 4+x instead of 2+x?


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

* Section 3.1.3.3.

The datatype for Softwire46-DMR is misspelt.

OLD:
The attribute Softwire46-DMR is of type ip6pref

NEW:
The attribute Softwire46-DMR is of type ipv6pref

* Not a strong opinion but I think RFC7596, RFC7597 and RFC7599 should probably
be normative instead of informative.