Re: [Softwires] Suresh Krishnan's Discuss on draft-ietf-softwire-map-radius-24: (with DISCUSS and COMMENT)

Suresh Krishnan <Suresh@kaloom.com> Thu, 13 June 2019 12:33 UTC

Return-Path: <Suresh@kaloom.com>
X-Original-To: softwires@ietfa.amsl.com
Delivered-To: softwires@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0D05312004D; Thu, 13 Jun 2019 05:33:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=kaloom.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L1iZET8lFo0d; Thu, 13 Jun 2019 05:33:40 -0700 (PDT)
Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660094.outbound.protection.outlook.com [40.107.66.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E8A512000F; Thu, 13 Jun 2019 05:33:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kaloom.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9WmUkJP5nkgCBLuy2I8KEfhHDqCrVPMZOhHZKI7pPBU=; b=oSvyUn6SDtBaYt1fg3BDtz/hJ6YaDYeM9ZVZL8ixucpHXb06vU1NaQNzmHPqzcvccSGArcWtMq3LhARljHHcJX3TLPtbvfDyCwq7fzl0bNxgcWXUYAO9oD8my4YO9XFC9oHJtyRugfs/s2TrcXkCuAOWwRyPQumP1ke7VtqbFNY=
Received: from YQXPR0101MB1815.CANPRD01.PROD.OUTLOOK.COM (52.132.78.33) by YQXPR0101MB0918.CANPRD01.PROD.OUTLOOK.COM (52.132.76.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.12; Thu, 13 Jun 2019 12:33:37 +0000
Received: from YQXPR0101MB1815.CANPRD01.PROD.OUTLOOK.COM ([fe80::f809:2192:850a:9c33]) by YQXPR0101MB1815.CANPRD01.PROD.OUTLOOK.COM ([fe80::f809:2192:850a:9c33%4]) with mapi id 15.20.1987.012; Thu, 13 Jun 2019 12:33:37 +0000
From: Suresh Krishnan <Suresh@kaloom.com>
To: "mohamed.boucadair@orange.com" <mohamed.boucadair@orange.com>
CC: The IESG <iesg@ietf.org>, "draft-ietf-softwire-map-radius@ietf.org" <draft-ietf-softwire-map-radius@ietf.org>, Yong Cui <cuiyong@tsinghua.edu.cn>, Ian Farrer <ianfarrer@gmx.com>, "softwire-chairs@ietf.org" <softwire-chairs@ietf.org>, "softwires@ietf.org" <softwires@ietf.org>
Thread-Topic: Suresh Krishnan's Discuss on draft-ietf-softwire-map-radius-24: (with DISCUSS and COMMENT)
Thread-Index: AQHVIZYX9okKQF4duU6c49xchZbgPaaZDj7wgAB3BgA=
Date: Thu, 13 Jun 2019 12:33:37 +0000
Message-ID: <8B2E2AF2-1EF1-4A91-BA75-81F1E2FEB289@kaloom.com>
References: <156039565603.27176.8339230655144973930.idtracker@ietfa.amsl.com> <787AE7BB302AE849A7480A190F8B93302EAA5F84@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
In-Reply-To: <787AE7BB302AE849A7480A190F8B93302EAA5F84@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=Suresh@kaloom.com;
x-originating-ip: [45.19.110.76]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 41e72b92-5f5a-418b-e6dc-08d6effb5bac
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YQXPR0101MB0918;
x-ms-traffictypediagnostic: YQXPR0101MB0918:
x-microsoft-antispam-prvs: <YQXPR0101MB091839A11D694C70C415866BB4EF0@YQXPR0101MB0918.CANPRD01.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0067A8BA2A
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(346002)(396003)(366004)(136003)(39850400004)(51914003)(189003)(199004)(3846002)(6116002)(54896002)(6512007)(6916009)(53546011)(68736007)(186003)(6506007)(26005)(486006)(229853002)(99286004)(25786009)(66066001)(102836004)(36756003)(236005)(2351001)(5660300002)(4326008)(76176011)(86362001)(2501003)(561944003)(14454004)(71200400001)(71190400001)(72206003)(256004)(80792005)(66946007)(64756008)(73956011)(66476007)(66446008)(66556008)(76116006)(91956017)(316002)(54906003)(6246003)(2906002)(5640700003)(476003)(81156014)(8936002)(81166006)(6486002)(508600001)(11346002)(2616005)(6436002)(446003)(33656002)(53936002)(8676002)(7736002)(518174003); DIR:OUT; SFP:1102; SCL:1; SRVR:YQXPR0101MB0918; H:YQXPR0101MB1815.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: kaloom.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: Lk767yDtBWnxE+42H5DKxmpmt3e9htS5cx06yWk9t8dLqvX9m4wv1rF+6jGt3avhQaCiKzh0IE+BEN39I16PAHoYWOaeck8wvgSSk7cuyyascdwugydGPmXWVDqT0u0AMFhXJPJePTpNushMpuVB55k421yVaKky87I/iS+ZvBFwj+s3WRfALiTFsO2SEPGHCCYiIIbstd/W3CSV+/wOuQFJKFFMhV1AdKhdiR5CXKQUecL0ndWV7dwjqya53mjqj8n+Upor8DOu5ze2eWzpO8swR7/ssUe+1uciSo8rlfe+q3RVBa30Lz6aDuOgXbielGOCUcNdTU4ZbLKA41cfAobGYYEqIr7bIWEi44r2OY48abRhJssWq1neM8L9HtJ1BLd9uwpxW9AjulZ5hcnNFpMjEzy7wRRHR5ABVvq7Xgc=
Content-Type: multipart/alternative; boundary="_000_8B2E2AF21EF14A91BA7581F1E2FEB289kaloomcom_"
MIME-Version: 1.0
X-OriginatorOrg: kaloom.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41e72b92-5f5a-418b-e6dc-08d6effb5bac
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2019 12:33:37.2022 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 47d58e26-f796-48e8-ac40-1c365c204513
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Suresh@kaloom.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR0101MB0918
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/xH5izK_8EOfuKcL30Drv17QXzbU>
Subject: Re: [Softwires] Suresh Krishnan's Discuss on draft-ietf-softwire-map-radius-24: (with DISCUSS and COMMENT)
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Jun 2019 12:33:43 -0000

Hi Med,
  Thanks for the quick response.

On Jun 13, 2019, at 2:00 AM, mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com> wrote:

Re-,

Please see inline.

Cheers,
Med

-----Message d'origine-----
De : Suresh Krishnan via Datatracker [mailto:noreply@ietf.org]
Envoyé : jeudi 13 juin 2019 05:14
À : The IESG
Cc : draft-ietf-softwire-map-radius@ietf.org<mailto:draft-ietf-softwire-map-radius@ietf.org>; Yong Cui; Ian Farrer;
softwire-chairs@ietf.org<mailto:softwire-chairs@ietf.org>; ianfarrer@gmx.com<mailto:ianfarrer@gmx.com>; softwires@ietf.org<mailto:softwires@ietf.org>
Objet : Suresh Krishnan's Discuss on draft-ietf-softwire-map-radius-24:
(with DISCUSS and COMMENT)

I am really glad to see this document getting published. It has been a
long
while in the making.

This should be easy to clear but I would like to make sure that the
calculation
used here to determine TLV lengths is accurate.

* In Sections 3.1.3.3., 3.1.4.1., 3.1.4.2., 3.1.5.2, 3.3.3. the TLV-Length
is
shown to be 4+length of the contents of the TLV-Data (either the ipv6pref
or
the ipv4pref). Maybe I am missing something, but I think this should be
2+length of the contents of the TLV-Data instead.

Can you please clarify how you arrived at 4+x instead of 2+x?

[Med] 1 octet (TLV-Type) +  1 octet (TLV-Length) + 1 octet (Reserved) + 1 octet (Prefix Length) + Length of the prefix.

I suspect you were confused with the prefix names provided in the tlv description. These should not be interpreted as referring to "Reserved+Prefix Length+Prefix", but to the prefix.

Yes. I think this labeling is confusing because the inner field is called “Prefix” instead of "dmr-ipv6-prefix” which is the whole datatype. I would have been happier with 2+Length of TLV-Data.


I reordered slightly the description text to avoid such confusion.

Sounds good. Send over the new text proposal and I will clear.




----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

* Section 3.1.3.3.

The datatype for Softwire46-DMR is misspelt.

OLD:
The attribute Softwire46-DMR is of type ip6pref

NEW:
The attribute Softwire46-DMR is of type ipv6pref

[Med] Fixed. Thank you.

Excellent.

Thanks
Suresh