Re: [Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-03

"Eric Vyncke (evyncke)" <evyncke@cisco.com> Mon, 08 April 2019 14:25 UTC

Return-Path: <evyncke@cisco.com>
X-Original-To: softwires@ietfa.amsl.com
Delivered-To: softwires@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 580C21203D6; Mon, 8 Apr 2019 07:25:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=WR8ksloa; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=hIuNcy1/
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wzG4IcTgyaeC; Mon, 8 Apr 2019 07:25:46 -0700 (PDT)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2DDE71203C3; Mon, 8 Apr 2019 07:25:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2826; q=dns/txt; s=iport; t=1554733546; x=1555943146; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=MapkpsRzzsHfgkdrci7M/hyBm+RDoNifAuikgeku1Ao=; b=WR8ksloa60oOhs7hh5XBib+VtfDKQG613vBqfJA7RATOx7rWIcEWRNQZ z0rMMHphcA61YyUUqs0yX5XP9qqr89bVSxHK+ooKgcmG207bWKgJjy2vz UwVyR0bN86BGQIDPEtjd/oi2gXsbSyJkXn5qy85z0b40EQQOPqNSmEAfZ 0=;
IronPort-PHdr: =?us-ascii?q?9a23=3AtaFXiBT2Le7mb2KtMdGrOBDQUtpsv++ubAcI9p?= =?us-ascii?q?oqja5Pea2//pPkeVbS/uhpkESXBdfA8/wRje3QvuigQmEG7Zub+FE6OJ1XH1?= =?us-ascii?q?5g640NmhA4RsuMCEn1NvnvOiEkDcJJV1JN9HCgOk8TE8H7NBXf?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AcAADJWKtc/49dJa1lGgEBAQEBAgE?= =?us-ascii?q?BAQEHAgEBAQGBUQUBAQEBCwGBPVADaFQgBAsnhA6DRwOEUopVgleXGIEuFIE?= =?us-ascii?q?QA1QOAQEYCwmDekYCF4VOIjQJDQEBAwEBCQECAQJtHAyFSwIEAQEhEQwBASw?= =?us-ascii?q?LAQ8CAQgaAhESAwICAiULFAEQAgQBDQWDIgGBXQMVAQIMoxwCihRxgS+CeQE?= =?us-ascii?q?BBYE1AoNBGIIMAwWBCyUBi0YXgUA/gTgfgkw+gmEBAQOBGUUHECMFgksxggQ?= =?us-ascii?q?ijRaMDoxlCQKIAYwAGpRciFKDAYYijVwCBAIEBQIOAQEFgU84gVZwFTsqAYJ?= =?us-ascii?q?BggoMF4NMhRSFP3KBKI9FAQE?=
X-IronPort-AV: E=Sophos;i="5.60,325,1549929600"; d="scan'208";a="255373043"
Received: from rcdn-core-7.cisco.com ([173.37.93.143]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 08 Apr 2019 14:25:45 +0000
Received: from XCH-ALN-010.cisco.com (xch-aln-010.cisco.com [173.36.7.20]) by rcdn-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id x38EPiaK007168 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 8 Apr 2019 14:25:44 GMT
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-ALN-010.cisco.com (173.36.7.20) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 8 Apr 2019 09:25:44 -0500
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 8 Apr 2019 10:25:43 -0400
Received: from NAM04-BN3-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 8 Apr 2019 10:25:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MapkpsRzzsHfgkdrci7M/hyBm+RDoNifAuikgeku1Ao=; b=hIuNcy1/mCIvINa57hgVQbmrgAUC+6+VrY+PH6DgcQj8Wb1zAXm3bwLhENwEeq9FhLl7oJcfd7nBMcOPFWxgWZjylB7/dHB5XIgYCCEhhaTh9/Re0QT7ln96xpTVOhQ9Nkx6RdiFuI84cyTfXUxQEzGYASYWBCIWq3Lfl4XE7xE=
Received: from MN2PR11MB4144.namprd11.prod.outlook.com (20.179.150.210) by MN2PR11MB3549.namprd11.prod.outlook.com (20.178.250.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.21; Mon, 8 Apr 2019 14:25:41 +0000
Received: from MN2PR11MB4144.namprd11.prod.outlook.com ([fe80::9158:74ee:b94a:d51f]) by MN2PR11MB4144.namprd11.prod.outlook.com ([fe80::9158:74ee:b94a:d51f%3]) with mapi id 15.20.1771.011; Mon, 8 Apr 2019 14:25:41 +0000
From: "Eric Vyncke (evyncke)" <evyncke@cisco.com>
To: "mohamed.boucadair@orange.com" <mohamed.boucadair@orange.com>, "Andy Bierman" <andy@yumaworks.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "softwires@ietf.org" <softwires@ietf.org>, "draft-ietf-softwire-iftunnel.all@ietf.org" <draft-ietf-softwire-iftunnel.all@ietf.org>
Thread-Topic: [Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-03
Thread-Index: AQHU6k6NFpJT5vENikGamAt9J+oxfqYrfcmAgAb9BIA=
Date: Mon, 8 Apr 2019 14:25:41 +0000
Message-ID: <A5C122C3-B193-4EC0-AD91-C92259975612@cisco.com>
References: <155431760907.22784.16246569281973305806@ietfa.amsl.com> <787AE7BB302AE849A7480A190F8B93302EA59FDC@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
In-Reply-To: <787AE7BB302AE849A7480A190F8B93302EA59FDC@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
Accept-Language: fr-BE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.17.1.190326
authentication-results: spf=none (sender IP is ) smtp.mailfrom=evyncke@cisco.com;
x-originating-ip: [2001:420:c0c1:36:811c:18de:c3f7:41f0]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f71ec5e9-b99e-492b-cbf3-08d6bc2e148f
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR11MB3549;
x-ms-traffictypediagnostic: MN2PR11MB3549:
x-ms-exchange-purlcount: 2
x-microsoft-antispam-prvs: <MN2PR11MB3549EC39F9C54FBB2E102882A92C0@MN2PR11MB3549.namprd11.prod.outlook.com>
x-forefront-prvs: 0001227049
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(376002)(396003)(346002)(366004)(199004)(189003)(25786009)(97736004)(82746002)(102836004)(54906003)(8936002)(33656002)(110136005)(83716004)(46003)(2906002)(99286004)(6506007)(2501003)(229853002)(6486002)(105586002)(106356001)(76176011)(68736007)(316002)(71200400001)(36756003)(6436002)(966005)(81166006)(14454004)(71190400001)(81156014)(58126008)(478600001)(476003)(486006)(7736002)(8676002)(86362001)(6116002)(2616005)(446003)(11346002)(6246003)(4326008)(186003)(53936002)(5660300002)(14444005)(256004)(305945005)(6306002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3549; H:MN2PR11MB4144.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: WyU/GtP4siYboHzpdSOtXGoc1TgfKJNBprnhhoJ8E8ChWSwqq5khf9TP6PDskqGMUw19C/lKEX9KbF4D70uQMZDCPm0mxa0lBxPbYehoZZJHWRh7jLyeIJNk9hCTvx5kKqP+GHBXypudWi8kNJXV1pCkKPeex6TEBMGOPnkFoqDIlWCGvqoVrN6g+uCOMBxFFksqS0uer4f9rjBPVH/gNoO3PhEqkoisFcedmMJ9Vn6BYaO5WuFb0Gmiqm4Koi4O4X2E8u68V/nFZxdHHg5BCYYKIPNJlsZki4t9qwWPIIKUUgL65jPzeVYvQvskJIuqfmOyLb+iCmP+FTED0i4KCRTCvBuhzsZLllgP5fKTe+jO88GU2GELUCJPiaHwK3GexvSWD1uYLp8OabtPvwl9UmUi0ITuxOUNc7ZN6excWX8=
Content-Type: text/plain; charset="utf-8"
Content-ID: <268DB9125C16EE4CB231437CB88A064F@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f71ec5e9-b99e-492b-cbf3-08d6bc2e148f
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 14:25:41.6707 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3549
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.20, xch-aln-010.cisco.com
X-Outbound-Node: rcdn-core-7.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/softwires/zCsjYYLWDZT5NL1RiijOTW4ErWk>
Subject: Re: [Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-03
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/softwires/>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Apr 2019 14:25:48 -0000

Thank you Andy and Med

-éric

On 04/04/2019, 07:42, "Softwires on behalf of mohamed.boucadair@orange.com"; <softwires-bounces@ietf.org on behalf of mohamed.boucadair@orange.com>; wrote:

    Hi Andy,
    
    Good catch.
    
    I updated the draft to take into account your review: https://tools.ietf.org/html/draft-ietf-softwire-iftunnel-04 
    
    Thank you. 
    
    Cheers,
    Med
    
    > -----Message d'origine-----
    > De : Softwires [mailto:softwires-bounces@ietf.org] De la part de Andy Bierman
    > via Datatracker
    > Envoyé : mercredi 3 avril 2019 20:53
    > À : yang-doctors@ietf.org
    > Cc : softwires@ietf.org; draft-ietf-softwire-iftunnel.all@ietf.org
    > Objet : [Softwires] Yangdoctors early review of draft-ietf-softwire-iftunnel-
    > 03
    > 
    > Reviewer: Andy Bierman
    > Review result: Ready with Nits
    > 
    > The iana-tunnel-type module has no errors or nits of any kind.
    > The ietf-extension-example module has no errors of any kind, and 1 nit.
    > The document appears to follow all YANG usage guidelines (but 1) correctly.
    > 
    > I have a minor comment about the example module. I guess it has to use <CODE
    > BEGINS>. (The <EXAMPLE BEGINS> discussion did not go anywhere).
    > 
    > This module looks a little too real to average users, especially after tools
    > extract it from the RFC and put it in the YangModels repo under the
    > standard/ietf/RFC directory.
    > 
    > You should rename the ietf-extension-example module to
    > example-iftunnel-extension (or anything starting with "example-"). The module
    > should not begin with "ietf-" unless it is a real module.
    > 
    > 
    > _______________________________________________
    > Softwires mailing list
    > Softwires@ietf.org
    > https://www.ietf.org/mailman/listinfo/softwires
    
    _______________________________________________
    Softwires mailing list
    Softwires@ietf.org
    https://www.ietf.org/mailman/listinfo/softwires