IETF Logo Mail Archive

[lamps] 2nd AD Review: draft-ietf-lamps-hash-of-root-key-cert-extn-05

Roman Danyliw <rdd@cert.org> Mon, 20 May 2019 15:10 UTC

Return-Path: <rdd@cert.org>
X-Original-To: spasm@ietfa.amsl.com
Delivered-To: spasm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 276631201A3 for <spasm@ietfa.amsl.com>; Mon, 20 May 2019 08:10:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MW2Q49cmOgjI for <spasm@ietfa.amsl.com>; Mon, 20 May 2019 08:10:26 -0700 (PDT)
Received: from taper.sei.cmu.edu (taper.sei.cmu.edu [147.72.252.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0F038120170 for <spasm@ietf.org>; Mon, 20 May 2019 08:10:25 -0700 (PDT)
Received: from korb.sei.cmu.edu (korb.sei.cmu.edu [10.64.21.30]) by taper.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x4KFAOF0013149 for <spasm@ietf.org>; Mon, 20 May 2019 11:10:25 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 taper.sei.cmu.edu x4KFAOF0013149
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1558365025; bh=L0736UkDeDnDhv3G3lY4QJFu9UmErWKGIDSH59XUt64=; h=From:To:Subject:Date:From; b=ZEiDANrFRU5n48iFihd0q8+7uC0ftvTBVTT5isJO7ndpp1kolfAOwcxACIM0JKGcA QEexVnkc7NklsNTwuFVi1uRQftH2T9dNc4mx4eStCmE2HfPzl9Vgm2sR/m77JgVwTV YvSwP7Yx+pD302igxUxhfzYL31GxRdG9eg71lF0g=
Received: from CASSINA.ad.sei.cmu.edu (cassina.ad.sei.cmu.edu [10.64.28.249]) by korb.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x4KFA6Gq030855 for <spasm@ietf.org>; Mon, 20 May 2019 11:10:06 -0400
Received: from MARATHON.ad.sei.cmu.edu ([10.64.28.250]) by CASSINA.ad.sei.cmu.edu ([10.64.28.249]) with mapi id 14.03.0439.000; Mon, 20 May 2019 11:10:06 -0400
From: Roman Danyliw <rdd@cert.org>
To: "spasm@ietf.org" <spasm@ietf.org>
Thread-Topic: 2nd AD Review: draft-ietf-lamps-hash-of-root-key-cert-extn-05
Thread-Index: AdUPG0jfMZh9av8bTgu763jbPOGi/w==
Date: Mon, 20 May 2019 15:10:05 +0000
Message-ID: <359EC4B99E040048A7131E0F4E113AFC01B336DBC6@marathon>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.22.6]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/6ZnebPwZ0hq46VVOwizfSFcEsls>
Subject: [lamps] 2nd AD Review: draft-ietf-lamps-hash-of-root-key-cert-extn-05
X-BeenThere: spasm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is a venue for discussion of doing Some Pkix And SMime \(spasm\) work." <spasm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spasm>, <mailto:spasm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm/>
List-Post: <mailto:spasm@ietf.org>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spasm>, <mailto:spasm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 May 2019 15:10:28 -0000

Hi!

Thanks for iteration and improvements from IETF LC discussion.  I'm pick-up this draft from the AD hand-off (and did another review despite being in the "Waiting for Writeup" state).   It is in good shape.  I have the following nits:

(1) (Editorial Nit) Section 1.2.  "Generated" doesn't seem like the right word to describe a formal notation/syntax for a certificate.

(2) Section 3.  Per "The definition of EXTENSION and HashAlgorithm can be found in [RFC5912]", HashAlgorithm isn't referenced in the ASN.1 syntax.  I believe it should be s/HashAlgorithm/AlgorithmIdentifier/.

I'm advancing the draft to IESG Evaluation.

Roman

v2.23.0 | Report a Bug | By Email