Re: [lamps] Lars Eggert's No Objection on draft-ietf-lamps-documentsigning-eku-05: (with COMMENT)

Sean Turner <sean@sn3rd.com> Sat, 27 August 2022 01:28 UTC

Return-Path: <sean@sn3rd.com>
X-Original-To: spasm@ietfa.amsl.com
Delivered-To: spasm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 59018C14CE2B for <spasm@ietfa.amsl.com>; Fri, 26 Aug 2022 18:28:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=sn3rd.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iLKGOP5B5d6G for <spasm@ietfa.amsl.com>; Fri, 26 Aug 2022 18:28:51 -0700 (PDT)
Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EF0DEC14CE29 for <spasm@ietf.org>; Fri, 26 Aug 2022 18:28:51 -0700 (PDT)
Received: by mail-qt1-x831.google.com with SMTP id x5so2527109qtv.9 for <spasm@ietf.org>; Fri, 26 Aug 2022 18:28:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sn3rd.com; s=google; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc; bh=jr/LdMUMSQ2zvVwWm0DX3HC/ekINd/7yACWPVaM35Dc=; b=EXajANlaUihHP0Si85dipoCVG1uJGREk7GZfLfuVqa01JqRbaKT89wzez+Y+NivqTg YIZzOC+Bot0lzC+kLcxTi1tmlP04Wl8ET7ro+ecupLH2+bINeJNBrA1R2AGyb62g5atO r4/7uAnmffHZftnuVHYayzFMpKHsM1mQm97Ng=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc; bh=jr/LdMUMSQ2zvVwWm0DX3HC/ekINd/7yACWPVaM35Dc=; b=tcLgSH9eCTN54e+ZbM5owolKp4mhKPkUl+tYU3a9qXkkNcNyNsIgC4kA/YE5//M6nS FyKwN12kzgwJOgsrF9NgvQBPiO/KmzdpfdeWpg/0v7HstQ99kPSBO3BV3grTKBgMTz3y qMED7JriLzipSjSkzmk+rLf/W+aaDKmksBSDmxGMQ3ihh4ddY3i5Jwtqaa3M85DatJXZ VQlBqk500Tr2GtHFgETFgj6EMZuhf60Mgj9a5kyoVW2boQ1fomCEMg6uCppyf95eIAuY R7cxlzXUtpTQkPgDgw84e1r/TDsTkmXVupzBPhO+1BAsB2mwi5aj3YANR9pFySViP3QN thyA==
X-Gm-Message-State: ACgBeo0l3HkHcjcHsgnjSxK6iNXEm62CvxyfNT45k7WTuLHffUckhelx QZVEo1M9EEal7PxyctcnLMCJTg==
X-Google-Smtp-Source: AA6agR5rXmF1yObcACROZINrfCZVE78VqMhsgS7hzbc2Z/o2lQSZwFp21AaMYZThcOAIcPKGUefWKQ==
X-Received: by 2002:ac8:5fc2:0:b0:343:202:7f46 with SMTP id k2-20020ac85fc2000000b0034302027f46mr1994106qta.418.1661563730987; Fri, 26 Aug 2022 18:28:50 -0700 (PDT)
Received: from smtpclient.apple ([2600:4040:253b:7300:a0dc:8c9a:42e0:e6]) by smtp.gmail.com with ESMTPSA id bm19-20020a05620a199300b006bac157ec19sm865237qkb.123.2022.08.26.18.28.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Aug 2022 18:28:50 -0700 (PDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
From: Sean Turner <sean@sn3rd.com>
In-Reply-To: <166126828449.22257.9885284596092018113@ietfa.amsl.com>
Date: Fri, 26 Aug 2022 21:28:49 -0400
Cc: The IESG <iesg@ietf.org>, draft-ietf-lamps-documentsigning-eku@ietf.org, lamps-chairs@ietf.org, spasm@ietf.org, Russ Housley <housley@vigilsec.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FBE16B3C-93CD-44DF-8B30-61691A4F998B@sn3rd.com>
References: <166126828449.22257.9885284596092018113@ietfa.amsl.com>
To: Lars Eggert <lars@eggert.org>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/MJLEDTKzmAn2oHm4EL1iqC3RbpU>
Subject: Re: [lamps] Lars Eggert's No Objection on draft-ietf-lamps-documentsigning-eku-05: (with COMMENT)
X-BeenThere: spasm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "This is a venue for discussion of doing Some Pkix And SMime \(spasm\) work." <spasm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spasm>, <mailto:spasm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm/>
List-Post: <mailto:spasm@ietf.org>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spasm>, <mailto:spasm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Aug 2022 01:28:56 -0000

Addressed via:
https://github.com/lamps-wg/documentsigning-eku/pull/20

> On Aug 23, 2022, at 11:24, Lars Eggert via Datatracker <noreply@ietf.org> wrote:
> 
> Lars Eggert has entered the following ballot position for
> draft-ietf-lamps-documentsigning-eku-05: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
> for more information about how to handle DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-lamps-documentsigning-eku/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> # GEN AD review of draft-ietf-lamps-documentsigning-eku-05
> 
> CC @larseggert
> 
> Thanks to Dale Worley for the General Area Review Team (Gen-ART) review
> (https://mailarchive.ietf.org/arch/msg/gen-art/1T23l8-kN8pEMqnQvh1ir3MsGVw)
> 
> ## Comments
> 
> ### Section 4, paragraph 1
> ```
>     The signed contents of Internet-Drafts are primarily intended to be
> ```
> Did you mean "documents" here instead of "Internet-Drafts"?
> 
> ## Nits
> 
> All comments below are about very minor potential issues that you may choose to
> address in some way - or ignore - as you see fit. Some were flagged by
> automated tools (via https://github.com/larseggert/ietf-reviewtool) so there
> will likely be some false positives. There is no need to let me know what you
> did with these suggestions.
> 
> ### Typos
> 
> #### Section 1, paragraph 3
> ```
> -    owner but by another vendor, the vender who own the KeyPurposeIds may
> -                                         ^
> -    not able to control use, or even do not know about the use. - If the
> -                                                                -
> +    owner but by another vendor, the vendor who own the KeyPurposeIds may
> +                                         ^
> ```
> 
> #### Section 4, paragraph 5
> ```
> -       party software proresses each restriction on "Excluded
> -                         ^
> +       party software processes each restriction on "Excluded
> +                         ^
> ```
> 
> ### Grammar/style
> 
> #### Section 4, paragraph 8
> ```
> the format it is handling (e.g. text, pdf, etc). 5. Implications for a Certif
>                                      ^^^
> ```
> File types are normally capitalized.
> 
> #### Section 4, paragraph 8
> ```
> ormat it is handling (e.g. text, pdf, etc). 5. Implications for a Certificati
>                                      ^^^
> ```
> A period is needed after the abbreviation "etc.".
> 
> ## Notes
> 
> This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
> [`ietf-comments` tool][ICT] to automatically convert this review into
> individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].
> 
> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
> [ICT]: https://github.com/mnot/ietf-comments
> [IRT]: https://github.com/larseggert/ietf-reviewtool
> 
> 
>