Re: [lamps] Opsdir last call review of draft-ietf-lamps-cms-hash-sig-08

"Joe Clarke (jclarke)" <jclarke@cisco.com> Thu, 18 July 2019 15:12 UTC

Return-Path: <jclarke@cisco.com>
X-Original-To: spasm@ietfa.amsl.com
Delivered-To: spasm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 762FF120433; Thu, 18 Jul 2019 08:12:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=jHZ8Rys0; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=xMF3iSyc
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XXnC4Hc9966l; Thu, 18 Jul 2019 08:12:50 -0700 (PDT)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6321F12041D; Thu, 18 Jul 2019 08:12:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2014; q=dns/txt; s=iport; t=1563462770; x=1564672370; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=RblOsGcJotCwhHYwRYXA+11TEk7iRCPkAu6U/x6NYPM=; b=jHZ8Rys0iyOtezEgaOId+DyloiFcJ2zJ7TTISUTfsA6fszVdAsA9zLub BGWT8cG21cFj292H/x3WjgmIW3bDYhg7yzJOFZhm6rHbC+Ndo/51ncBLS 9ftf3oeg9mOsC/aYQkgGKwK/f0lFcWhaRVgq9R3fD7cClDW7Hv+e0CUGH Q=;
IronPort-PHdr: 9a23:Gw9TjBWxRhuc1Ni6+9Wrg7pFfDzV8LGuZFwc94YnhrRSc6+q45XlOgnF6O5wiEPSA92J8OpK3uzRta2oGXcN55qMqjgjSNRNTFdE7KdehAk8GIiAAEz/IuTtank4F8BLTlxo13q6KkNSXs35Yg6arw==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0BHAAAujDBd/5ldJa1lHAEBAQQBAQcEAQGBUwcBAQsBgUNQA4FCIAQLKgqHWgOEUokqgjYll1CBLoEkA1QJAQEBDAEBLQIBAYRAAoJMIzQJDgEDAQEEAQECAQVthTwMhUoBAQEBAgESKAYBATcBBAsCAQgYHhAyJQIEDgUigwCBawMODwGhUwKBOIhggiOCeQEBBYJHgk0YghMJgTQBi14XgUA/gTgME4JMPoREd4JGgiaqZwkCghmUDBuCLYsxiiylBQIEAgQFAg4BAQWBUDiBWHAVZQGCQYJBCwEXg06KU3KBKYwiAYEgAQE
X-IronPort-AV: E=Sophos;i="5.64,278,1559520000"; d="scan'208";a="602274850"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 18 Jul 2019 15:12:48 +0000
Received: from XCH-ALN-014.cisco.com (xch-aln-014.cisco.com [173.36.7.24]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id x6IFCm5D006868 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 18 Jul 2019 15:12:48 GMT
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by XCH-ALN-014.cisco.com (173.36.7.24) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 18 Jul 2019 10:12:48 -0500
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 18 Jul 2019 11:12:47 -0400
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 18 Jul 2019 11:12:47 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PF3t2OnWlMaXmCk5l9f/bWyk3NmOo8BRkYuIgHEVrjlLt6OCfHfBsXUGbF0haRLkhC2EyYU5HF7uRilJMYogwzGhmLugCP/PrtCJp+ti3V0XWO+DuTggTStMQ0OqiRS9VZItw67xHP+TVRep38LBOIy5I9ujtXQxzwbUQ9iOA+UZM4RKuXbAoiFMP6ciahwvnPkuMuRQ76fwXapj2JGLZF9DLMN+leldQVRUqiTciUYPKnrhAXYLFAIAX6LOw5EdHqSzhgy3dzB4bewbVdxD+mrNlucg2CH/7dJjVndUrw+OpU8I5/23+vVTH9kz5HisYjXaItUnrmA7GSb+pXGccw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJ+hVId1A8tqTmwVxln7puECEXpvrse35J94KqO0JQA=; b=diwfbC63X2wj2AOGLy0G0ogUQI7QB2IhKAAOpuYY9KNFIoEAQZmgu/YPp1RO93/7IhdYHKn9X5hrGNGJM9jqLmjzyp4n8T/hNcczflMT9cBc++mOhVMejeFyqTZyPXFvVEBKs93xNVUnn7PLzaQFuarILFosjxHa3GmZ5iJ9xIUok76ExgHSs3n6D156nB6VFTCTeRUhNO61VWYO3vc6PInEgZPDuq+Sa2sxgNueib08rED7Lgfszf18XZT447N2ONx6vKCoJrBFPrQP4LfLxV6iniCYsgMv6jyyGbiLIuI/KcSyzXsjeRUfPqZ9Bnt5TrZ8I9J3gYeM0Lf4n6kGng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=cisco.com;dmarc=pass action=none header.from=cisco.com;dkim=pass header.d=cisco.com;arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJ+hVId1A8tqTmwVxln7puECEXpvrse35J94KqO0JQA=; b=xMF3iSycni81mc1Di5LdR1tmrQSNNtFnE10hCDuSRghbL77hvoo9hqUhk25nu/lnzbe9gdqD+G9TwiGLT2tZ1Hx1a3G5ib0gkNMR9gcyzTI1VQbT6Vb/hh4BXbS7Wv2o0aZnjcX1GpTPrnu1kKS1Fhh656b8/6zT2hplMOxbwjE=
Received: from CH2PR11MB4200.namprd11.prod.outlook.com (10.141.118.161) by CH2PR11MB4197.namprd11.prod.outlook.com (10.141.127.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Thu, 18 Jul 2019 15:12:46 +0000
Received: from CH2PR11MB4200.namprd11.prod.outlook.com ([fe80::bdd3:4aa6:bd05:b271]) by CH2PR11MB4200.namprd11.prod.outlook.com ([fe80::bdd3:4aa6:bd05:b271%5]) with mapi id 15.20.2073.012; Thu, 18 Jul 2019 15:12:46 +0000
From: "Joe Clarke (jclarke)" <jclarke@cisco.com>
To: Russ Housley <housley@vigilsec.com>
CC: "ops-dir@ietf.org" <ops-dir@ietf.org>, LAMPS WG <spasm@ietf.org>, IETF <ietf@ietf.org>
Thread-Topic: [lamps] Opsdir last call review of draft-ietf-lamps-cms-hash-sig-08
Thread-Index: AQHVPXWvO4M31kNhTUewTCMZe3KLfqbQe5WA
Date: Thu, 18 Jul 2019 15:12:46 +0000
Message-ID: <0F62A3BB-DABB-4507-9DB0-B9789C21E616@cisco.com>
References: <156337089593.25931.11629242002096530442@ietfa.amsl.com> <1B12401A-D643-4A59-AC70-CB5CDBA7E846@vigilsec.com>
In-Reply-To: <1B12401A-D643-4A59-AC70-CB5CDBA7E846@vigilsec.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=jclarke@cisco.com;
x-originating-ip: [70.231.19.155]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 36c604a3-d102-4585-44a4-08d70b926401
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:CH2PR11MB4197;
x-ms-traffictypediagnostic: CH2PR11MB4197:
x-microsoft-antispam-prvs: <CH2PR11MB419708621BD2FC3AC7EFA6BEB8C80@CH2PR11MB4197.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3968;
x-forefront-prvs: 01026E1310
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(39860400002)(366004)(376002)(346002)(51914003)(199004)(189003)(3846002)(64756008)(68736007)(66446008)(71190400001)(76116006)(66556008)(71200400001)(6116002)(229853002)(91956017)(99286004)(4326008)(476003)(6512007)(14454004)(6506007)(76176011)(486006)(36756003)(5660300002)(81156014)(53936002)(53546011)(66066001)(66476007)(33656002)(8936002)(66946007)(86362001)(305945005)(7736002)(446003)(11346002)(102836004)(6916009)(54906003)(6486002)(81166006)(8676002)(2616005)(186003)(26005)(2906002)(478600001)(25786009)(6246003)(256004)(316002)(14444005)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:CH2PR11MB4197; H:CH2PR11MB4200.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: EQpFHONLQFv1Vm/PkKL3zu3KpYXPWBCvEy74EBJCyPeEU8YnOSMKN9TMcpvX7zIoPeWkh2gX76RJmmEDiIXnYATdv0fzqZGNbvH15IwWw8XcA/RsG2J0Z+vNxkt/oazVNJbOr/MhRQBJBEL2WuSfaTtKMxjdSMmeA2QxmA19aFlJovawJxjiL0EZ48CE+n06gL5QscLH89k6pwZBV3kBcpfA+RIjDxvUMyezgm956ILPqklwJ3w0TfL2Spa7tm9ha2WRH7ZgQdYq9N/Xxg0c0nOtWbcK7KFqOSxi7g5iY4PVoNUY5xn6OKfUOoXi3I4tZFj8RaefGzmLBoDesGQ7/1qgGvoME6B6vKZxQMp4RWjgccqsxqRQB+Ta/sjGB8vbWWB+Ztxza0Dpzyu+VenyR23VM6mttXg3OMwxAcHBsx4=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BA50F06B36C47640AD12023F3FB47FB8@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 36c604a3-d102-4585-44a4-08d70b926401
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 15:12:46.5690 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jclarke@cisco.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4197
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.24, xch-aln-014.cisco.com
X-Outbound-Node: rcdn-core-2.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/Z5NgsouIzhUbt0ZmJXnojpnxkWw>
Subject: Re: [lamps] Opsdir last call review of draft-ietf-lamps-cms-hash-sig-08
X-BeenThere: spasm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is a venue for discussion of doing Some Pkix And SMime \(spasm\) work." <spasm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spasm>, <mailto:spasm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm/>
List-Post: <mailto:spasm@ietf.org>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spasm>, <mailto:spasm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jul 2019 15:12:53 -0000

Thanks for all the fixes, Russ.

Joe

> On Jul 18, 2019, at 10:32, Russ Housley <housley@vigilsec.com> wrote:
> 
> Joe:
> 
> Thanks for the careful review.
> 
>> Reviewer: Joe Clarke
>> Review result: Ready
> 
> Good to hear.
> 
>> I have been assigned to review this document as part of the ops directorate. 
>> This document describes conventions for using the HSS/LMS with CMS.  Overall,
>> this document is well-written, and I appreciate the considerations around
>> signing size and computation in the introduction.  This will help operators
>> properly evaluate the use of this algorithm.  I did find a few small nits.  One
>> thing that struck me on the first read is that you have to get to the
>> Introduction before HSS/LMS are expanded whereas CMS is expanded in the
>> abstract.  Might I suggest you expand HSS and LMS in the abstract as well?
> 
> I have done so:
> 
>   This document specifies the conventions for using the Hierarchical
>   Signature System (HSS) / Leighton-Micali Signature (LMS) hash-based
>   signature algorithm with the Cryptographic Message Syntax (CMS).  In
>   addition, the algorithm identifier and public key syntax are
>   provided.  The HSS/LMS algorithm is one form of hash-based digital
>   signature; it is described in RFC 8554.
> 
> I have also expanded it in the first sentence of the Introduction.
> 
>> Other nits:
>> 
>> Abstract:
>> 
>> s/for using the the HSS/LMS/for using the HSS/LMS/
> 
> No longer relevant with the revised Abstract above.
> 
>> ===
>> 
>> Section 2.3:
>> 
>> s/When this object identifier is used for a HSS/LMS/When this object identifier
>> is used for an HSS/LMS/
> 
> This is in Section 3, right?  If so, fixed.
> 
>> ===
>> 
>> Section 6:
>> 
>> s/cause an one-time key/cause a one-time key/
>> 
>> s/When generating a LMS key pair/When generating an LMS key pair/
> 
> Both fixed.
> 
> Russ