Re: [lamps] Opsdir last call review of draft-ietf-lamps-cmp-algorithms-12

["Brockhaus, Hendrik" <[e-mail]>]

Dear Quin Wu

Many thanks for your review. Please find my proposal below.

> Von: Qin Wu via Datatracker <[e-mail]>
> 
> Reviewer: Qin Wu
> Review result: Has Nits
> 
> I have reviewed this document as part of the Operational directorate's ongoing
> effort to review all IETF documents being processed by the IESG.  These
> comments were written with the intent of improving the operational aspects of
> the IETF drafts. Comments that are not addressed in last call may be included in
> AD reviews during the IESG review.  Document editors and WG chairs should
> treat these comments just like any other last call comments.
> 
> RFC4210 describes CMP protocol and specifies CMP algorithm use profile as part
> of PKI Management Message profile in the appendix. This document describes
> CMP algorithms and provides CMP algorithms classification and use profiles.
> 
> I believe this document is well written and ready for publication.
> 
> Major issue:
> No
> 
> Minor issues:
> 1.One thing is not clear to me is the exact relation between RFC4210 and this
> document. It seems this document separates CMP algorithm use profile
> discussion from Appendix of RFC4210 and expands it as a new document. If the
> answer is yes, I think it is worth clarifying this in the introduction. 2.Abstract
> highlights this document focuses on describing the convention for using
> algorithm with CMP. I feel most CMP algorithms use convention have already
> been documented in other specifications or RFCs, e.g., SHA2,SHAKE,RSA, ECDSA,
> etc.
> Therefore I am not sure abstract catches the essence of the content in this
> document. I feel this document can be seen as recipe book or playbook for
> developers. Maybe the abstract can be polished a little bit to reflect what it is.
> 

Old text:
   This document updates RFC 4210 describing the conventions for using
   concrete cryptographic algorithms with the Certificate Management
   Protocol (CMP).  CMP is used to enroll and further manage the
   lifecycle of X.509 certificates.

New text:
   This document describes the conventions for using several cryptographic
   algorithms with the Certificate Management Protocol (CMP).  CMP is used
   to enroll and further manage the lifecycle of X.509 certificates. This
   document also updates the algorithm use profile from RFC 4210 Appendix D.2.

Does this change sufficiently address your comment?

Hendrik