[lamps] Genart last call review of draft-ietf-lamps-rfc5751-bis-07

David Schinazi <dschinazi@apple.com> Fri, 27 April 2018 03:44 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: David Schinazi <dschinazi@apple.com>
To: gen-art@ietf.org
Cc: spasm@ietf.org, ietf@ietf.org, draft-ietf-lamps-rfc5751-bis.all@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152480069184.6083.13015201919417586774@ietfa.amsl.com>
Date: Thu, 26 Apr 2018 20:44:51 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/aIlg0ITNUeUjIPA1wsMiqbk1TEA>
Subject: [lamps] Genart last call review of draft-ietf-lamps-rfc5751-bis-07

Reviewer: David Schinazi
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lamps-rfc5751-bis-07
Reviewer: David Schinazi
Review Date: 2018-04-26
IETF LC End Date: 2018-04-27
IESG Telechat date: Not scheduled for a telechat

Summary:
    This document is clearly written and does a nice job of explaining the
    rationale and historical context of the decisions it made.

Major issues:
    None noticed during this review

Minor issues:
    I was slightly confused by the description of AuthEnvelopedData in 2.4.4:
    it seems to describe data protected by a symmetric AEAD but then mentions
    asymmetric keys. But this could be due to my lack of expertise in S/MIME.

Nits/editorial comments:
    I believe the RFC2119 reference should also mention RFC8174.

Re: [lamps] [Gen-art] Genart last call review of … Alissa Cooper
[lamps] Genart last call review of draft-ietf-lam… David Schinazi
Re: [lamps] Genart last call review of draft-ietf… Jim Schaad