IETF Logo Mail Archive

Re: [lamps] Francesca Palombini's No Objection on draft-ietf-lamps-crmf-update-algs-05: (with COMMENT)

Russ Housley <housley@vigilsec.com> Mon, 05 April 2021 16:08 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: spasm@ietfa.amsl.com
Delivered-To: spasm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F45C3A1E2A for <spasm@ietfa.amsl.com>; Mon, 5 Apr 2021 09:08:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V3f2nE2VNGzQ for <spasm@ietfa.amsl.com>; Mon, 5 Apr 2021 09:08:50 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 45C9F3A1E28 for <spasm@ietf.org>; Mon, 5 Apr 2021 09:08:50 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 7CE60300BC0 for <spasm@ietf.org>; Mon, 5 Apr 2021 12:08:47 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id wGSWIN-6PfBG for <spasm@ietf.org>; Mon, 5 Apr 2021 12:08:45 -0400 (EDT)
Received: from [192.168.1.161] (pool-141-156-161-153.washdc.fios.verizon.net [141.156.161.153]) by mail.smeinc.net (Postfix) with ESMTPSA id 25EC630046B; Mon, 5 Apr 2021 12:08:45 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <161763568043.428.1549139655189448444@ietfa.amsl.com>
Date: Mon, 05 Apr 2021 12:08:45 -0400
Cc: IESG <iesg@ietf.org>, LAMPS <spasm@ietf.org>, Tim Hollebeek <tim.hollebeek@digicert.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E555AA10-6513-4E46-B397-EB719515A746@vigilsec.com>
References: <161763568043.428.1549139655189448444@ietfa.amsl.com>
To: Francesca Palombini <francesca.palombini@ericsson.com>
X-Mailer: Apple Mail (2.3445.104.17)
Archived-At: <https://mailarchive.ietf.org/arch/msg/spasm/z9GLWqWWm7V4M_SQ8DvdXkSb0_I>
Subject: Re: [lamps] Francesca Palombini's No Objection on draft-ietf-lamps-crmf-update-algs-05: (with COMMENT)
X-BeenThere: spasm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is a venue for discussion of doing Some Pkix And SMime \(spasm\) work." <spasm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spasm>, <mailto:spasm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spasm/>
List-Post: <mailto:spasm@ietf.org>
List-Help: <mailto:spasm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spasm>, <mailto:spasm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2021 16:08:52 -0000

Francesca:

> Thank you for the work on this document. I only have one typo and one very
> minor comment, feel free to take them or leave them.
> 
> Francesca
> 
> 1. -----
> 
>   *  HMAC-SHA1 [HMAC][SHS] is not boken yet, but there are much
> 
> FP: s/boken/broken

Clearly, this will be fixed.  But if this is the only comment, we may wait until AUTH48.

> 2. -----
> 
>   The algorithm identifier for HMAC-SHA256 is defined in [RFC4231]:
> 
>   The algorithm identifier for AES-GMAC [AES][GMAC] with a 128-bit key
> 
> FP: suggestion to replace "identifier" with "ASN.1 object identifier"

I used "algorithm identifier" to include the parameters as well as the OID.

Russ

v2.23.0 | Report a Bug | By Email