Re: [spring] WG Adoption Call for draft-raza-spring-sr-policy-yang

"Kamran Raza (skraza)" <skraza@cisco.com> Mon, 27 July 2020 23:17 UTC

Return-Path: <skraza@cisco.com>
X-Original-To: spring@ietfa.amsl.com
Delivered-To: spring@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32ED93A0A06; Mon, 27 Jul 2020 16:17:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.62
X-Spam-Level:
X-Spam-Status: No, score=-9.62 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=jKilKSaM; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=LNAB9pmN
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BYKMSv41pezy; Mon, 27 Jul 2020 16:17:36 -0700 (PDT)
Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6668C3A0A0B; Mon, 27 Jul 2020 16:17:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4718; q=dns/txt; s=iport; t=1595891856; x=1597101456; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=QpbAZxauD3tGAyfqgD4zpe4n5tg7kIdP6zvQp0ipfn0=; b=jKilKSaMyxzE2Jj+FkGZ2V+RVZ8J64L8Awvzd6KrS0IlTQPDiHGTDed8 hA2w85qVZw85xxTrheH3hn4hQBy40Mx7xaJDxyzb6lqYvAV46XRkUwatE FUihXse84k/1s+uQv2PfaVFLzt5x8+xe6vP1xYrUWcDUVaWaNgZ/F0nty U=;
IronPort-PHdr: =?us-ascii?q?9a23=3AsxnDbBwLe2CCDvHXCy+N+z0EezQntrPoPwUc9p?= =?us-ascii?q?sgjfdUf7+++4j5ZRWDt/pohV7NG47c7qEMh+nXtvXmXmoNqdaEvWsZeZNBHx?= =?us-ascii?q?kClY0NngMmDcLEbC+zLPPjYyEgWsgXUlhj8iK0NEFUHID1YFiB6nG35CQZTx?= =?us-ascii?q?P4Mwc9L+/pG4nU2sKw0e36+5DabwhSwjSnZrYnJxStpgKXvc4T0oY=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CvAAA1Xx9f/5NdJa1XCRoBAQEBAQE?= =?us-ascii?q?BAQEBAwEBAQESAQEBAQICAQEBAUCBSoFSUQdvWC8shDSDRgONVooCjl+BQoE?= =?us-ascii?q?RA1ULAQEBDAEBGAsKAgQBAYQIRAIXghACJDgTAgMBAQsBAQUBAQECAQYEbYV?= =?us-ascii?q?cDIVyAQEEAQEQCwYRDAEBLAsBDwIBCBgCAiYCAgIfBgsVEAEBBAENBSKDBAG?= =?us-ascii?q?CSwMuAQ6kcQKBOYhhdoEygwEBAQWBR0FCgmkNC4IOAwaBDioBgmyDWYY3GoI?= =?us-ascii?q?AgREnHIJNPoIaQgEBAwGBIQUBCAoBIRchAoJcM4ItkmCGf5sKN04Kgl6IVow?= =?us-ascii?q?jhHUDFQmCe4lIkyGSFoougmGSCwIEAgQFAg4BAQWBaiNncHAVOyoBgj5QFwI?= =?us-ascii?q?Njh4MF4NOhRSFQnQCNQIGAQcBAQMJfI8TAQE?=
X-IronPort-AV: E=Sophos;i="5.75,404,1589241600"; d="scan'208";a="530350427"
Received: from rcdn-core-11.cisco.com ([173.37.93.147]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 27 Jul 2020 23:17:35 +0000
Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by rcdn-core-11.cisco.com (8.15.2/8.15.2) with ESMTPS id 06RNHZ1o032549 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 27 Jul 2020 23:17:35 GMT
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 27 Jul 2020 18:17:35 -0500
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 27 Jul 2020 19:17:34 -0400
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 27 Jul 2020 18:17:34 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nulR/Kp754F64tBN8zxVjk386DbTwZq73zkOb746khkilT4RtLxZC88MUQsTxNXgory4JMFXBiNYNdW9A50XYq/VmBkQqpitw/1xuYEOKfo+hgkMWpPIcMPPgEENFdJZRFexcIRRUok5rUcuV6K5Lh3JoihWErUQYy32TCEIymyP8weZh5Cm0490c831xvtSgRZu7XO2Yw8a6IdFP4gsM1K1dfw51/X/uq6cIzErxeM8hYuJtBsr7k2HdPHiWscKDN5ur8YvvDfWg8UfpAQkE4Df7SzT1QBRvTSMY/NIEbS1zQ5INqJIXk+T4VjuCKbNi88+dGtk8dvay6ywbqvyzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QpbAZxauD3tGAyfqgD4zpe4n5tg7kIdP6zvQp0ipfn0=; b=SD3zeoUtZSbIK0JzK3VhK1//fppsYBnIDxAvzOiTmhiX8LVO4ksT89A1phFEC9k5pk/SuplgwG4ioaMdcn0uQmP2dBr51d9Z98CUq0lnRqcXhoIG4AvEjfYGj2incYHU45FuhkX6PVBMoFve44FgEUDbvEcRey0JCtiqCSzQ4m6DO94Q0Q6XhejnPq9VFDOuAM4rGghtMeeZNBbuTHj4clkRPV6VMwh5BattO6B79BmGf/kubLykoT6zFARNONGLYx5SdFBa9yWJuNncBOvEt/dw2QC2HV3cimnh/FCqysZxsTfwmWJFkGq4U/0aTs6roomKK6jtIbegG2WeuCTD7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QpbAZxauD3tGAyfqgD4zpe4n5tg7kIdP6zvQp0ipfn0=; b=LNAB9pmNYbDik5ejttBJdFu9lAINukM+GGepvWwy9wW0tmbBnEMURziznAziw7UC6tsSPI1Q00oEBeTaqBL6l+6TmpOkzsqF5CI+iCKctU4pcGon4POjRIjCvjmpXp3Nkn4EtoW5gdJOjzy8TOzLD9umh3pxI6O+G7iSZQLtsBs=
Received: from BL0PR11MB3412.namprd11.prod.outlook.com (2603:10b6:208:7c::32) by BL0PR11MB3491.namprd11.prod.outlook.com (2603:10b6:208:33::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Mon, 27 Jul 2020 23:17:33 +0000
Received: from BL0PR11MB3412.namprd11.prod.outlook.com ([fe80::65a4:74c5:1cae:df25]) by BL0PR11MB3412.namprd11.prod.outlook.com ([fe80::65a4:74c5:1cae:df25%5]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020 23:17:33 +0000
From: "Kamran Raza (skraza)" <skraza@cisco.com>
To: Dhruv Dhody <dhruv.ietf@gmail.com>, James Guichard <james.n.guichard@futurewei.com>
CC: "spring@ietf.org" <spring@ietf.org>, "spring-chairs@ietf.org" <spring-chairs@ietf.org>
Thread-Topic: [spring] WG Adoption Call for draft-raza-spring-sr-policy-yang
Thread-Index: AdZZKaSGxpyazIbbQ8apsNd5+9RdDgJffw6AAGi8aAA=
Date: Mon, 27 Jul 2020 23:17:33 +0000
Message-ID: <EA0925B0-FE20-49DD-B549-BCCB510CA7C0@cisco.com>
References: <DM6PR13MB306618BA16B9D6A1EA0A3B78D2600@DM6PR13MB3066.namprd13.prod.outlook.com> <CAB75xn7m3Af63OFbRCOYRsjM5SMe3CAPAxWpyWgwGLEWS+hv5g@mail.gmail.com>
In-Reply-To: <CAB75xn7m3Af63OFbRCOYRsjM5SMe3CAPAxWpyWgwGLEWS+hv5g@mail.gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.39.20071300
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [2607:fea8:e1c0:e:698d:21d6:919b:467e]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 674606ff-2165-490a-1923-08d832833df5
x-ms-traffictypediagnostic: BL0PR11MB3491:
x-microsoft-antispam-prvs: <BL0PR11MB349199D6223A1B8F80C5E195D0720@BL0PR11MB3491.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QJWYUjBlyOkZ0fwrYCnyX7HvYpQCvKwCr3ySY4WbmmtvRfFw5xxmZvc6SHitlBshKLk6Rs8OI8wCUuurJUr93O6kbg+MoF2DPOQcNBtRfOB5kGXrfGAEpj1EjqavD9Ua/Cfx2C+hcKzjVvKU3RXznDgLNSl528k7a6qmeWjZzOE99NtCzJ6VqJQtAUjN4D3gl+J4AhOJtxjL4JNbgBIkswN4m05OooujYTPqzgD0L1f7HQRRHlzu3t7vYyq9GilXX0fhOuhQuRnYycb4Xk+oCbLUdVsL28OBJS+id5Bgcyip9OHQxwMkSrqapelIU+FjlWqm0gWuAelNYJHUFG9sHtKk3oTYGj5/oZbgtxW/0KAZbm8qc7diX/any0WdtF70dO1HGEsFBUyK5gjCyc/cnA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR11MB3412.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(136003)(346002)(396003)(366004)(5660300002)(36756003)(66556008)(66446008)(66476007)(53546011)(8936002)(76116006)(71200400001)(33656002)(478600001)(66946007)(186003)(64756008)(83380400001)(6506007)(2906002)(66574015)(2616005)(110136005)(6486002)(4326008)(86362001)(8676002)(966005)(6512007)(54906003)(316002); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: HEWs3+A3vrNXbftLJa760B8w8f3BGR/hNmXs8/fpE8nnlcTHepV1dR0gDjTYgyc0DZvO+W5CHsLQ5TG8iQEE4tE0hFqp9iI/vBLslQKDR6xker/Vi9j2vftVCkehE1HQ2inRL8Sd4pDJa8t/hRILuqAoGJqPY7NRAIOh4z80DSI/s/82SonCleBfUz+iWSjfTw5QjaI/eVCIrbNjGYokH8L+hSj0vpEqaW6xGd4qdt5nFg40rpQc1OX5wuZxcm1q3lB6sHvRUJ5Nj8P3X/VLjrXP5I0Ty6K/cGaHf8kn1ey26NkNHzJeiiVTsMF7zelj8DvW9Jb7A4Un0esZInLjvL9p2RmPFS5xuOG5R6z0w05UCj5hZOWLrJx1cx3u2KfKtxG4W4F/hwmnMJj1evXOaNJ3Qj5CFxfFMrSZ/lhIzL6tU5vExlCveeCxGgBeAyLdHe8GvJMjDTuV6yJMu0+/u+n21SxwrtImamV1GdpH8LKWWyVZhKHVMskKvSHSmPX/DsM+sKz76ST4fO+4bFuKaCZk/0qL36OK6DgqmJIpO64=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <748FBE580ED0A449B8C9809F67301A4E@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3412.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 674606ff-2165-490a-1923-08d832833df5
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2020 23:17:33.2084 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3wElrMRgXvp7Tk5Iezd8b3HV/yxbraMl7QJOVAehb8gQWtb89QBkBdJw7n3Zs3Xn3UFRSOmfA4Mp+CcZ8Qui+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3491
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.14, xch-rcd-004.cisco.com
X-Outbound-Node: rcdn-core-11.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/spring/HOXrdsZPlm_ojzsfpEywtQ9CnUw>
Subject: Re: [spring] WG Adoption Call for draft-raza-spring-sr-policy-yang
X-BeenThere: spring@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Source Packet Routing in NetworkinG \(SPRING\)" <spring.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spring>, <mailto:spring-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spring/>
List-Post: <mailto:spring@ietf.org>
List-Help: <mailto:spring-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spring>, <mailto:spring-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jul 2020 23:17:43 -0000

Thanks Dhuruv for your support and useful review/comments. 
We will discuss within authors and incorporate comments accordingly.

On 2020-07-25, 1:20 PM, "spring on behalf of Dhruv Dhody" <spring-bounces@ietf.org on behalf of dhruv.ietf@gmail.com> wrote:

    Hi WG,

    I support the adoption of this work and I have thoughts on how to
    improve the document -

    Some questions/comments -

    - Why do you have the config and the state trees separately in Figures
    2 and 3? That's out of fashion with NMDA!
    - I hope this model is applicable for both the headend router as well
    as for the controller. If yes, we should highlight that as well as
    make sure the YANG model takes care of this. For example, counters,
    path-forwarding_state, etc
    - I found the top-level container "traffic-engineering" on top as out
    of place when the rest of the SR-Policy work does not use it.
    - Regarding segment types, I have a few thoughts -
      * I-D.ietf-spring-segment-routing-policy uses Type A,B,C,...,
    whereas you use Type 1,2,3..
      * Should we use identity here instead of enum, to allow for future
    segment types to be defined?
     - Please describe the use of group-id and subgroup-id for
    disjointness, this was not clear from yang or the text
     - The constraints currently defined are quite minimal, is there any
    reason for that? I feel more constraint and optimization criteria
    should be supported.
     - How do we relate the information in forwarding-paths to the
    candidate path? Also, where would the inactive candidate paths
    received from BGP/PCEP stored in this model (assumption that
    forwarding-paths are active only)? Maybe segment-lists for dynamic
    paths should be added as well?

    Suggestions for improving YANG -
    - Add references such as during import and important leaves.
    - Use generic-path-disjointness in ietf-te-types instead of defining a
    new identity for path-disjointness
    - Use of identity for protocol-origin-type (instead of enum) to allow
    other protocols to be added easily
    - Use of labels as a key in a label stack is incorrect (see grouping
    mpls-label-stack), as you could have the same label repeated in the
    stack.
    - sid-algorithm, color, and name should have its own typedef
    - Run "pyang -f yang --keep-comments --yang-line-length 69 <FILE>" to
    help with formatting.

    Thanks!
    Dhruv

    On Mon, Jul 13, 2020 at 9:08 PM James Guichard
    <james.n.guichard@futurewei.com> wrote:
    >
    > Dear WG:
    >
    >
    >
    > This email begins a 2 week WG adoption call for https://datatracker.ietf.org/doc/draft-raza-spring-sr-policy-yang/ ending Monday 27th July 2020.
    >
    >
    >
    > Please speak up if you support or oppose adopting this document into the WG. Please also provide comments/reasons for that support (or lack thereof). Silence will not be considered consent.
    >
    >
    >
    > Thanks!
    >
    >
    >
    > Jim, Joel & Bruno
    >
    >
    >
    >
    >
    >
    >
    > _______________________________________________
    > spring mailing list
    > spring@ietf.org
    > https://www.ietf.org/mailman/listinfo/spring

    _______________________________________________
    spring mailing list
    spring@ietf.org
    https://www.ietf.org/mailman/listinfo/spring