Re: [spring] Yangdoctors last call review of draft-ietf-spring-sr-yang-20

Yingzhen Qu <yingzhen.qu@futurewei.com> Wed, 26 August 2020 20:24 UTC

From: Yingzhen Qu <yingzhen.qu@futurewei.com>
To: Ladislav Lhotka <lhotka@nic.cz>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "spring@ietf.org" <spring@ietf.org>, "draft-ietf-spring-sr-yang.all@ietf.org" <draft-ietf-spring-sr-yang.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-spring-sr-yang-20
Thread-Index: AQHWehVL6ibBl740LkCSVJAG2mn0IalIz6KAgAFKrYCAAEoMAA==
Date: Wed, 26 Aug 2020 20:24:45 +0000
Message-ID: <C852AA8B-3C65-4345-B397-1DD84B408D59@futurewei.com>
References: <159827349041.30993.687894019314723215@ietfa.amsl.com> <F9079AD4-474A-4AFF-BA98-5D340FA31B50@futurewei.com> <87h7sphjeo.fsf@nic.cz>
In-Reply-To: <87h7sphjeo.fsf@nic.cz>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/16.40.20081000
Content-Type: text/plain; charset="utf-8"
Content-ID: <5608933B93744A46A8CA12FB74A0F7DF@namprd13.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 10ef4118-3633-48ee-2887-08d849fe127a
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2020 20:24:45.1532 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9pu0At3bgO4FhWR2QOozJR+h485RnL5W2EkSLvE4hS/cwl8AN+wdNaN56IX3Cyun9KwXJt6TmE1mj1mFPZ5uAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3729
Archived-At: <https://mailarchive.ietf.org/arch/msg/spring/PkRICKU-Tb4s_bRm8rYcdgyJJJQ>
Subject: Re: [spring] Yangdoctors last call review of draft-ietf-spring-sr-yang-20
X-BeenThere: spring@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Source Packet Routing in NetworkinG \(SPRING\)" <spring.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spring>, <mailto:spring-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spring/>
List-Post: <mailto:spring@ietf.org>
List-Help: <mailto:spring-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spring>, <mailto:spring-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Aug 2020 20:24:51 -0000

Hi Lada,

Thanks for the review.  I've uploaded version -22 to address your comments. Please see my answers inline for details.

Thanks,
Yingzhen

On 8/26/20, 1:59 AM, "Ladislav Lhotka" <lhotka@nic.cz> wrote:

    Hi Yingzhen,

    please see my responses inline.

    Yingzhen Qu <yingzhen.qu@futurewei.com> writes:

    > Hi Lada,
    >
    > Thank you for your review, really appreciate. 
    >
    > I've uploaded version -21 to address your comments and please see detailed answers below inline starting with [YQ].
    >
    > Thanks,
    > Yingzhen
    >
    > On 8/24/20, 5:51 AM, "Ladislav Lhotka via Datatracker" <noreply@ietf.org> wrote:
    >
    >     Reviewer: Ladislav Lhotka
    >     Review result: Ready with Nits
    >

    ...

    >
    >     - The title of Section 8 should use plural "YANG Modules" because it contains
    >     three modules. It would also be helpful to introduce a subsection for each
    >     module.
    > [YQ]: changed the title and added an introduction of each module.

    I meant to add a subsection of sec. 8 for each module so that they are clearly separated and each of them easily accessible from the table of contents.

[YQ]: sorry for the misunderstanding. I've added a subsection for each module, and it does look better now.
    >
    >     - Due to the RFC line length limit, the example in Appendix A uses a line break
    >     inside a URI of a XML namespace declaration, which makes the XML invalid. This
    >     can be probably avoided by including the XML namespace declaration for "sr-cmn"
    >     in the top-level element, i.e.
    >
    >       <routing
    >         xmlns="urn:ietf:params:xml:ns:yang:ietf-routing"
    >         xmlns:sr-cmn="urn:ietf:params:xml:ns:yang:ietf-segment-routing-common">
    >
    >       If not, it would be better to use conventions of RFC 8792.
    >
    > [YQ]: I tried the format as your suggested, but somehow I could get it pass yanglint, so added "\" per RFC 8792.

    OK.

    >  
    >     - Assuming that the example is intended for human readers, it might be better
    >     to provide it in the JSON representation per RFC 7951.
    >
    > [YQ]: Added JSON format.

    Looks good, maybe only the first brace can be moved to the left.
[YQ]: fixed.

    Thanks, Lada

    >
    >

    -- 
    Ladislav Lhotka 
    Head, CZ.NIC Labs
    PGP Key ID: 0xB8F92B08A9F76C67

[spring] Yangdoctors last call review of draft-ie… Ladislav Lhotka via Datatracker
Re: [spring] Yangdoctors last call review of draf… Yingzhen Qu
Re: [spring] Yangdoctors last call review of draf… Yingzhen Qu