Re: [spring] Last Call: <draft-ietf-spring-sr-yang-23.txt> (YANG Data Model for Segment Routing) to Proposed Standard

tom petch <daedulus@btconnect.com> Wed, 18 November 2020 12:39 UTC

Return-Path: <daedulus@btconnect.com>
X-Original-To: spring@ietfa.amsl.com
Delivered-To: spring@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF18E3A1853; Wed, 18 Nov 2020 04:39:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t-2SdDksSAxw; Wed, 18 Nov 2020 04:39:26 -0800 (PST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2110.outbound.protection.outlook.com [40.107.22.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B33EE3A1855; Wed, 18 Nov 2020 04:39:24 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Corc0GDVcb5fuG5XLqu+nv9+nUaClf0l2YjesfgcSe5iGYAIzsUsglsqDhraNo4bqEU7vcVpQBxxhqPRhU1PXAVaDiRqz3XODK15v4H7ka/ZjL+vQFl5p7hFsIBSYqd8R6R8wCG+Sr+wYysKWPqg8YnYwFDRBBOoV8Gg0b1sddluLycpjXsTsFp6MJwGExfwolAMeo0zLBDHU4BxA4T4A//ta2Hpk1rNJDnQWYTQbAVIM4VpF34p4RqZOPMjVPpf4asiFRNC9CjgJuhm0+mprzvSs4l7dMcMtUODkTkAc5PBoscH3cwPwKESpxEGU0ATf89wbWDTzygTD7Pk5+FkPg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lp4Jjm2ryffauzsQZrgRWdcgWNQ2JcVMrHBj0WCnPrU=; b=LT+zd+zpjp57OngMD3ghDDkBSn6MFYkiIWHJMFdTLvydaW559BSTYWaSmBvqwiLzS4ExM449NIZ4gDOmOT2r3z3J+85DZkZnEBsYymC9FnuxrqbnOIYgi4YCo8hSQ+GF5iOBvSdhmReAiBpDuQAYRTeGiqLdPST7aApWBH/Nyk6X4BGl0AI8NPLSSaJ80pK+3VkPyiRrRZBO2fBi1377PZ93lAhVeE22uxwnctP7GByqFVLCpnjLofX2QTEWvpMh5SX5M5jnUQfbAthlmTSDaH/ypYMkRvgRKr5mXHRjgCzJRzqDhKEiLL9HUIsya2CgLpULTDMa4mih+R0xNY1qMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lp4Jjm2ryffauzsQZrgRWdcgWNQ2JcVMrHBj0WCnPrU=; b=QnS0z0fG9tr+6Y/TLYImPQqY3AQ/qEONGK2a1y44ikMJUwBRUz1YZaE2QaGSoiAwf1LDjZuVxUE+nDSRnTeSUMxopDbBQxYB+/eHg0y3VSUNYPp4GWpyYk9lXHqvgQEh2je2skWQqQEO9ZlifXZez/5hM+oMHHWqbtEuLRMY4eA=
Authentication-Results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=btconnect.com;
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8) by VI1PR0701MB7039.eurprd07.prod.outlook.com (2603:10a6:800:195::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.15; Wed, 18 Nov 2020 12:39:22 +0000
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::6407:6ea2:f517:eeae]) by VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::6407:6ea2:f517:eeae%8]) with mapi id 15.20.3589.016; Wed, 18 Nov 2020 12:39:22 +0000
To: last-call@ietf.org
References: <160555515848.16672.7178345983262697681@ietfa.amsl.com>
Cc: spring-chairs@ietf.org, spring@ietf.org, Joel Halpern <jmh@joelhalpern.com>, draft-ietf-spring-sr-yang@ietf.org
From: tom petch <daedulus@btconnect.com>
Message-ID: <5FB515F7.1020306@btconnect.com>
Date: Wed, 18 Nov 2020 12:39:19 +0000
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
In-Reply-To: <160555515848.16672.7178345983262697681@ietfa.amsl.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [86.146.121.140]
X-ClientProxiedBy: LO2P265CA0101.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::17) To VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.65] (86.146.121.140) by LO2P265CA0101.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3589.20 via Frontend Transport; Wed, 18 Nov 2020 12:39:22 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cd2fe871-ed70-48f2-7302-08d88bbef9d8
X-MS-TrafficTypeDiagnostic: VI1PR0701MB7039:
X-Microsoft-Antispam-PRVS: <VI1PR0701MB7039BF8171CB3763FB9CB167C6E10@VI1PR0701MB7039.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: p96tQuyXn1TiYKn9bmx0iJNbH3wILhy5HjnPGDEfmdF0PqMvnJY6mu1gmIt0wWj8EB8Jh32FSVX/Ivg3HpZw7b1bGxMR1KKlfr7RUt3NtCnoNYuFz7AAqQ/1Y9X63qyyVCvsgSUYXGtLz8Oi/NkgViaea34mxhNht+EFAqmgIx8aUxgj3SpYWx/c0LKkQBI6A5F3J60pWubigyFpg+Rp9bcNI4bSNCfJQQRBKgOHSBmcyHah26fJN91kBbUU/GgwXSI5Q2nrSjVCIpxoysokhIUh8fP5evGjhHklU7VR9+2SXM2uucZYsCvQuqOz0IJRzT8XisuaTLcWD1+/PSvhHSV//i+h48StzlmQArokJR74v3p62NCsyTNpCx2WBsw30HYpYXzqVHJUSMM+W2OXCw==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR07MB6704.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(346002)(366004)(376002)(136003)(396003)(16576012)(2616005)(956004)(478600001)(86362001)(33656002)(2906002)(36756003)(8676002)(8936002)(966005)(316002)(6666004)(5660300002)(16526019)(6916009)(66574015)(4326008)(4001150100001)(186003)(53546011)(26005)(6486002)(66476007)(66556008)(83380400001)(66946007)(52116002)(87266011); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: 4zaYiyAbxRc8xxwyfzvqbXsBc3e5LQVRxruOCvmIXkItB1Q2Bo8zu7+uUzmtViT6HEC4lLunkUN5w6Vt/lVx+oBwI1zlEo0ycu2JdpXSBp3jJoG61JSdRpHerCGSDXoTk5xPa15XLTKHBTGFV6ERTWrCLK6+dRy1pUM1lKJUDNS9GlJj0+M2eXMy9NUsfrcrNinI3UMeNdMAjJTQeADB8lrlMSLJbqL863utsr43fE1MgT9bTXuT52dfGc94Jrlz1F5oANK5Thp6GKcD7/CzXwKUoVBJVtRYc8ZVKShqMCSpWkzHSt7YVQWIsm7uGnk3SXax3ftFO5C5jeDIqo5M/bbIkNscIuJ6SlZ8bfkmxLQ2xnzn6WNxJcKfv+dTrNbv3GBKyD5BcpbB+exFPm8Mt9axIqWjPrHKN1yl1bWMeoVeABlAAl4nIRALworKeYc1djMreX9vQJebDhRnj2SGON6yF4VNwKP8eCdKSuzJ2FYIr52dnGqvl/jHc/jBZjj72DJO2aDXjSkQoMtrwnVMLD92bOXLuZUV7ZszSD1D0NRMX+mu0W7W1km5JkiC5GMu0423sA/xoLkiJcBlYeGK70mBdPawA8vOpFogXvf3vMu4J8oklg2Ez2BPnDi4XLMGXtXqr25odwRckuwYdBeUaQ==
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd2fe871-ed70-48f2-7302-08d88bbef9d8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR07MB6704.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2020 12:39:22.8109 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5V/WTyh9ijvHljziV9X5kUKtRXsM5L2LnYTHmsEjqzIiQjYJi4W3Xgzc7+9c1CO9BB8Z159RCVTWcY9xGJ9Kdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB7039
Archived-At: <https://mailarchive.ietf.org/arch/msg/spring/fLRA7Qn4FO3c1b6srbV4ru4eRno>
Subject: Re: [spring] Last Call: <draft-ietf-spring-sr-yang-23.txt> (YANG Data Model for Segment Routing) to Proposed Standard
X-BeenThere: spring@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Source Packet Routing in NetworkinG \(SPRING\)" <spring.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spring>, <mailto:spring-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spring/>
List-Post: <mailto:spring@ietf.org>
List-Help: <mailto:spring-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spring>, <mailto:spring-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Nov 2020 12:39:28 -0000

IANA Considerations does not register the module names used in the modules

Examples are IPv4 only, IPv6 would be good

BGP is included when it comes to defining a router-id but is ignored 
everywhere else, such as signalling MSD, protocol extensions etc

reference "RFC XXXX" would be improved by including the title in all 
cases not just some

the scheme http: appears in many places.  It would be lovely if this 
really was the scheme but I fear that it is not

module srcmn
  the upper bound must be larger
  the value must be greater
consistency is good - I think greater is better

8.3
operation states
usually operational

two imports lack references

typedef router-id
this is a well known type from RFC8394; it seems likely to confuse to 
redefine it with a related but different meaning

leaf enabled
enables protocol extensions
which protocols?

leaf protected
it is used to protect
how does it do that:-)

enum dual
... In this case will be advertised with backup flag set
What is the backup flag?  It does not feature in RFC8660.  Needs an 
explanation and reference

container link-msd
  list link-msds
    leaf msd
The usual YANG convention is for a list to be plural and the leaf 
singular.  You have the plural list but not the leaf.  And who needs the 
container?  This is mpls not a common module that might be augmented so 
what does the container give apart from complexity?

list policy
  leaf string
YANG string caters for very large items of very complex character sets. 
  Is that desirable?

leaf used
will used plus free equal size?

Indicates if the binding is /instal/installed/

notification-segment-routing-global-srgb-collision
a mix of conflict and collision;  consistency is good and I prefer the 
latter which is the name of the notification

containing /s/a/ mapping

... sid collision
again consistency good, prefer collision to conflicting

s.9
I would have thought the srgb worthy of mention under sensitive nodes

Tom Petch


On 16/11/2020 19:32, The IESG wrote:
>
> The IESG has received a request from the Source Packet Routing in Networking
> WG (spring) to consider the following document: - 'YANG Data Model for
> Segment Routing'
>    <draft-ietf-spring-sr-yang-23.txt> as Proposed Standard
>
> The IESG plans to make a decision in the next few weeks, and solicits final
> comments on this action. Please send substantive comments to the
> last-call@ietf.org mailing lists by 2020-11-30. Exceptionally, comments may
> be sent to iesg@ietf.org instead. In either case, please retain the beginning
> of the Subject line to allow automated sorting.
>
> Abstract
>
>
>     This document defines a YANG data model for segment routing
>     configuration and operation, which is to be augmented by different
>     segment routing data planes.  The document also defines a YANG model
>     that is intended to be used on network elements to configure or
>     operate segment routing MPLS data plane, as well as some generic
>     containers to be reused by IGP protocol modules to support segment
>     routing.
>
>
>
>
> The file can be obtained via
> https://datatracker.ietf.org/doc/draft-ietf-spring-sr-yang/
>
>
>
> No IPR declarations have been submitted directly on this I-D.
>
>
>
>
>
> _______________________________________________
> IETF-Announce mailing list
> IETF-Announce@ietf.org
> https://www.ietf.org/mailman/listinfo/ietf-announce
> .
>