Re: [spring] WG Adoption Call for draft-raza-spring-srv6-yang

Jeff Tantsura <jefftant.ietf@gmail.com> Sat, 25 July 2020 17:27 UTC

Return-Path: <jefftant.ietf@gmail.com>
X-Original-To: spring@ietfa.amsl.com
Delivered-To: spring@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9EFDC3A0D28; Sat, 25 Jul 2020 10:27:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YdpATubJHrvy; Sat, 25 Jul 2020 10:27:21 -0700 (PDT)
Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 809303A0D27; Sat, 25 Jul 2020 10:27:21 -0700 (PDT)
Received: by mail-pl1-x62b.google.com with SMTP id o1so6116622plk.1; Sat, 25 Jul 2020 10:27:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=PrRCDFkIrVBoC/wH67PConWKttBlLBh8bojL6FqCgmQ=; b=jAOm5ZAgVff+0aAjcajMS1pp2BSuoFq6R9At7Fn8FVOEzsmZbTNDI5XONsixPZkZoH YaN6qskrBd3BjW3QwWHCFMOhXg1qYj8O3tyjzLLuyTWtRyUfEDrtsXs0AwP9O+i9afJY aUZ5Y5Px63tivdbKpGIgYa6/wdU3jUWkmPRyFc/7SvgEsbt3FIJcGTxnx7+3e12JI1wQ pjBLvSLnW3vL+IQuAoQdYo3C1pyjd1eF3XnAOoDx1WOqY2ZT+KMHDzZewwLKxQjN7NuL xpl7TEiZHnL9REFYS9hidBSlM5O4OtHMB8oRr+MUIFUN89omGyT3FNt1B/R0ZJCioTGR wKjA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=PrRCDFkIrVBoC/wH67PConWKttBlLBh8bojL6FqCgmQ=; b=SXsbtG4S70FeU3LYcD8zrj6b2F20FSWmWUTYd2tr9FKP6BByUBaKht6F3fuC1tU5kS pNc/R0B8/CPtXPoP3s4rgn1IorSaT0ggg+sSwFaNSP2fbpkN0SJwvqe0I0XfUH1zfhJR kTfZcWnnVk85lphxHY/IMnZUCeLgz788wDN3i2d50s0Oy7s/hXhbPY7cGx6Cwm7aTZeT wTQL4MoSC2TjjODJNSWBzXfIzcxpoY8hYqaCY0zaF82ZXzTThio0/9OGEt55SPPZqCx+ MBRGX+GZj/s4nr4lyAInBk2+dSaO17y7RsIpshuE+jqCxm3aPMWoKi2P73qSRX9Ryn2E d5rQ==
X-Gm-Message-State: AOAM532aCarX40l8nqDpfyp8+P25c7b0i0Fx3lTlqwZFnznIaN+tCp3Y zQZNNMw/tgU9Ahf+urIXTF0a8woZfX0=
X-Google-Smtp-Source: ABdhPJwLCR8LiRyyycLOjAkDzdQOnHqgfaMAilnY8eBx7uBz/KT7m0jeS1LXD/MC1ut1wgxYPY8e1w==
X-Received: by 2002:a17:90a:6946:: with SMTP id j6mr9630159pjm.223.1595698040534; Sat, 25 Jul 2020 10:27:20 -0700 (PDT)
Received: from [192.168.1.8] (c-73-63-232-212.hsd1.ca.comcast.net. [73.63.232.212]) by smtp.gmail.com with ESMTPSA id c125sm9510713pfa.119.2020.07.25.10.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jul 2020 10:27:19 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Jeff Tantsura <jefftant.ietf@gmail.com>
Mime-Version: 1.0 (1.0)
Date: Sat, 25 Jul 2020 10:27:18 -0700
Message-Id: <6E3B7EB4-6BC7-4BE4-82A7-A09160D9140C@gmail.com>
References: <CAB75xn7rpM9XcqmC3CWFV3O43ZdT0X-XZmgqA0hJma4bWR4nWg@mail.gmail.com>
Cc: James Guichard <james.n.guichard@futurewei.com>, "spring@ietf.org" <spring@ietf.org>, "spring-chairs@ietf.org" <spring-chairs@ietf.org>
In-Reply-To: <CAB75xn7rpM9XcqmC3CWFV3O43ZdT0X-XZmgqA0hJma4bWR4nWg@mail.gmail.com>
To: Dhruv Dhody <dhruv.ietf@gmail.com>
X-Mailer: iPhone Mail (17F80)
Archived-At: <https://mailarchive.ietf.org/arch/msg/spring/ivT-NpXDce6k5v5TY7-4SDHO4oI>
Subject: Re: [spring] WG Adoption Call for draft-raza-spring-srv6-yang
X-BeenThere: spring@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Source Packet Routing in NetworkinG \(SPRING\)" <spring.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spring>, <mailto:spring-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spring/>
List-Post: <mailto:spring@ietf.org>
List-Help: <mailto:spring-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spring>, <mailto:spring-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Jul 2020 17:27:24 -0000

Very much with Dhruv here.
While the work is important and should be progressing, overall quality could be significantly improved.
Please use draft-ietf-spring-sr-yang as the example.

Regards,
Jeff

> On Jul 25, 2020, at 10:22, Dhruv Dhody <dhruv.ietf@gmail.com> wrote:
> 
> Hi WG,
> 
> I support the adoption of this work and I have thoughts on how to
> improve the document -
> 
> Some questions/comments -
> - Can the title of the I-D be improved?
> - Why do you have the config and the state trees separately in Figures
> 1 and 2? That's out of fashion with NMDA!
> - I hope this model is applicable for both the headend router as well
> as for the controller. If yes, we should highlight that as well as
> make sure the YANG model takes care of this. For example, counters,
> forwarding, etc
> - The node-capabilities are marked as read-only, but an operator may
> want to disable or enable these right?
> 
> Suggestions for improving YANG -
> - Update copyright year
> - path-attrs-cmn is described as "Path properties -common for v4/v6",
> in that case, is this the right yang model for it? and should it be in
> the generic SR model instead?
> - Typedef for algorithm could be useful, it is unit32 here but uint8
> in draft-ietf-spring-sr-yang
> - What is the purpose of the empty containers end, end_psp, end_usp,
> end_psp_usp, end_usd, end_psp_usd, end_usp_usd, end_psp_usp_usd? Are
> they placeholders for something?
> - Run this "pyang -f yang --keep-comments --yang-line-length 69
> <FILE>" to help you with formatting the yang model.
> 
> Thanks!
> Dhruv
> 
>> On Tue, Jul 14, 2020 at 3:22 AM James Guichard
>> <james.n.guichard@futurewei.com> wrote:
>> 
>> Dear WG:
>> 
>> 
>> 
>> This email begins a 2 week WG adoption call for https://datatracker.ietf.org/doc/draft-raza-spring-srv6-yang/ ending Monday 27th July 2020.
>> 
>> 
>> 
>> Please speak up if you support or oppose adopting this document into the WG. Please also provide comments/reasons for that support (or lack thereof). Silence will not be considered consent.
>> 
>> 
>> 
>> Thanks!
>> 
>> 
>> 
>> Jim, Joel & Bruno
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> _______________________________________________
>> spring mailing list
>> spring@ietf.org
>> https://www.ietf.org/mailman/listinfo/spring
> 
> _______________________________________________
> spring mailing list
> spring@ietf.org
> https://www.ietf.org/mailman/listinfo/spring