Re: [spring] WG Adoption Call for draft-raza-spring-srv6-yang

Yingzhen Qu <yingzhen.qu@futurewei.com> Sat, 25 July 2020 23:52 UTC

Return-Path: <yingzhen.qu@futurewei.com>
X-Original-To: spring@ietfa.amsl.com
Delivered-To: spring@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5FD343A0B97; Sat, 25 Jul 2020 16:52:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.09
X-Spam-Level:
X-Spam-Status: No, score=-2.09 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wAo1jQJrdpCz; Sat, 25 Jul 2020 16:52:45 -0700 (PDT)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2114.outbound.protection.outlook.com [40.107.244.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 325613A0B95; Sat, 25 Jul 2020 16:52:44 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dmflCz5uEjoeE6wJMjtxSAoZeg0Vx7aopzX4DdPziBfMH5CsjT2v20yE2F+A6bZvFLEvYZlHZVfeAeRJJInDFxSAMKeIs0Xmxn/2PeDArjMTqNc2fWleewHPIsYF9aZJf8BlHknBVe0KdDBQgbw+EjFd/8RqAG987X7xdvltKxdWPNih5WVDlf/LQJ5OQyu5tNP2yUokEhfMRDgBZQ5nvIeEMDlayWTqUM6Y/dvuknFmVOemkCTwZU9nV6B4vTpK77VotM3dmi7McEtCMtJuKl3kXbrlzJtm16DQS2jD4Or3r8ZtA12DUU/PDZZw8Eqva21a1QDduDau3cnSW/7rVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dc3Fv91kxFpqmluzc9bnZ3TpQH1YOshuSMaX+O1hdh0=; b=TqtGSFchkoyoE5H+ugG9HqfYWghBMwwmYnhLytJVWf0xacmC+m93BmXbs4SmmRleSt9qFiuMaJK9pGPAuGJQVIRvX3Y3PnhewvCqqbNANgSwNU39eIpzOm6yLlRQj1xETt71U7vzEzu7fCziRR/6hbvbXHy5tDiYSEvhq4cbeNuSe1EyVA1oefSlbxzRfM+LUj1sqYzfxrKWZX/oFBst2+M9P6ariDwK+nZ4IWBrPkGHobv0cIxkPXDcs3nGhDzVyPq5rANo1DTd8+Bym7nZzSWEjJejwYcXJPQSKZ2bVG8R9sTikJ1igrRDPUAGWyhzvJ2BSmdXJghwJzt8KTE+1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=futurewei.com; dmarc=pass action=none header.from=futurewei.com; dkim=pass header.d=futurewei.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dc3Fv91kxFpqmluzc9bnZ3TpQH1YOshuSMaX+O1hdh0=; b=dvj6SI5q+DlqSEpUHJ5USsg6dqXMzDW/9DlofPzShxE7LOKSXo+oIvhKqZIVr1thit4lIL6QS0mQVLjMhWjakiDG+xO3q9nu0burb1Sj7ievwzzkjhSjZorf8Q0csUOEjVG3c9PIO6ZM1Mkou6Y9umGAwiBcPjtbMienUfGtaLQ=
Received: from BY5PR13MB3048.namprd13.prod.outlook.com (2603:10b6:a03:188::21) by BY5PR13MB3298.namprd13.prod.outlook.com (2603:10b6:a03:1a7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.9; Sat, 25 Jul 2020 23:52:37 +0000
Received: from BY5PR13MB3048.namprd13.prod.outlook.com ([fe80::28f0:8a33:3418:b39b]) by BY5PR13MB3048.namprd13.prod.outlook.com ([fe80::28f0:8a33:3418:b39b%4]) with mapi id 15.20.3239.012; Sat, 25 Jul 2020 23:52:37 +0000
From: Yingzhen Qu <yingzhen.qu@futurewei.com>
To: Dhruv Dhody <dhruv.ietf@gmail.com>, James Guichard <james.n.guichard@futurewei.com>
CC: "spring@ietf.org" <spring@ietf.org>, "spring-chairs@ietf.org" <spring-chairs@ietf.org>
Thread-Topic: [spring] WG Adoption Call for draft-raza-spring-srv6-yang
Thread-Index: AdZZX0QDXPWnj1oGQQKGYsZR37MSlgJSM8uA///31YA=
Date: Sat, 25 Jul 2020 23:52:36 +0000
Message-ID: <D1853E06-9B5A-430F-B995-AAA6B61EC70A@futurewei.com>
References: <DM6PR13MB3066E4E4C5E2371952436AC2D2600@DM6PR13MB3066.namprd13.prod.outlook.com> <CAB75xn7rpM9XcqmC3CWFV3O43ZdT0X-XZmgqA0hJma4bWR4nWg@mail.gmail.com>
In-Reply-To: <CAB75xn7rpM9XcqmC3CWFV3O43ZdT0X-XZmgqA0hJma4bWR4nWg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1e.0.191013
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=futurewei.com;
x-originating-ip: [2601:646:9500:c900:4cb2:e7ee:165a:aae]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 96fbb74c-0f25-49c0-a8a8-08d830f5cf03
x-ms-traffictypediagnostic: BY5PR13MB3298:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BY5PR13MB3298A52E61E75A8FB2F8BF7CE1740@BY5PR13MB3298.namprd13.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: BSfwpS70/YBdgzk4oug9EZHUCkgxUlKV0oQybv/XLivzimU695h8johorH8Y1lfC8pz9XW6LNfK4/dDhJZNt9fZPf1GoTXy6hKHYbg1xZAMnLJdaFOEJck2h3sTc0ivKCifw4IadtqHEw2ZTRpfvslo4IbenmFK/T9/FevY6KoODmGtE/IRGwxmR7Cp1upyM1GST532KTmNF6vX3KyGaKzcAYsux/HHor4fOzEHIpu6AJVetiQlKRu1Ztxl1IQSqMyiiCnlPj4C/uVgGX7sXrvT1A7BFfnfFP4PDQxRmnlsNPiutNgkCbt8+b+ZRKozbzQJa5dL18YaCkpegjBw8yQixhV9YhYzelCULPhNh3rIOBylTnFcd/89gUirX/EWCiXsBbZ1lASo7ruQQuhgjPA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR13MB3048.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(39830400003)(396003)(366004)(136003)(71200400001)(8676002)(6636002)(966005)(4326008)(36756003)(5660300002)(66574015)(110136005)(316002)(186003)(2616005)(54906003)(83380400001)(53546011)(76116006)(6506007)(8936002)(33656002)(6486002)(508600001)(45080400002)(66946007)(86362001)(66476007)(66556008)(6512007)(44832011)(64756008)(66446008)(2906002); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: zlhbMNWn8agllMqGD/h4QNyidNI6OISGvolNqHUVtZlqZkPbUyntyJhb5a7nLaeS5KIrEh3qgL7BD/sBlQxhHBUrKsOXiGA69aF9Cac6UC+ijWCqeFlCHd9STaGGgY7gKBj8f9267XpPq8f9X9VSxxgDC0ZSfFHB/si7dHB+LdckDrnr6MtO+pwqvJ2RMDhs8TvFkxcpUFfLohDYNzGxqjI0gP2X4uR0DLs8/IzkwcEIyuwuyPz02sDugwNq7Kyx2VRciO+m8inzkgU0o7Ec4JE6GlU+vw9I312aH8FFeVRwDl1Ozsc15r3rkswRA7MZu/GPUYTCrIiXROZzpJDOsCWKeBYHX8ndwAfXr+JzOpft+dFYZaeKXRCQ8By3oh/52QiWtxudvXAVyVQmZmjYI7VE3rkJIOwo/E+i90Oab/8Rxp0PO4YSeCCZ3aQJUdqy+9Aq9iycHbJmdsBpQQQz1o7WwTs+vbAXtxLvadhRN9YyrhgDVQGn9h8FxrsXeFBY1Iv0fqOpK/INuw9s6/hYoXUYKLJY0wnNdwn+q5rKHFEjGhZU96ScMLqpBvAoAbgstGbLf2HCU39qeT9k7iJEIJCJA8Qx9TFGezyPaRBwXbfY4lVTiOlJqtfx8xv4YT/nfgQH5wg3TR91SSydI3y0XzWnb0drVauyREqIkDGs0fcfbnFr7HWzFWHC59xntSZ6vNx5vuoSPFxkfTqtL/X+0A==
Content-Type: text/plain; charset="utf-8"
Content-ID: <36AE6729A1861048B0ABCAA7014554D5@namprd13.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR13MB3048.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96fbb74c-0f25-49c0-a8a8-08d830f5cf03
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2020 23:52:36.9370 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VXaAcGT9Q28dO+ofG1kqg7hhv454N3KuUpRK5yjJpqyG91wtT5F8kAdUxGhIOxYMjF4uwSXZ7CEKlHSizr7pew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3298
Archived-At: <https://mailarchive.ietf.org/arch/msg/spring/oLSd4__VMMCfwXOT6DDt-30X6Vc>
Subject: Re: [spring] WG Adoption Call for draft-raza-spring-srv6-yang
X-BeenThere: spring@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Source Packet Routing in NetworkinG \(SPRING\)" <spring.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/spring>, <mailto:spring-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/spring/>
List-Post: <mailto:spring@ietf.org>
List-Help: <mailto:spring-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/spring>, <mailto:spring-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Jul 2020 23:52:48 -0000

Hi,

I agree with Dhruv's comments that there should not be separate configuration and state trees. 

Also "grouping" is overly used in the model, and I'd suggest the authors remove some groups when updating the draft.

Thanks,
Yingzhen


On 7/25/20, 10:23 AM, "spring on behalf of Dhruv Dhody" <spring-bounces@ietf.org on behalf of dhruv.ietf@gmail.com> wrote:

    Hi WG,
    
    I support the adoption of this work and I have thoughts on how to
    improve the document -
    
    Some questions/comments -
    - Can the title of the I-D be improved?
    - Why do you have the config and the state trees separately in Figures
    1 and 2? That's out of fashion with NMDA!
    - I hope this model is applicable for both the headend router as well
    as for the controller. If yes, we should highlight that as well as
    make sure the YANG model takes care of this. For example, counters,
    forwarding, etc
    - The node-capabilities are marked as read-only, but an operator may
    want to disable or enable these right?
    
    Suggestions for improving YANG -
    - Update copyright year
    - path-attrs-cmn is described as "Path properties -common for v4/v6",
    in that case, is this the right yang model for it? and should it be in
    the generic SR model instead?
    - Typedef for algorithm could be useful, it is unit32 here but uint8
    in draft-ietf-spring-sr-yang
    - What is the purpose of the empty containers end, end_psp, end_usp,
    end_psp_usp, end_usd, end_psp_usd, end_usp_usd, end_psp_usp_usd? Are
    they placeholders for something?
    - Run this "pyang -f yang --keep-comments --yang-line-length 69
    <FILE>" to help you with formatting the yang model.
    
    Thanks!
    Dhruv
    
    On Tue, Jul 14, 2020 at 3:22 AM James Guichard
    <james.n.guichard@futurewei.com> wrote:
    >
    > Dear WG:
    >
    >
    >
    > This email begins a 2 week WG adoption call for https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fdraft-raza-spring-srv6-yang%2F&amp;data=02%7C01%7Cyingzhen.qu%40futurewei.com%7C0b316d999f4f41b2edb008d830bf6a89%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637312945993728664&amp;sdata=TgKml9vtVT8T4Gak6DUmVaNJ14BAF7cyfccIv4oqm1o%3D&amp;reserved=0 ending Monday 27th July 2020.
    >
    >
    >
    > Please speak up if you support or oppose adopting this document into the WG. Please also provide comments/reasons for that support (or lack thereof). Silence will not be considered consent.
    >
    >
    >
    > Thanks!
    >
    >
    >
    > Jim, Joel & Bruno
    >
    >
    >
    >
    >
    >
    >
    >
    >
    > _______________________________________________
    > spring mailing list
    > spring@ietf.org
    > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fspring&amp;data=02%7C01%7Cyingzhen.qu%40futurewei.com%7C0b316d999f4f41b2edb008d830bf6a89%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637312945993728664&amp;sdata=nKQLkDrLqa%2FkXT6WDFdXJKAf%2FSuaay1paSp6VHfScPg%3D&amp;reserved=0
    
    _______________________________________________
    spring mailing list
    spring@ietf.org
    https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fspring&amp;data=02%7C01%7Cyingzhen.qu%40futurewei.com%7C0b316d999f4f41b2edb008d830bf6a89%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637312945993728664&amp;sdata=nKQLkDrLqa%2FkXT6WDFdXJKAf%2FSuaay1paSp6VHfScPg%3D&amp;reserved=0