Re: [stir] Nits in draft-ietf-stir-passport-08

Chris Wendt <chris-ietf@chriswendt.net> Wed, 12 October 2016 19:28 UTC

Return-Path: <chris-ietf@chriswendt.net>
X-Original-To: stir@ietfa.amsl.com
Delivered-To: stir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 06F6C129653 for <stir@ietfa.amsl.com>; Wed, 12 Oct 2016 12:28:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.598
X-Spam-Level:
X-Spam-Status: No, score=-2.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=chriswendt-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qnws7jKw9uYw for <stir@ietfa.amsl.com>; Wed, 12 Oct 2016 12:28:37 -0700 (PDT)
Received: from mail-qk0-x231.google.com (mail-qk0-x231.google.com [IPv6:2607:f8b0:400d:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1D8A512965F for <stir@ietf.org>; Wed, 12 Oct 2016 12:28:37 -0700 (PDT)
Received: by mail-qk0-x231.google.com with SMTP id n189so50701453qke.0 for <stir@ietf.org>; Wed, 12 Oct 2016 12:28:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chriswendt-net.20150623.gappssmtp.com; s=20150623; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=nhqlVm7aCc6hZi9ht6mRG/1z8J7nWvS2YXexo9kunvE=; b=zhGuLdv1Idp36F9uoz/57AZn379OUqkbBSj0OR7vJj8ecKNOUMdIefgy8KIf7e7C41 03PT63vwjgOFfwIbwJt1Leinx6mJIEslsbpjEIucO6AIk0lTddISnavEY1QNkZrSId91 Vz5mk1x2gAzRGdyOtfe/boP2FOW1SooAxRYa9HlxqydHomosSgYCe/8mYV/ZEtJDn3Lo wiFz4RoGBTjPgLf23QVdYdowo93CW31wnOxtfg7oXN5wAXKslMp6Zy6a6d0VpmcSEjLC St6R9RwTLRz4egxZQjzlwX3t4deUW6eEJeD1sulIBKHf7PRKLO8jjexL5ElVxQqNlOeg jjdQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=nhqlVm7aCc6hZi9ht6mRG/1z8J7nWvS2YXexo9kunvE=; b=bXJZvQGhHLMdpQr2/IZVGql3XEl9mNC+K4zc5tD6zLcXpciM1kebv2pNPNIXpAMhU8 Qrsycj+6iW1t/zKHML5BcYiVvBdpuRjgnqyj9Oy7zbCfF7GqJLsD2Pu5nEh5/LBSOdJ9 MFjcgYcCdamTRoDQM/GxslIjaEYJS+T1y4bJtg4mzCZ7Wkagqo5MECRUqYuk0lYbJEap DRzGZePRO8T0Nl1T7AZZ/E//IxuFr5aZxH3v2TF7bjy968eQaodJpp6vLOYq2BeHVPib 2QfqxZ5V1x+Qmf02kDiP3eOEi1RS9fNbOA7eROUttg1FNX82ObB6wQDnLwkPx028UdTw 6nwQ==
X-Gm-Message-State: AA6/9RmKoPE4fE/0CZ7RrKCZLLMHp9/owe6a11v1uAYpvi3FTYZ10YV5wEjVlh5XEpwL2A==
X-Received: by 10.55.49.203 with SMTP id x194mr2780239qkx.94.1476300516190; Wed, 12 Oct 2016 12:28:36 -0700 (PDT)
Received: from ?IPv6:2601:a40:100:d3:34fe:c9ba:a1aa:6ddf? ([2601:a40:100:d3:34fe:c9ba:a1aa:6ddf]) by smtp.gmail.com with ESMTPSA id u4sm3291770qka.9.2016.10.12.12.28.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Oct 2016 12:28:35 -0700 (PDT)
From: Chris Wendt <chris-ietf@chriswendt.net>
Message-Id: <A74609A6-60F5-4CA3-93E6-C5A1A743AB11@chriswendt.net>
Content-Type: multipart/alternative; boundary="Apple-Mail=_42182400-55CF-4E5D-8CF6-0DF9ABEEE329"
Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\))
Date: Wed, 12 Oct 2016 15:28:35 -0400
In-Reply-To: <D190150F-645A-4E6D-BFAD-8CEAEA20A708@gmail.com>
To: Alan Ford <alan.ford@gmail.com>
References: <CACG=0wRwRvYm8aBjwZMWtULvHmnhJXkJc8SeV5b=2pi0FpdYYg@mail.gmail.com> <D190150F-645A-4E6D-BFAD-8CEAEA20A708@gmail.com>
X-Mailer: Apple Mail (2.3226)
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/5A03ELRHcYIkbzR-3TwDBksclqE>
Cc: stir@ietf.org
Subject: Re: [stir] Nits in draft-ietf-stir-passport-08
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2016 19:28:46 -0000

Thanks Alan,

Yes that is more appropriate, I will incorporate that change in wording.  


> On Oct 11, 2016, at 7:09 AM, Alan Ford <alan.ford@gmail.com> wrote:
> 
> Agree on the 4.2.1 feedback, and indeed there's some small rewording which could be done in Section 4.2.1 to make this easier to understand (IMHO anyway):
> 
>    The "dest" JSON object MUST have at least have one key value pair,
>    but could have multiple identity types (i.e. "tn" and/or "uri") but
>    only one of each.  If both "tn" and "uri" are included, the JSON
>    object should list the "tn" array first and the "uri" array second.
>    Within the "tn" and "uri" arrays, the identity strings should be put
>    in lexicographical order including the scheme-specific portion of the
>    URI characters.  Additionally, in the case of "dest" only, the
>    identity type key value MUST be an array signaled by standard JSON
>    brackets, even when there is a single identity value in the identity
>    type key value.
> 
> The requirement to be an array should be introduced earlier, since it’s mentioned in passing half way through and only confirmed at the end. Instead I’d propose putting a second sentence in, something like this, and then losing the last sentence:
> 
>    The "dest" JSON object MUST have at least have one key value pair,
>    but could have multiple identity types (i.e. "tn" and/or "uri") but
>    only one of each.  Each value in the key value pair is an array, 
>    containing one or more identity strings of this identity type. If both "tn” 
>    and "uri" are included, the JSON object should list the "tn" array first 
>    and the "uri" array second. Within the "tn" and "uri" arrays, the 
>    identity strings should be put in lexicographical order, including the 
>    scheme-specific portion of the URI characters.  
> 
> Other than that this, I have re-read this document again and it reads well and I believe it to be ready for publication.
> 
> Regards,
> Alan
> 
>> On 3 Oct 2016, at 00:25, Anders Kristensen <andersk@google.com <mailto:andersk@google.com>> wrote:
>> 
>> 
>> * 4.2.1: s/only have one/have exactly one/ ?
>> 
>> The "orig" JSON object MUST only have one key value pair
>> 
>> * 4.2.1.4 <http://4.2.1.4/>: Why is "Single Originator", "Single Destination" etc. capitalized?
>> 
>> * 5: "above" is actually below (also in Section 8).
>> 
>>    For the JWS Payload and the JWS Protected Header,
>>    the lexicographic ordering and white space rules described above, and
>>    JSON serialization rules in Section 8 <https://tools.ietf.org/html/draft-ietf-stir-passport-08#section-8> of this document MUST be
>>    followed.
>> 
>> * 8.1: Delete leading whitespace:
>> 
>>    {"dest":{"uri":["sip:alice@example.com <mailto:sip%3Aalice@example.com>"],"iat":1443208345,"mky":
>>      [{"alg":"sha-256","dig":"021ACC5427ABEB9C533F3E4B652E7D463F5442CD5
>>      4F17A03A27DF9B07F4619B2"},{"alg":"sha-256","dig":"4AADB9B13F82183B5
>>      40212DF3E5D496B19E57CAB3E4B652E7D463F5442CD54F1"}],
>>      "orig":{"tn":"12155551212"}}
>> 
>> * 9.1: s/the the/the/
>> 
>> * 9.2: Looks like this paragraph was meant to be rendered as a bulleted list.
>> 
>> * 9.2: s/the end user the asserted identity represents/the end user represented by the asserted identity/
>> 
>> * 12.1: I think technically speaking this doc does not depend on 4474bis so could make that ref informational.
>> 
>> * App A: Remove leading whitespace:
>> 
>>    {"alg":"ES256","typ":"passport","x5u":"https://cert.example.org <https://cert.example.org/>
>>        /passport.cer"}
>> _______________________________________________
>> stir mailing list
>> stir@ietf.org <mailto:stir@ietf.org>
>> https://www.ietf.org/mailman/listinfo/stir
> 
> _______________________________________________
> stir mailing list
> stir@ietf.org
> https://www.ietf.org/mailman/listinfo/stir