Re: [stir] Nits in draft-ietf-stir-passport-08

Chris Wendt <chris-ietf@chriswendt.net> Tue, 04 October 2016 01:53 UTC

Return-Path: <chris-ietf@chriswendt.net>
X-Original-To: stir@ietfa.amsl.com
Delivered-To: stir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7AC1B1293F2 for <stir@ietfa.amsl.com>; Mon, 3 Oct 2016 18:53:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.598
X-Spam-Level:
X-Spam-Status: No, score=-2.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=chriswendt-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nErLzYMvBt1m for <stir@ietfa.amsl.com>; Mon, 3 Oct 2016 18:53:18 -0700 (PDT)
Received: from mail-qk0-x234.google.com (mail-qk0-x234.google.com [IPv6:2607:f8b0:400d:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B642E127078 for <stir@ietf.org>; Mon, 3 Oct 2016 18:53:18 -0700 (PDT)
Received: by mail-qk0-x234.google.com with SMTP id j129so172316528qkd.1 for <stir@ietf.org>; Mon, 03 Oct 2016 18:53:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chriswendt-net.20150623.gappssmtp.com; s=20150623; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=CewOnoiXARsSC8Ks1C+LeKc+6Co57z5JoxOnn3JRQyU=; b=Lhw3zZ3uhiXs6lEmONK3AkelrtB1tYr8H+XZpq+lnpMKm9ONJ2pQENHbneMFTvgzgU biqEa9YCw7oZLPjx2kt6rVJH8E++0dggyzt/1FDgaDp6VPnqvD/1e6Q+TNGaf0/6wYkC OEebYvQXS0c+NlKnHwI0LugbtUxgIejcX+DkcYkJd8njqRxrwR0rq5+Jf9kbJ4ES6PVz kX/d+1muPXbAosEEt/mCxdC2vcHzRLY5M0Zh0SKvg1vjxMduD48wQAZn0PK8oBmdMtxx R4cpUrlY8I7KbZ51QhVrUFtMVnHoHG7ujeu1ORt1eUL/aW5GjzhtiB+7VRMTdsi+Gv3z gvMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=CewOnoiXARsSC8Ks1C+LeKc+6Co57z5JoxOnn3JRQyU=; b=UB0VcaGl6y/fxuB3FXLTOcq7LwoOgvY1n9JxCtlZ52t6L2tNGyKPWRIXe4CBsT8HyV U3KFzFx+TeluC9DxxSE6VDttFIjsHbNRXPX+rJeFLpA3/SwZ/MsqTXB5xvzCBj0H+WdQ YN/xyNihTwP7u1o1KB9VO0VU9r99rw03DlMsJMgk5uKmmTkVnBACkw1S7PRPB0z63wsC QIVLPCM02l2aWmJ1J5tfG+eCEcKFqi+9RTsoHKnk5ybFn0fnJ6LdBIA64dKr9Uzo9P2s Lgqkq6R+BwIfIvuFJEtx308GNAznFab9YE+es7JX1OpXYMeBB/XusGK5QgsjhsX67AUG VPpw==
X-Gm-Message-State: AA6/9RnXGSEBMc9+4/vMVG2hg2Yh46K2cAhAV/U+9rZnDcQ0lLAPuS9PKvCXqCNr9Tq5KA==
X-Received: by 10.55.123.133 with SMTP id w127mr1137605qkc.271.1475545997907; Mon, 03 Oct 2016 18:53:17 -0700 (PDT)
Received: from ?IPv6:2601:41:c101:9364:140b:46ac:4114:f2ec? ([2601:41:c101:9364:140b:46ac:4114:f2ec]) by smtp.gmail.com with ESMTPSA id 2sm567226qki.28.2016.10.03.18.53.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 18:53:17 -0700 (PDT)
From: Chris Wendt <chris-ietf@chriswendt.net>
Message-Id: <E16B61B4-CF27-4EE4-9B37-E96674B2B794@chriswendt.net>
Content-Type: multipart/alternative; boundary="Apple-Mail=_6C32B5B7-59CA-43A5-A035-F658D2BF402C"
Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\))
Date: Mon, 03 Oct 2016 21:53:16 -0400
In-Reply-To: <CACG=0wRwRvYm8aBjwZMWtULvHmnhJXkJc8SeV5b=2pi0FpdYYg@mail.gmail.com>
To: Anders Kristensen <andersk@google.com>
References: <CACG=0wRwRvYm8aBjwZMWtULvHmnhJXkJc8SeV5b=2pi0FpdYYg@mail.gmail.com>
X-Mailer: Apple Mail (2.3226)
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/DLZ-KiXNOzjemnUGwVOjnQjmG0I>
Cc: stir@ietf.org
Subject: Re: [stir] Nits in draft-ietf-stir-passport-08
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2016 01:53:20 -0000

Thanks Anders for your comments, will incorporate them in next version.

> On Oct 2, 2016, at 7:25 PM, Anders Kristensen <andersk@google.com> wrote:
> 
> 
> * 4.2.1: s/only have one/have exactly one/ ?
> 
> The "orig" JSON object MUST only have one key value pair
> 
> * 4.2.1.4 <http://4.2.1.4/>: Why is "Single Originator", "Single Destination" etc. capitalized?
> 
> * 5: "above" is actually below (also in Section 8).
> 
>    For the JWS Payload and the JWS Protected Header,
>    the lexicographic ordering and white space rules described above, and
>    JSON serialization rules in Section 8 <https://tools.ietf.org/html/draft-ietf-stir-passport-08#section-8> of this document MUST be
>    followed.
> 
> * 8.1: Delete leading whitespace:
> 
>    {"dest":{"uri":["sip:alice@example.com <mailto:sip%3Aalice@example.com>"],"iat":1443208345,"mky":
>      [{"alg":"sha-256","dig":"021ACC5427ABEB9C533F3E4B652E7D463F5442CD5
>      4F17A03A27DF9B07F4619B2"},{"alg":"sha-256","dig":"4AADB9B13F82183B5
>      40212DF3E5D496B19E57CAB3E4B652E7D463F5442CD54F1"}],
>      "orig":{"tn":"12155551212"}}
> 
> * 9.1: s/the the/the/
> 
> * 9.2: Looks like this paragraph was meant to be rendered as a bulleted list.
> 
> * 9.2: s/the end user the asserted identity represents/the end user represented by the asserted identity/
> 
> * 12.1: I think technically speaking this doc does not depend on 4474bis so could make that ref informational.
> 
> * App A: Remove leading whitespace:
> 
>    {"alg":"ES256","typ":"passport","x5u":"https://cert.example.org <https://cert.example.org/>
>        /passport.cer"}
> _______________________________________________
> stir mailing list
> stir@ietf.org
> https://www.ietf.org/mailman/listinfo/stir