Re: [stir] Second WGLC: draft-ietf-stir-passport-rcd-10

Russ Housley <housley@vigilsec.com> Tue, 16 March 2021 16:43 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: stir@ietfa.amsl.com
Delivered-To: stir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EBA403A138D for <stir@ietfa.amsl.com>; Tue, 16 Mar 2021 09:43:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8th17Tea1TD5 for <stir@ietfa.amsl.com>; Tue, 16 Mar 2021 09:43:01 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0DD4F3A138A for <stir@ietf.org>; Tue, 16 Mar 2021 09:43:01 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id B5D30300B43 for <stir@ietf.org>; Tue, 16 Mar 2021 12:42:58 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NMIvaSC3iPmc for <stir@ietf.org>; Tue, 16 Mar 2021 12:42:57 -0400 (EDT)
Received: from [192.168.1.161] (pool-141-156-161-153.washdc.fios.verizon.net [141.156.161.153]) by mail.smeinc.net (Postfix) with ESMTPSA id 241AE300AA6 for <stir@ietf.org>; Tue, 16 Mar 2021 12:42:57 -0400 (EDT)
From: Russ Housley <housley@vigilsec.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
Date: Tue, 16 Mar 2021 12:42:57 -0400
References: <5393b70d-bfc7-c8ac-eb8d-30c8087a1e89@nostrum.com> <A8AE8905-8083-40BB-A903-92B5BB409861@vigilsec.com> <DAA9009D-815F-4C87-9614-E02261B8E75F@chriswendt.net> <977e68f2-a2fd-27d8-37cc-8bd232caccf7@nostrum.com> <2CBA8444-013D-4A34-A0F4-00BD41A2C033@vigilsec.com>
To: IETF STIR Mail List <stir@ietf.org>
In-Reply-To: <2CBA8444-013D-4A34-A0F4-00BD41A2C033@vigilsec.com>
Message-Id: <5DEB6C9F-A532-4D1D-9489-771C9C4F8247@vigilsec.com>
X-Mailer: Apple Mail (2.3445.104.17)
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/G5EtrimtUjiPfkYL21YN3w3W-NE>
Subject: Re: [stir] Second WGLC: draft-ietf-stir-passport-rcd-10
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Mar 2021 16:43:03 -0000

I have reviewed the document.  It is in good shape, but I have a few comments.


TECHNICAL:

What happens if the JWTClaimConstraints in the certificate explicitly excludes the "rcdi" claim?


EDITORIAL:

Section 4, 2nd para, says: "... defined to accomplish that ...".  Given the many things discussed in the previous paragraph, please replace "that" with a few words to add clarity.

Section 5.1.2, end of 1st para, says: 'The "jcd" and "jcl" keys should be mutually exclusive.'  Please use a MUST or MUST NOT statement here.

Section 5.1.3, end of 1st para, says: 'The "jcd" and "jcl" keys MUST be used mutually exclusively.'  I suggest: 'The "jcd" and "jcl" claim keys are mutually exclusive; the "jcd" and "jcl" claim keys MUST NOT both be present in the same PASSport.'


NITS:

Section 3:
   s/set of info/information/
   s/extensions to that data./extensions./
   s/on a more frequent, per call, type of basis/with each call/

Section 4:
   s/sufficiently strong cryptographic digest/message digest/

Section 5.2:
   s/crypto algorithm/cryptographic one-way hash function/
   s/by the NIST/by the NIST [FIPS180-4]/


Russ