[stir] Nits in draft-ietf-stir-rfc4474bis-13

Anders Kristensen <andersk@google.com> Sun, 02 October 2016 23:25 UTC

Return-Path: <andersk@google.com>
X-Original-To: stir@ietfa.amsl.com
Delivered-To: stir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1D319127A91 for <stir@ietfa.amsl.com>; Sun, 2 Oct 2016 16:25:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.696
X-Spam-Level:
X-Spam-Status: No, score=-5.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-2.996, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nKSQORSKJ5JY for <stir@ietfa.amsl.com>; Sun, 2 Oct 2016 16:25:47 -0700 (PDT)
Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D7C512B10E for <stir@ietf.org>; Sun, 2 Oct 2016 16:25:45 -0700 (PDT)
Received: by mail-wm0-x22b.google.com with SMTP id p138so120732149wmb.1 for <stir@ietf.org>; Sun, 02 Oct 2016 16:25:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=Q9mwokFI9EQZzlhPR3FBJ2QcpTblqxuj5gqhcAffToA=; b=AlI87unUd8XiKkwgd24bfyXlFeiIpt32hVtbC/RYNcrBo60menp8IVL+aaqe4Ktp6W yDMGLN+qKb4q67I1FWx8MOVdYzk2hHWHCBI8Zog/WUqovK7aSTAmDE75zF13nLL02FWG AsmNL2WD8pHz98vw1y2Ht8nIn7LuIJ2XKFwwxOXl4ANSEcEhAZlzi0C4WG8+XTGEe6Ls 0uB2WKp940qE/4WmbsumP13uB+Yu120ftXfqf2WnzZp7YKA4Ogv5Z6ZVBKUG8MvGLr8I cUNQM9TpgIDCETIPufwd2bF4S0WL8sVquqjGqqIu/mLyTtzFYU1nfCNHRc1BSz+O5rnN Hr5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Q9mwokFI9EQZzlhPR3FBJ2QcpTblqxuj5gqhcAffToA=; b=f9XCkskRV1/WBjVE7WucyiP5BG4xUBG1LtWEXyKxu4re7fuBifG4VKjNEZ2NdSQw1F 8z+VKe3/8UX4xFEfVrPYXEp53pTv8nbIGORETT420u0z/aI3Bbfk7i1bYQRXl+wyQTdg +1dYBrQ/bdJpbL0qXm6soc0lTmiTkkO8wP7OKCwB7aERGn62kME81pH9HzZ1FVJnJsHe ITaUT3zo2vKm4C3ThGSBodJld15lVNZKN+uZqSYAurv77ZPV+xv0sWIEy2rGs67Q/biP H9d15cMiP2E91hscZ15fjpgvALFuUFlN5vbmbI5iooAJjdkDKCz5XV1WHlcQLNfF9zJe jT9A==
X-Gm-Message-State: AA6/9RkFFAFghcszlzBIYSG2CUL6RS0Kl++nLXvHlw7dC0CFwiAF3NsN/l3PPS2AtTxyafGcCJf1Pt0ec6JzQUPn
X-Received: by 10.28.60.2 with SMTP id j2mr7864042wma.46.1475450743192; Sun, 02 Oct 2016 16:25:43 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.28.109.67 with HTTP; Sun, 2 Oct 2016 16:25:42 -0700 (PDT)
From: Anders Kristensen <andersk@google.com>
Date: Sun, 02 Oct 2016 16:25:42 -0700
Message-ID: <CACG=0wQeMqX4bvBCk5g_afCKnR43bVss=TUC9tgns5Ba1RYJqw@mail.gmail.com>
To: stir@ietf.org
Content-Type: multipart/alternative; boundary="001a114a48886ee1ee053dea251a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/UIVvxELkOkhEr4RQwoQdCL2nhN0>
Subject: [stir] Nits in draft-ietf-stir-rfc4474bis-13
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Oct 2016 23:25:48 -0000

* 4.1: orig is not an array.

      First, the JSON "orig" array MUST be populated.

...

      Otherwise, the array MUST be populated with a "uri"


* I think the intention is to leave it up to local policy whether source
identity is based on From or PAI but the text in 4.1 says that if the
source is not a number it's based on From.

* Probably the destination identity should always be based on To but this
is only explicitly stated for the non-number case.

* Further down in 4.1:

   { "orig":{"tn":"12155551212"},
     "dest":{"tn":"12155551213"},
     "iat":"1443208345" }


Here the dest value should be an array.

* Again orig is not an array:

   The "orig" and "dest" arrays may contain identifiers of heterogeneous
   type; for example, the "orig" array might contain a "tn" claim


* 5.1: R-URI and To in the example should be sip:alice@example.org
Contact should be <number>@gateway...?