[stir] Nits in draft-ietf-stir-passport-08

Anders Kristensen <andersk@google.com> Sun, 02 October 2016 23:25 UTC

Return-Path: <andersk@google.com>
X-Original-To: stir@ietfa.amsl.com
Delivered-To: stir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4271B12B10E for <stir@ietfa.amsl.com>; Sun, 2 Oct 2016 16:25:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.695
X-Spam-Level:
X-Spam-Status: No, score=-5.695 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, NORMAL_HTTP_TO_IP=0.001, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-2.996, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cczuwzxGjI1d for <stir@ietfa.amsl.com>; Sun, 2 Oct 2016 16:25:52 -0700 (PDT)
Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B21F212B10D for <stir@ietf.org>; Sun, 2 Oct 2016 16:25:51 -0700 (PDT)
Received: by mail-wm0-x22e.google.com with SMTP id p138so120734314wmb.1 for <stir@ietf.org>; Sun, 02 Oct 2016 16:25:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=O/ryUXBQK1M7RRZMFeizvha/NUVl9NN17E8cXYRbMsQ=; b=nKezBZX/UJgMQ6fMec8+wgSetaoKURjer//j7gteAJip6cjUWhk9DKo7JhfgfY+r7q 1kiXs6DfYJlHfTigqVxg07oa7LdreVfesu99ARp9Et3BomX0MPVE/lRLwtSy3Gemi3uu vRzyIzL21ILeKfYot2ahOa5Kn/raOQeinXbOrEdxGipM+vzgjcYVV0GDiQaQdKBETUye RuVME9IE36I1qFZ/Iwv0DKsyYEWYP7AeOur6c5YVGGeKJ21w+xGncbR+e9IalfB+XEhi 5JhuiA1O7NxSNV1JuMSNAL1d6kBbXjw6Bpj39MTYk3YOxIKDuwZHqvjgTkHC353sN3mE cj2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=O/ryUXBQK1M7RRZMFeizvha/NUVl9NN17E8cXYRbMsQ=; b=bQBX8SkLQv7jCQBhbFy8YUfRAnuew56B20wihmcjic/IG0McitUuv7cfG1HxAROC+e 0o14Ob3PzLT+g8V1RHEaGqDhgLHfsJMownfBUpAUt+3mWBvznQw7oWozLTxhwjbO20dL J5NPseNgEmz3u8YsGd3dC56yB40/aWBKlqm9d6KQy+elT3wN48urXcnzQnOdRtfCPoxH GFg9jIqrOF5r4sbSxPY61C2S2868LUptxAbKPfmoqJ8i6irf4rvZK3TxC7oY9NseMlIk yJuY4pEG5ozrM2sREX17yF3a2LTuOYPYFjcb/lRqY7xHwZ+b3rfxvQDfW46Ls+WGFAW1 LeuQ==
X-Gm-Message-State: AA6/9RklxYMAZ76wiRJ+SpYjZx0eGm2eQPXljJXMQ9KOFA5dsUrex4lfqig1VP+geaXEBkEw8bdOG01dzBHfZUZ7
X-Received: by 10.28.15.202 with SMTP id 193mr6457570wmp.98.1475450749843; Sun, 02 Oct 2016 16:25:49 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.28.109.67 with HTTP; Sun, 2 Oct 2016 16:25:49 -0700 (PDT)
From: Anders Kristensen <andersk@google.com>
Date: Sun, 02 Oct 2016 16:25:49 -0700
Message-ID: <CACG=0wRwRvYm8aBjwZMWtULvHmnhJXkJc8SeV5b=2pi0FpdYYg@mail.gmail.com>
To: stir@ietf.org
Content-Type: multipart/alternative; boundary="001a1145ac32d483c5053dea2574"
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/avlz9ecgqYhi4iSIzUbIRp82nz8>
Subject: [stir] Nits in draft-ietf-stir-passport-08
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Oct 2016 23:25:53 -0000

* 4.2.1: s/only have one/have exactly one/ ?

The "orig" JSON object MUST only have one key value pair


* 4.2.1.4: Why is "Single Originator", "Single Destination" etc.
capitalized?

* 5: "above" is actually below (also in Section 8).


   For the JWS Payload and the JWS Protected Header,
   the lexicographic ordering and white space rules described above, and
   JSON serialization rules in Section 8
<https://tools.ietf.org/html/draft-ietf-stir-passport-08#section-8> of
this document MUST be
   followed.


* 8.1: Delete leading whitespace:

   {"dest":{"uri":["sip:alice@example.com"],"iat":1443208345,"mky":
     [{"alg":"sha-256","dig":"021ACC5427ABEB9C533F3E4B652E7D463F5442CD5
     4F17A03A27DF9B07F4619B2"},{"alg":"sha-256","dig":"4AADB9B13F82183B5
     40212DF3E5D496B19E57CAB3E4B652E7D463F5442CD54F1"}],
     "orig":{"tn":"12155551212"}}


* 9.1: s/the the/the/

* 9.2: Looks like this paragraph was meant to be rendered as a bulleted
list.

* 9.2: s/the end user the asserted identity represents/the end user
represented by the asserted identity/

* 12.1: I think technically speaking this doc does not depend on 4474bis so
could make that ref informational.

* App A: Remove leading whitespace:

   {"alg":"ES256","typ":"passport","x5u":"https://cert.example.org
       /passport.cer"}