Re: [stir] Genart last call review of draft-ietf-stir-cert-delegation-03

"Peterson, Jon" <jon.peterson@team.neustar> Mon, 22 February 2021 23:42 UTC

From: "Peterson, Jon" <jon.peterson@team.neustar>
To: Ines Robles <mariainesrobles@googlemail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "stir@ietf.org" <stir@ietf.org>, "draft-ietf-stir-cert-delegation.all@ietf.org" <draft-ietf-stir-cert-delegation.all@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-stir-cert-delegation-03
Thread-Index: AQHWe/AYs1BD5DQUiU25zQr9ryx5O6nw7i8A
Date: Mon, 22 Feb 2021 23:41:23 +0000
Message-ID: <B2AF5132-9568-495D-954A-3836F28FAEA4@team.neustar>
References: <159847741398.23291.8299604699001624244@ietfa.amsl.com>
In-Reply-To: <159847741398.23291.8299604699001624244@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/10.10.1b.201012
Content-Type: text/plain; charset="utf-8"
Content-ID: <9563C25CE2305B4084AF419ED282F2EB@namprd17.prod.outlook.com>
X-MS-Exchange-CrossTenant-Network-Message-Id: ebd69711-9526-48d4-3703-08d8d78b5d7b
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2021 23:41:24.0308 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 73a2bbc1-f307-47c4-8f94-5f379c68bc30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: y8Clf9ovdU9bBIVkcZ81UFINEPLhyNmeT6/0okNMSmaYoM8zViaMS/4pvsKRfK8EohhVdMt+dPAESALRDPr0RDx40AN+PARztAcjbeyFiwc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR17MB3222
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-02-22_08:2021-02-22, 2021-02-22 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=864 bulkscore=0 priorityscore=1501 clxscore=1011 malwarescore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 impostorscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=2 engine=8.12.0-2009150000 definitions=main-2102220203
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/d0RF-QHezKCJcbnKKTeNYnbuyhU>
Subject: Re: [stir] Genart last call review of draft-ietf-stir-cert-delegation-03
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Feb 2021 23:42:06 -0000

Hi Ines,

Thanks for the read on this one (and sorry for the lengthy RTT). A few responses.
    
    Minor issues:
    
    1-Introduction Section:
    
    "..., including various forms of robocalling, voicemail hacking, and
    swatting..." --> should a reference to RFC7375 be added here?

Sure, I added that.
    
    2- It would be nice to add in Terminology section:
    
    -  delegation: the concept of delegation and its levels are defined in RFC8226.
    - definition for "legitimate spoofing". I understand that the draft explain it
    with an example.

Okay, done.
    
    3- It would be nice to add references to concepts, e.g. cA boolean --> cA
    boolean [rfc5280#section-4.2.1.9]

Happy to add an RFC5280 ref there, though there's one in the next sentence as well. 
    
    "x5u" link -> "x5u" (X.509 URL) [RFC7515#section-4.1.5] link

Above, the document already clarified that it is the '"x5u" field of a PASSporT", so I think this is okay,
    
    4- Section 4: It would be nice to add graphics explaining the process.
    E.g. can be used as a model the images displayed in
    https://urldefense.com/v3/__https://access.atis.org/apps/group_public/download.php/47134/IPNNI-2019-00043R000.pdf__;!!N14HnBHF!ruZOc0NFQcees5TRawLc_mZjF0IeX-yIKalJpT_41IU-uAKmu9vZCwNJ9V8$  
    or https://urldefense.com/v3/__https://niccstandards.org.uk/wp-content/uploads/2019/03/ND1522V1.1.1.pdf__;!!N14HnBHF!ruZOc0NFQcees5TRawLc_mZjF0IeX-yIKalJpT_41IU-uAKmu9vZMzXwShk$  
    
Not sure about adding new pictures at this point; or at least, I think the basic idea should be clear from the text by itself.

    5- Section 5:"Authentication service behavior for delegate certificates is
    little
       changed from [RFC8224] STIR behavior" --> It is not clear to me what are the
       little changes.
    
    Additionally, how you quantify little/big changes?, maybe something like?:
    "Authentication service behavior varies from STIR behavior [RFC8224] as
    follows:...."

Okay, I can do that.
    
    6- Section 8.1: Should the picture displayed in
    https://urldefense.com/v3/__https://www.ietf.org/proceedings/104/slides/slides-104-stir-certificate-delegation-00--Slide__;!!N14HnBHF!ruZOc0NFQcees5TRawLc_mZjF0IeX-yIKalJpT_41IU-uAKmu9vZ_sKwt4g$  
    5 be added here?
    
Really would rather not do new pictures at this point.

    7- Security Consideration section: should a reference to RFC7375 be added here?

Added.
    
    Nits/editorial comments:
    
    8- Expand the first time: JWS -> JSON Web Signature (JWS)

Done. Thanks!

Jon Peterson
Neustar, Inc.
    
    Thank you for this document,
    
    Ines.

[stir] Genart last call review of draft-ietf-stir… Ines Robles via Datatracker
Re: [stir] [Gen-art] Genart last call review of d… Alissa Cooper
Re: [stir] Genart last call review of draft-ietf-… Peterson, Jon
Re: [stir] Genart last call review of draft-ietf-… Ines Robles