Re: [stir] WG Last Call for draft-ietf-stir-rph-emergency-services-02

Sean Turner <sean@sn3rd.com> Thu, 06 August 2020 05:37 UTC

Return-Path: <sean@sn3rd.com>
X-Original-To: stir@ietfa.amsl.com
Delivered-To: stir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B85293A0EBB for <stir@ietfa.amsl.com>; Wed, 5 Aug 2020 22:37:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=sn3rd.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D5P2BzBrw56y for <stir@ietfa.amsl.com>; Wed, 5 Aug 2020 22:37:40 -0700 (PDT)
Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40D583A0E08 for <stir@ietf.org>; Wed, 5 Aug 2020 22:37:35 -0700 (PDT)
Received: by mail-qt1-x82d.google.com with SMTP id t23so32402419qto.3 for <stir@ietf.org>; Wed, 05 Aug 2020 22:37:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sn3rd.com; s=google; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=d0S1gufHEIKZ+Aw/KCUuGPESkjChg2BSTKnT44znm8A=; b=VEAALFOf4MBj0lRaBSWO8Mr+HzTTCX7Sdthw+1jjxdGf3jwMj6MjCwge5ffktmsVFN Mre0uoZEZED+NfTUHhHO0KoM11oWaBHTS6j86ROjXU52+wvz6p5zLGgiTDdXpS9CkVbD SirX3pvuoz7HB+Um4i9/8r9JfUb6SyfVtKDxs=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=d0S1gufHEIKZ+Aw/KCUuGPESkjChg2BSTKnT44znm8A=; b=U560ORnW+7aSNIejYDwQtEdSSEaavkZYSh1V8dl0zhz+KkaytrQRXklorr6pxWxvpj toUmz3C7dMYRdUg7KSdZmC3iYAbxRUs27YfyVihepRemKy6N6ar2xROJgqjlsN5c478A OVLVc4La2Wt4Zgeblx+1v0EG8qDZW+nKBpmCrXoF8WA1EESjaGQjF8gBSdI4XVyaXTsT BJwlUlgkJ352XO4/JueUJOr1SRSHT+3Seft43LMZzR+govWxIWb4vgbRZGqCqs9zEFLq T0l0aD9/CVuyBkNmQmOXj36JnBchr55Xy40quIIbp3j7I+nSqbYfZpgQCfU//Ce7k/Be /btQ==
X-Gm-Message-State: AOAM532fDDJdpbRXUcrCZVp8iCHik3TZmMuRdej0Ztn766P2rzL9LFpL 36zPsv2vpDrUX68z3shcavvitq/W6/k=
X-Google-Smtp-Source: ABdhPJwwwmll1J/awdxw7Mb/KNzhi2MKvlGluTJLu7Yu78f6ZVINJbQz7ElC+iZDLsNbNH+qouXduQ==
X-Received: by 2002:ac8:22ea:: with SMTP id g39mr7231973qta.146.1596692253513; Wed, 05 Aug 2020 22:37:33 -0700 (PDT)
Received: from [192.168.1.152] (pool-108-31-39-252.washdc.fios.verizon.net. [108.31.39.252]) by smtp.gmail.com with ESMTPSA id l45sm2685286qtf.11.2020.08.05.22.37.32 for <stir@ietf.org> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Aug 2020 22:37:32 -0700 (PDT)
From: Sean Turner <sean@sn3rd.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
Date: Thu, 6 Aug 2020 01:37:31 -0400
References: <8372C576-08B7-41C4-B021-38622BABAD25@vigilsec.com> <919FC584-18AF-4419-B174-B9FB37B6439D@vigilsec.com>
To: IETF STIR Mail List <stir@ietf.org>
In-Reply-To: <919FC584-18AF-4419-B174-B9FB37B6439D@vigilsec.com>
Message-Id: <1CFC4EFA-1B05-4278-95EB-B9099328F1E7@sn3rd.com>
X-Mailer: Apple Mail (2.3608.120.23.2.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/kJIr13SrTp1lb5ePUah_pxcxWzM>
Subject: Re: [stir] WG Last Call for draft-ietf-stir-rph-emergency-services-02
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Aug 2020 05:37:49 -0000

Hi!

Support moving this one along, and I think these are all minor.

0) I thought the security considerations was missing something about compromise leading to misuse of network resources, but it’s the 2nd paragraph of s1. That shows you which section I read first ;) Might be worth repeating that s1 blurb in s8 or at least referring to it from s8? Maybe:

  The security consideration enumerated in
  Section 1 and the security considerations discussed
  in [RFC8224], Section 12, are applicable.

1) I hit the nits button (also out of habit) there are a lot unused references and they can be deleted:

== Unused Reference: 'RFC3261' is defined on line 275, but no explicit
   reference was found in the text

== Unused Reference: 'RFC8226' is defined on line 305, but no explicit
   reference was found in the text

== Unused Reference: 'RFC7340' is defined on line 322, but no explicit
   reference was found in the text

== Unused Reference: 'RFC7375' is defined on line 327, but no explicit
   reference was found in the text

== Unused Reference: 'RFC8126' is defined on line 331, but no explicit
   reference was found in the text

2) Do the examples in s3.1, 3.2, and s4 match the order required in s5? I.e., shouldn’t the examples be as follow to be in lexicographic order:

s3.1:
{
 "dest":{["uri":"urn:service:sos"]},
 "iat":1443208345,
 "orig":{"tn":"12155551212"},
 "rph":{"ESorig":["esnet,x"]}
}

s3.2:
{
 "dest":{["tn":"12155551212"]},
 "iat":1443208345,
 "orig":{"tn":"12155551213"},
 "rph":{"EScallback":["esnet,x"]}
}

s4:
{
 "dest":{["tn":"12155551212"]},
 "iat":1443208345,
 "orig":{"tn":"12155551213"},
 "rph":{"EScallback":["esnet,x"]},
 "sph":"psap-callback"
}

3) In s3.2, there’s a reference to "r-values”. What’s that?

4) Should this “should only” be a SHOULD:

 The value of the "sph" claim key SHOULD be "psap-callback”
 to match the SIP Priority header field value for authorized
 emergency services callbacks.

4) In s5, s/order,/order:

5) In s6, should the compact form for ‘rph’ PASSPORTS be NOT RECOMMENDED, i.e.,

OLD:

  The use of the compact form of PASSporT is not specified in this
  document or recommended for 'rph' PASSporTs.

NEW:

  The use of the compact form of PASSporT is not specified in this
  document and it is NOT RECOMMENDED for 'rph' PASSporTs.

6) 2119 and 8174 should be normative references.

Cheers,

spt

> On Jul 31, 2020, at 11:29, Russ Housley <housley@vigilsec.com> wrote:
> 
> 
> This is the STIR WG Last Call for "Assertion Values for a Resource Priority Header Claim and a SIP Priority Header Claim in Support of Emergency Services Networks” <draft-ietf-stir-rph-emergency-services-02>.  Please review the document and send your comments to the STIR WG mail list by 22 August 2020.
> 
> https://datatracker.ietf.org/doc/draft-ietf-stir-rph-emergency-services/
> 
> Thanks,
> Robert & Russ
> 
> _______________________________________________
> stir mailing list
> stir@ietf.org
> https://www.ietf.org/mailman/listinfo/stir