Re: [stir] WGLC: draft-ietf-stir-cert-delegation-02

Russ Housley <housley@vigilsec.com> Wed, 08 April 2020 16:12 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: stir@ietfa.amsl.com
Delivered-To: stir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6CBDD3A0F79 for <stir@ietfa.amsl.com>; Wed, 8 Apr 2020 09:12:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MhJkYKOL1qhm for <stir@ietfa.amsl.com>; Wed, 8 Apr 2020 09:12:15 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B1D733A0F78 for <stir@ietf.org>; Wed, 8 Apr 2020 09:12:15 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 11E2D300ADC for <stir@ietf.org>; Wed, 8 Apr 2020 12:12:13 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 95AQd4rf8V_e for <stir@ietf.org>; Wed, 8 Apr 2020 12:12:11 -0400 (EDT)
Received: from a860b60074bd.fios-router.home (pool-72-66-113-56.washdc.fios.verizon.net [72.66.113.56]) by mail.smeinc.net (Postfix) with ESMTPSA id 8081B3004C0; Wed, 8 Apr 2020 12:12:11 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <bb76518f-3373-1368-d2d2-0959f7894e2b@nostrum.com>
Date: Wed, 08 Apr 2020 12:12:12 -0400
Cc: IETF STIR Mail List <stir@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5CEC45AE-866E-46FF-84A3-0CB04140BED7@vigilsec.com>
References: <bb76518f-3373-1368-d2d2-0959f7894e2b@nostrum.com>
To: Robert Sparks <rjsparks@nostrum.com>
X-Mailer: Apple Mail (2.3445.104.14)
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/nEuIn4j8kWVrGqmft4vyOvjBh5s>
Subject: Re: [stir] WGLC: draft-ietf-stir-cert-delegation-02
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Apr 2020 16:12:18 -0000

Major Concern:

Section 7 says:

   The ordering MUST conform to the AKID/SKID order chain encoded
   in the certs themselves.

First, this is talking about a certification path in the terms of RFC 5280.

Second, AKID/SKID order is nor defined anywhere to my knowledge.  So, it needed to be defined here.


Minor Concern:

Section 5: s/should be validated/SHOULD be validated/

Section 8: Please add a reference for "CP/CPS".

Section 9 says: 'and a "ca" boolean set to "true"'.  It would be better to say something like: 'the cA boolean set to "true" in the basic constraints certificate extension [RFC5280]'


Nits:

Section 4.1: s/[RFC8226] Section 10.1/Section 10.1 of [RFC8226]/

Section 4.1: s/[RFC8226] TNAuthList/TNAuthList specified in [RFC8226]/

Section 5: s/certificate in turn has its own parent/certificate has a parent/

Section 5: s/entire certificate path/entire certification path/

Section 5: s/entire certificate chain/entire certification path/

Section 6: s/path construction/certification path construction/

Section 6: s/own chains/own certification path/

Section 6: s/certificate chain/certification path/

Section 7: s/certificate chains/certification paths/

Section 7: s/chains are already/certification paths are already/

Section 8: s/certificate chain/certification path/

Section 9 says:

   Specification of a TLS subcerts analog for STIR is
   deferred here to future work, at such a time as market players
   require it.

I suggest:

   Specification of a mechanism similar to TLS subcerts for STIR is
   future work, and it will be undertaken only if market players
   require it.


> On Mar 11, 2020, at 12:11 PM, Robert Sparks <rjsparks@nostrum.com> wrote:
> 
> This is a Working Group Last Call for draft-ietf-stir-cert-delegation-02
> 
> Please send your comments to the list or the chairs by Wed Apr 1. (This LC is three weeks because of the proximity to the IETF 107 week).
> 
> RjS
> 
> _______________________________________________
> stir mailing list
> stir@ietf.org
> https://www.ietf.org/mailman/listinfo/stir