Re: [stir] PASSporT extensions: order of claims

Hi,

>To be clear, and i think this was the point of my last e-mail, I’m not suggesting it doesn’t mean anything.  It certainly is good to be explicit about the order and provide examples and if that’s all you are suggesting, i can’t disagree.
>
>I think at some point in the e-mail thread you were questioning the logic of the MUST for providing details of the order of claims in RFC8225 and that’s what i was trying to address.

My initial comment was that the current PASSporT extensions do not provide details of the order, and that we should fix that :)

Later, I questioned the logic of the MUST when I was told that RFC8225 already defines the order for extensions.

Regards,

Christer

On Mar 14, 2018, at 8:00 AM, Christer Holmberg <christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>> wrote:

Hi,

> Perhaps its a bit over prescriptive, i think the intention was only to say that it should be documented what claims and provide order and examples.
>
> It wasn’t to imply that it would be different or there would be implications of order or anything.
>
> To step up a level, in general, JSON object key order never matters, it’s a key value object that you index on key, so order in most cases is arbitrary.  For PASSporT, we
> have a short form that is supported in RFC8224, where you don’t need to send the header/claims because those objects are already in the SIP INVITE.  So we needed a
> way to have the header/claims to be reconstructed in a predictable and reproducible way.  An therefore the dependency on order.

Correct. I wasn’t questioning the need for ordering, but maybe I wasn’t clear about that :)

> So again, yes we say you should say order in RFC8225, which i would say would inherently be the case with an example at a minimum.  A MUST might have been
> a bit strong, but i don’t see this as a huge concern.  I’d be curious to hear from others whether they think this is a real concern or not.

It depends on what is meant by “concern”. When people define PASSporT extensions future, they will not look at this e-mail thread – they will read RFC8225. We shouldn’t have MUSTs if they don’t mean anything.

Anyway, as far as the current PASSporT extensions are concerned, maybe we could solve the issue by including a statement saying something like:

“The order of the claims within the PASSporT <insert-name-of-PASSporT extension> JSON object does not matter. However, as defined in Section 9 of RFC8225, when the JSON serialisation takes place, the claims must be placed in lexicographic order”

Regards,

Christer

On Mar 13, 2018, at 3:58 PM, Christer Holmberg <christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>> wrote:

Hi,

>Try RFC 8225, Section 9, perhaps?

Ok, so if that’s a generic rule, why the statement saying that PASSporT extensions must specify the order?

Regards,

Christer

From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
Sent: Tuesday, March 13, 2018 2:47 PM
To: Chris Wendt <chris-ietf@chriswendt.net<mailto:chris-ietf@chriswendt.net>>
Cc: stir@ietf.org<mailto:stir@ietf.org>; adam@nostrum.com<mailto:adam@nostrum.com>
Subject: Re: [stir] PASSporT extensions: order of claims

Hi,

>I would agree with the text, the only caveat i would point out is that the extension definition has
>no choice to the order other than alphabetic order, so the order is essentially implied.  So, it’s sort
>of a technicality that maybe we didn’t anticipate, but i think technically you are correct.

Not sure I understand the has-no-choice part. Where is it said that the claims must be ordered in alphabetic order? We could for sure specify it that way, but based on your e-mail it seems like it is already specified somewhere?

Regards,

Christer

On Mar 10, 2018, at 8:27 AM, Christer Holmberg <christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>> wrote:

Section 8.3 of RFC 8225, that is.

From: stir [mailto:stir-bounces@ietf.org] On Behalf Of Christer Holmberg
Sent: 10 March 2018 15:26
To: stir@ietf.org<mailto:stir@ietf.org>
Cc: adam@nostrum.com<mailto:adam@nostrum.com>
Subject: [stir] PASSporT extensions: order of claims

Hi,

Section  says:

   “Specifications that define extensions to the PASSporT mechanism MUST
   explicitly specify what claims they include beyond the base set of
   claims from this document, the order in which they will appear,…”

When looking at the extensions we are currently working on:

draft-ietf-stir-rph-03
draft-ietf-stir-passport-shaken-01
draft-ietf-stir-passport-divert-02

…I don’t see anything about the order in any of the documents.

I think it would be good to have a dedicated “Order of claims” section, or something similar, in each extension specification.

When looking at the examples in the drafts above, it seems like even the base claims are in different orders. Not sure whether there is an explicit requirement that they need to be in order, thought.

Regards,

Christer

_______________________________________________
stir mailing list
stir@ietf.org<mailto:stir@ietf.org>
https://www.ietf.org/mailman/listinfo/stir<https://urldefense.proofpoint.com/v2/url?u=https-3A__www.ietf.org_mailman_listinfo_stir&d=DwMGaQ&c=MOptNlVtIETeDALC_lULrw&r=ww1S9BHEcpE4MMUbgGQrsoL-SK3UCGY33Koaj2h9zYw&m=_DBdmUKpkUAUVv120PuHoMt-TVtTuzOHsfFQdAWmeFs&s=yYY6kvNSlx7W84nXLfYP7n4PSH0S7Uiq3VK2FI6iwEU&e=>