Re: [stir] [EXTERNAL] Re: PASSporT extensions: order of claims

"Politz, Ken" <Kenneth.Politz@team.neustar> Wed, 14 March 2018 13:43 UTC

Return-Path: <prvs=06113740e3=kenneth.politz@team.neustar>
X-Original-To: stir@ietfa.amsl.com
Delivered-To: stir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1CB1912D0C3 for <stir@ietfa.amsl.com>; Wed, 14 Mar 2018 06:43:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.1
X-Spam-Level:
X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=team.neustar
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0_NuEEzcRP8U for <stir@ietfa.amsl.com>; Wed, 14 Mar 2018 06:43:02 -0700 (PDT)
Received: from mx0b-0018ba01.pphosted.com (mx0a-0018ba01.pphosted.com [67.231.149.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7F07112D775 for <stir@ietf.org>; Wed, 14 Mar 2018 06:42:57 -0700 (PDT)
Received: from pps.filterd (m0078664.ppops.net [127.0.0.1]) by mx0a-0018ba01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2EDWtPY004752; Wed, 14 Mar 2018 09:42:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=team.neustar; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=selector1; bh=YXEehS8X1/paOFflZ+vMjOtIm2Z5eYI43QhObaWv2EU=; b=bps22rZiUoCQKdsxv9SPza+oVjGxlx9MIRx9HgGx8MOFVKORA423vtkSUQCtqwgRbdZV 93alxO8Q9YMgiBLklsgXSg8vc8cN59jyiviNm7dg/xVAYVwI0Lz2+bGxsrKvELMsdWdU AdKgaXSpLS7Z8pELFlBmfBealEVhfsU0Hr9zb2VjTKhUgh6kQQ47jMaO9feV8AjFtRCU 1jtWsd+NKT5phlYCuNdE99AvYmpL68MFj+A7/Ck1taiCPujpYM3ZyggpkWUYVPMYUhA4 95DDglLA6gF621MV6N0DAZoJyhVDE8alszKsIoeJUSGN6TmLi8ydLzE7O28MIirQnt8K mQ==
Received: from stntexhc12.cis.neustar.com ([156.154.17.216]) by mx0a-0018ba01.pphosted.com with ESMTP id 2gmaw35v2d-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 14 Mar 2018 09:42:52 -0400
Received: from STNTEXMB13.cis.neustar.com ([169.254.3.141]) by stntexhc12.cis.neustar.com ([::1]) with mapi id 14.03.0279.002; Wed, 14 Mar 2018 09:42:51 -0400
From: "Politz, Ken" <Kenneth.Politz@team.neustar>
To: Chris Wendt <chris-ietf@chriswendt.net>, Christer Holmberg <christer.holmberg@ericsson.com>
CC: "stir@ietf.org" <stir@ietf.org>, "adam@nostrum.com" <adam@nostrum.com>
Thread-Topic: [EXTERNAL] Re: [stir] PASSporT extensions: order of claims
Thread-Index: AQHTuvvKLoGLTt5520aG5ALLxR8fX6POigGAgAERWYiAACL8UA==
Date: Wed, 14 Mar 2018 13:42:51 +0000
Message-ID: <46946849EEFF3043A8FBCC3D102A2C1A3FCAF4E9@stntexmb13.cis.neustar.com>
References: <7594FB04B1934943A5C02806D1A2204B6C1D17C1@ESESSMB109.ericsson.se> <7594FB04B1934943A5C02806D1A2204B6C1D1804@ESESSMB109.ericsson.se> <8B0E0275-68BD-41E9-B128-589F13C06D66@chriswendt.net> <7594FB04B1934943A5C02806D1A2204B6C2007A0@ESESSMB109.ericsson.se> <46946849EEFF3043A8FBCC3D102A2C1A3FCADE50@stntexmb13.cis.neustar.com> <7594FB04B1934943A5C02806D1A2204B6C200A0A@ESESSMB109.ericsson.se> <08B1E835-CA5E-4636-AE0E-983F3EFA82C1@chriswendt.net>
In-Reply-To: <08B1E835-CA5E-4636-AE0E-983F3EFA82C1@chriswendt.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.96.9.94]
Content-Type: multipart/alternative; boundary="_000_46946849EEFF3043A8FBCC3D102A2C1A3FCAF4E9stntexmb13cisne_"
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-03-14_06:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803140155
Archived-At: <https://mailarchive.ietf.org/arch/msg/stir/xeWt5J59Ffl3YPeyKYidkctnnsk>
X-Mailman-Approved-At: Wed, 14 Mar 2018 11:23:11 -0700
Subject: Re: [stir] [EXTERNAL] Re: PASSporT extensions: order of claims
X-BeenThere: stir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Secure Telephone Identity Revisited <stir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stir>, <mailto:stir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/stir/>
List-Post: <mailto:stir@ietf.org>
List-Help: <mailto:stir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stir>, <mailto:stir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Mar 2018 13:43:05 -0000

All I can say is that, with relatively limited SHAKEN industry testing, JSON key order has come up twice.  As new extensions get added and for interoperability purposes, I would request that clarity be provided in related specs with consistent examples for implementers.  Thanks, Ken.

From: Chris Wendt [mailto:chris-ietf@chriswendt.net]
Sent: Wednesday, March 14, 2018 7:36 AM
To: Christer Holmberg <christer.holmberg@ericsson.com>;
Cc: Politz, Ken <Kenneth.Politz@team.neustar>;; stir@ietf.org; adam@nostrum.com
Subject: [EXTERNAL] Re: [stir] PASSporT extensions: order of claims

Perhaps its a bit over prescriptive, i think the intention was only to say that it should be documented what claims and provide order and examples.  It wasn’t to imply that it would be different or there would be implications of order or anything.

To step up a level, in general, JSON object key order never matters, it’s a key value object that you index on key, so order in most cases is arbitrary.  For PASSporT, we have a short form that is supported in RFC8224, where you don’t need to send the header/claims because those objects are already in the SIP INVITE.  So we needed a way to have the header/claims to be reconstructed in a predictable and reproducible way.  An therefore the dependency on order.

So again, yes we say you should say order in RFC8225, which i would say would inherently be the case with an example at a minimum.  A MUST might have been a bit strong, but i don’t see this as a huge concern.  I’d be curious to hear from others whether they think this is a real concern or not.



On Mar 13, 2018, at 3:58 PM, Christer Holmberg <christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>> wrote:

Hi,

>Try RFC 8225, Section 9, perhaps?

Ok, so if that’s a generic rule, why the statement saying that PASSporT extensions must specify the order?

Regards,

Christer

From: Christer Holmberg [mailto:christer.holmberg@ericsson.com]
Sent: Tuesday, March 13, 2018 2:47 PM
To: Chris Wendt <chris-ietf@chriswendt.net<mailto:chris-ietf@chriswendt.net>>
Cc: stir@ietf.org<mailto:stir@ietf.org>; adam@nostrum.com<mailto:adam@nostrum.com>
Subject: Re: [stir] PASSporT extensions: order of claims

Hi,

>I would agree with the text, the only caveat i would point out is that the extension definition has
>no choice to the order other than alphabetic order, so the order is essentially implied.  So, it’s sort
>of a technicality that maybe we didn’t anticipate, but i think technically you are correct.

Not sure I understand the has-no-choice part. Where is it said that the claims must be ordered in alphabetic order? We could for sure specify it that way, but based on your e-mail it seems like it is already specified somewhere?

Regards,

Christer


On Mar 10, 2018, at 8:27 AM, Christer Holmberg <christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>> wrote:

Section 8.3 of RFC 8225, that is.

From: stir [mailto:stir-bounces@ietf.org] On Behalf Of Christer Holmberg
Sent: 10 March 2018 15:26
To: stir@ietf.org<mailto:stir@ietf.org>
Cc: adam@nostrum.com<mailto:adam@nostrum.com>
Subject: [stir] PASSporT extensions: order of claims

Hi,

Section  says:

   “Specifications that define extensions to the PASSporT mechanism MUST
   explicitly specify what claims they include beyond the base set of
   claims from this document, the order in which they will appear,…”

When looking at the extensions we are currently working on:

draft-ietf-stir-rph-03
draft-ietf-stir-passport-shaken-01
draft-ietf-stir-passport-divert-02

…I don’t see anything about the order in any of the documents.

I think it would be good to have a dedicated “Order of claims” section, or something similar, in each extension specification.

When looking at the examples in the drafts above, it seems like even the base claims are in different orders. Not sure whether there is an explicit requirement that they need to be in order, thought.

Regards,

Christer


_______________________________________________
stir mailing list
stir@ietf.org<mailto:stir@ietf.org>
https://www.ietf.org/mailman/listinfo/stir<https://urldefense.proofpoint.com/v2/url?u=https-3A__www.ietf.org_mailman_listinfo_stir&d=DwMGaQ&c=MOptNlVtIETeDALC_lULrw&r=ww1S9BHEcpE4MMUbgGQrsoL-SK3UCGY33Koaj2h9zYw&m=_DBdmUKpkUAUVv120PuHoMt-TVtTuzOHsfFQdAWmeFs&s=yYY6kvNSlx7W84nXLfYP7n4PSH0S7Uiq3VK2FI6iwEU&e=>