[storm] MIB Dr. review of draft-ietf-storm-ifcpmib-05

"Joan Cucchiara" <jcucchiara@mindspring.com> Mon, 18 October 2010 02:30 UTC

Return-Path: <jcucchiara@mindspring.com>
X-Original-To: storm@core3.amsl.com
Delivered-To: storm@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 6DCED3A6C82; Sun, 17 Oct 2010 19:30:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.91
X-Spam-Level:
X-Spam-Status: No, score=0.91 tagged_above=-999 required=5 tests=[AWL=-1.095, BAYES_50=0.001, STOX_REPLY_TYPE=0.001, TRACKER_ID=2.003]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id awbs9r0FXi5t; Sun, 17 Oct 2010 19:30:21 -0700 (PDT)
Received: from elasmtp-spurfowl.atl.sa.earthlink.net (elasmtp-spurfowl.atl.sa.earthlink.net [209.86.89.66]) by core3.amsl.com (Postfix) with ESMTP id 5742E3A6C8A; Sun, 17 Oct 2010 19:30:21 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=dk20050327; d=mindspring.com; b=SvCL0dfTBcocSzcPIAMo6THwqPH+Y57oTGiZ74ilJxgWtUKl7ydXheUvAIdZzRCm; h=Received:Message-ID:From:To:Cc:Subject:Date:MIME-Version:Content-Type:Content-Transfer-Encoding:X-Priority:X-MSMail-Priority:X-Mailer:X-MimeOLE:X-ELNK-Trace:X-Originating-IP;
Received: from [108.1.133.146] (helo=JoanPC) by elasmtp-spurfowl.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from <jcucchiara@mindspring.com>) id 1P7fVr-0004QM-Vr; Sun, 17 Oct 2010 22:31:48 -0400
Message-ID: <002401cb6e6c$6def3e30$6501a8c0@JoanPC>
From: "Joan Cucchiara" <jcucchiara@mindspring.com>
To: <storm@ietf.org>, <prakashvn@hcl.com>
Date: Sun, 17 Oct 2010 22:30:28 -0400
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.2180
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180
X-ELNK-Trace: 4d68bbe9cb71969ea344cf2d1a8e60840a9da525759e2654204496817191d611ad74dc26b492d0a599f37241381ec17c350badd9bab72f9c350badd9bab72f9c
X-Originating-IP: 108.1.133.146
Cc: "'Romascanu, Dan \(Dan\)'" <dromasca@avaya.com>, mib-doctors@ietf.org
Subject: [storm] MIB Dr. review of draft-ietf-storm-ifcpmib-05
X-BeenThere: storm@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Storage Maintenance WG <storm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/storm>, <mailto:storm-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/storm>
List-Post: <mailto:storm@ietf.org>
List-Help: <mailto:storm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/storm>, <mailto:storm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Oct 2010 02:30:22 -0000

Hello Prakash,

Thank you for providing this updated MIB document.

This MIB compiles cleanly with both smiLint and
smicngPRO MIB compilers.

Comments follow.  Please let me know if you 
have any questions.

Thanks,
  -Joan



COMMENTS
---------

GENERAL Comment:  When an object, or Conformance Group
is deprecated, the DESCRIPTION clause needs to be updated
to state this and the reason for the deprecation.

Almost all the DESCRIPTION clauses do mention the deprecation but
this is at the very end of the DESCRIPTION clause,  Please 
start the DESCRIPTION clause with this information, such as:

DESCRIPTION:
"This object is deprecated.  It has been deprecated because ...
Then include the original description.

Specific examples are included in the comments below.

 

1)  NIT:  Please put a UNITS clause on the objects
that use these TCs:
IfcpIpTOVorZero  UNITS: seconds
IfcpLTIorZero    UNITS: seconds



2)  * IfcpAddressMode TEXTUAL-CONVENTION

Why was the STATUS not changed to "deprecated"?
Please do so.  

Also, as discussed above, please change the DESCRIPTION to state that the
TC is deprecated and why as the first statement(s) of the
DESCRIPTION clause.


3) ifcpLclGtwyInstAddrTransMode     IfcpAddressMode,

The ifcpLclGtwyInstAddrTransMode object is the only
object which uses the (deprecated) IfcpAddressMode TC.

This object should also be deprecated.

A new read-only object could be added if this is thought to be
beneficial.. 


4)  ifcpLclGtwyInstStorageType should be deprecated also.

   ifcpLclGtwyInstStorageType OBJECT-TYPE
       SYNTAX            StorageType
       MAX-ACCESS        read-only
       STATUS            current
       DESCRIPTION
   "The storage type for this row.  Parameter values defined
    for a gateway are usually non-volatile, but may be volatile
    or permanent in some configurations.  If permanent, then
    the following parameters must have read-write access:
    ifcpLclGtwyInstAddrTransMode, ifcpLclGtwyInstDefaultIpTOV,
    and ifcpLclGtwyInstDefaultLTInterval."
       DEFVAL            { nonVolatile }
       ::= {ifcpLclGtwyInstEntry      11}


The DESCRIPTION clause specifies ifcpLclGtwyInstAddrTransMode as one of
the values to provide read-write access for when the value of this object
is permanent, as such this object should be deprecated.

A new StorageType object which excludes the ifcpLclGtwyInstAddrTransMode
should also probably be added.   

A related question on this object, why was ifcpLclGtwyInstFcBrdcstSupport
not included in this list of read-write objects?



5) ifcpLclGatewayGroup may need to be deprecated and replaced by another
group after 1-4  is done.


6)  According to rfc2580, Section 7.1

If changing a STATUS to "deprecated"
the DESCRIPTION clause should be updated
to explain.

*ifcpLclGatewaySessionGroup STATUS was
changed to "deprecated" but the DESCRIPTION
has not been changed.   Again, please state
that the group has been deprecated and why as the
first sentence of the DESCRIPTION clause.


7). Naming of the new Compliance Group

ifcpLclGatewaySessionGroupNoTrans

(original name:  ifcpLlGatewaySessionGroup)

The "NoTrans" suffix is not specific enough  because this
could stand for No Translation Mode  or No Transparent Mode,
in other words, please replace the "NoTrans" with
something definitive such as:

NoTranslationMode or NoTranslation


8) Security Considerations 

This section needs to be updated to reflect the deprecation of
the Translation Mode.  For example, the ifcpLclGtwyInstAddrTransMode
is mentioned and this is now deprecated.

--End of comments--