[storm] draft-ietf-storm-mpa-peer-connect - review comment

Steve Wise <swise@opengridcomputing.com> Tue, 23 August 2011 13:48 UTC

Return-Path: <swise@opengridcomputing.com>
X-Original-To: storm@ietfa.amsl.com
Delivered-To: storm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 04FF621F8B33 for <storm@ietfa.amsl.com>; Tue, 23 Aug 2011 06:48:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.265
X-Spam-Level:
X-Spam-Status: No, score=-2.265 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, IP_NOT_FRIENDLY=0.334]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MrZyXzbLiblH for <storm@ietfa.amsl.com>; Tue, 23 Aug 2011 06:48:25 -0700 (PDT)
Received: from linode.aoot.com (linode.aoot.com [69.164.194.13]) by ietfa.amsl.com (Postfix) with ESMTP id E6A0321F8B2F for <storm@ietf.org>; Tue, 23 Aug 2011 06:48:17 -0700 (PDT)
Received: from [10.10.0.77] (unknown [209.198.142.3]) by linode.aoot.com (Postfix) with ESMTP id B9FBA821C; Tue, 23 Aug 2011 08:49:24 -0500 (CDT)
Message-ID: <4E53AFD2.50108@opengridcomputing.com>
Date: Tue, 23 Aug 2011 08:49:06 -0500
From: Steve Wise <swise@opengridcomputing.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20110812 Thunderbird/6.0
MIME-Version: 1.0
To: arkady kanevsky <arkady.kanevsky@gmail.com>
References: <B7F58B09EC4B43D7BF8BFA9FA95A8061@davidPC> <95DEF288D9FA451B8C4BCA4ACAE1C6DA@davidPC> <CAChuxHggYU5ivHxgWFVOs6vxCH2nb=mbMJSnx10J7rjK0zAhpg@mail.gmail.com>
In-Reply-To: <CAChuxHggYU5ivHxgWFVOs6vxCH2nb=mbMJSnx10J7rjK0zAhpg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>, "Latif, Faisal" <faisal.latif@intel.com>, Kumar A S <kumaras@chelsio.com>, storm@ietf.org
Subject: [storm] draft-ietf-storm-mpa-peer-connect - review comment
X-BeenThere: storm@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Storage Maintenance WG <storm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/storm>, <mailto:storm-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/storm>
List-Post: <mailto:storm@ietf.org>
List-Help: <mailto:storm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/storm>, <mailto:storm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Aug 2011 13:48:26 -0000

Hey,

I believe the ORD/IRD fields in the MPAv2 messages need to be in Network 
Byte Order.  This is not mandated in the draft.

I also think there is an oversight in RFC 5044 with regard to the 
PD_Length field in the MPAv1 messages.  It should also be in Network 
Byte Order, but I don't see this requirement anywhere in the RFC.

Or maybe NBO is a always assumed in IETF wire-protocol messages?


Steve.