Re: [storm] I-D Action: draft-wood-storm-rdmap-ext-v2-00.txt

"Black, David" <david.black@emc.com> Tue, 18 February 2014 10:12 UTC

Return-Path: <david.black@emc.com>
X-Original-To: storm@ietfa.amsl.com
Delivered-To: storm@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E49491A0629 for <storm@ietfa.amsl.com>; Tue, 18 Feb 2014 02:12:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.549
X-Spam-Level:
X-Spam-Status: No, score=-2.549 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RP_MATCHES_RCVD=-0.548, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x-I-GaYOvAgn for <storm@ietfa.amsl.com>; Tue, 18 Feb 2014 02:12:18 -0800 (PST)
Received: from mailuogwdur.emc.com (mailuogwdur.emc.com [128.221.224.79]) by ietfa.amsl.com (Postfix) with ESMTP id 365CA1A0625 for <storm@ietf.org>; Tue, 18 Feb 2014 02:12:18 -0800 (PST)
Received: from maildlpprd51.lss.emc.com (maildlpprd51.lss.emc.com [10.106.48.155]) by mailuogwprd52.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s1IACE08019067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <storm@ietf.org>; Tue, 18 Feb 2014 05:12:14 -0500
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd52.lss.emc.com s1IACE08019067
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=emc.com; s=jan2013; t=1392718335; bh=t4nPHjKrVD598tuoiYusDb6cx3A=; h=From:To:Date:Subject:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=XM8F0njnKrp5St27v4q7XjDnWmAUpd2bMDBnc7Z/WGYEBVh47IMGrJC+e6uPhonqK nHwv1AZYAmkuVHhpEwCz6/C5HGZrM+ZrMIgu+a2iJP7TXzlg9ux7EUfpC+eDQZS5Ow Sjb84n4y/ex/dX3/uEXeYlJoas7rP9/MVRpSH6Do=
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd52.lss.emc.com s1IACE08019067
Received: from mailusrhubprd52.lss.emc.com (mailusrhubprd52.lss.emc.com [10.106.48.25]) by maildlpprd51.lss.emc.com (RSA Interceptor) for <storm@ietf.org>; Tue, 18 Feb 2014 05:12:08 -0500
Received: from mxhub25.corp.emc.com (mxhub25.corp.emc.com [10.254.110.181]) by mailusrhubprd52.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s1IAC8JN007447 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for <storm@ietf.org>; Tue, 18 Feb 2014 05:12:08 -0500
Received: from mx15a.corp.emc.com ([169.254.1.167]) by mxhub25.corp.emc.com ([10.254.110.181]) with mapi; Tue, 18 Feb 2014 05:12:07 -0500
From: "Black, David" <david.black@emc.com>
To: "storm@ietf.org" <storm@ietf.org>
Date: Tue, 18 Feb 2014 05:12:06 -0500
Thread-Topic: I-D Action: draft-wood-storm-rdmap-ext-v2-00.txt
Thread-Index: Ac8sXqb21f7ty/lvTdOyiZ/xtzV+wA==
Message-ID: <8D3D17ACE214DC429325B2B98F3AE712027281E5B8@MX15A.corp.emc.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Sentrion-Hostname: mailusrhubprd52.lss.emc.com
X-RSA-Classifications: public
Archived-At: http://mailarchive.ietf.org/arch/msg/storm/wpS2W0qH6w8TBdYbUJEpyMmz9gQ
Subject: Re: [storm] I-D Action: draft-wood-storm-rdmap-ext-v2-00.txt
X-BeenThere: storm@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Storage Maintenance WG <storm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/storm>, <mailto:storm-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/storm/>
List-Post: <mailto:storm@ietf.org>
List-Help: <mailto:storm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/storm>, <mailto:storm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Feb 2014 10:12:21 -0000

I've taken an initial look at this draft.

I apologize for the delay, but I've been focused on moving the iSCSI drafts
forward - the RFC Editor is almost done editing them, and their expected RFC
publication date is mid-March after the T10 dependency in the iscsi-sam
draft is cleared (expected at the T10 March meetings).

In any case, here are some initial comments on 3 topics in the rdmap-ext-v2
draft.

<WG chair hat ON>

[1] Negotiation

Hmm, this combination looks like a serious problem:

Section 1.1:
   The discovery and negotiation of the RDMA Extensions and the RDMAP
   Extensions is covered in MPA Extensions [RFCZZZZ].

Normative References:
   [RFCZZZZ] "MPA Extensions" (not yet written)

Given that this draft intends to change the protocol version, that negotiation
mechanism is crucial, but at the moment, it's unspecified - a proverbial
"pig in a poke".

I don't think it's appropriate for the WG to adopt this draft until there's
at least an initial specification of the negotiation mechanism, and Hemal's
comment about whether individual features should be negotiated will need
discussion (although that can happen after draft adoption).

When both drafts are available, my inclination would be to propose WG adoption
of both as a package (and we'd need to add a goal/milestone to the WG charter
at that time).

[2] IANA Considerations

Also, the IANA considerations will need to be reworked, as RFC 6580 says:

   Namespace details: RDMAP Operation Codes are 4-bit values [RFC5040].

and hence 5-bit opcodes cannot be added to that registry.

I think a separate registry for the v2 opcodes is probably what's called for,
with an entry that references the existing registry for 0x00 - 0x0F.

[3] Reference to RDMA Protocol Extensions

Finally, something small, but important:

   [RFCYYYY] Shah, H. et al., "RDMA Protocol Extensions", RFC YYYY,
             October 2013.

That's not the right way to reference that document; refer to it as an
Internet-Draft by its Internet-Draft name: draft-ietf-storm-rdmap-ext-08.txt .

</WG chair hat ON>


Thanks,
--David

> -----Original Message-----
> From: I-D-Announce [mailto:i-d-announce-bounces@ietf.org] On Behalf Of
> internet-drafts@ietf.org
> Sent: Tuesday, November 26, 2013 2:13 PM
> To: i-d-announce@ietf.org
> Subject: I-D Action: draft-wood-storm-rdmap-ext-v2-00.txt
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories.
> 
> 
> 	Title           : RDMA Protocol Extensions V2
> 	Author(s)       : Donald Wood
>                           Robert Sharp
>                           Kenneth Keels
> 	Filename        : draft-wood-storm-rdmap-ext-v2-00.txt
> 	Pages           : 23
> 	Date            : 2013-11-26
> 
> Abstract:
>    This document specifies extensions to the IETF Remote Direct Memory
>    Access Protocol and RDMA Protocol Extensions. RDMAP provides read
>    and write services directly to applications and enables data to be
>    transferred directly into Upper Layer Protocol (ULP) Buffers without
>    intermediate data copies. The extensions specified in this document
>    provide the following capabilities and/or improvements to eliminate
>    application visible differences with other RDMA technologies: Send
>    with Immediate Data Operations and a new form of RDMA Read
>    Operation.
> 
> 
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-wood-storm-rdmap-ext-v2
> 
> There's also a htmlized version available at:
> http://tools.ietf.org/html/draft-wood-storm-rdmap-ext-v2-00
> 
> 
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
> 
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
> 
> _______________________________________________
> I-D-Announce mailing list
> I-D-Announce@ietf.org
> https://www.ietf.org/mailman/listinfo/i-d-announce
> Internet-Draft directories: http://www.ietf.org/shadow.html
> or ftp://ftp.ietf.org/ietf/1shadow-sites.txt