[storm] idnits on rdmap-ext draft
"Black, David" <david.black@emc.com> Sat, 14 September 2013 05:14 UTC
Return-Path: <david.black@emc.com>
X-Original-To: storm@ietfa.amsl.com
Delivered-To: storm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4034411E80F3 for <storm@ietfa.amsl.com>; Fri, 13 Sep 2013 22:14:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level:
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u9SrvDnm63nB for <storm@ietfa.amsl.com>; Fri, 13 Sep 2013 22:14:09 -0700 (PDT)
Received: from mailuogwdur.emc.com (mailuogwdur.emc.com [128.221.224.79]) by ietfa.amsl.com (Postfix) with ESMTP id 320F811E80ED for <storm@ietf.org>; Fri, 13 Sep 2013 22:14:09 -0700 (PDT)
Received: from maildlpprd54.lss.emc.com (maildlpprd54.lss.emc.com [10.106.48.158]) by mailuogwprd53.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id r8E5E2II012750 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 14 Sep 2013 01:14:03 -0400
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd53.lss.emc.com r8E5E2II012750
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=emc.com; s=jan2013; t=1379135643; bh=QNiBgfuTbhnxznPq4P36CC/QZmQ=; h=From:To:Date:Subject:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=YWa2O3RJcBrNlVH4o7sKfs6galP1c3FswLfPGjdujwu6lCZOhs1pvNk6rt7y85r8e jG5yyV2/5Yb3dRUF/FblOCpTcEg1TjkL4SrolvnaFSLS2SemsU2MTJoRdNhSM9ioH1 vj8Vg5a3b7hB0aerX8BOgaXXPktYm06SrMHsXLTw=
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd53.lss.emc.com r8E5E2II012750
Received: from mailusrhubprd04.lss.emc.com (mailusrhubprd04.lss.emc.com [10.253.24.22]) by maildlpprd54.lss.emc.com (RSA Interceptor); Sat, 14 Sep 2013 01:13:49 -0400
Received: from mxhub20.corp.emc.com (mxhub20.corp.emc.com [10.254.93.49]) by mailusrhubprd04.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id r8E5DnRE014440 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Sat, 14 Sep 2013 01:13:49 -0400
Received: from mx15a.corp.emc.com ([169.254.1.46]) by mxhub20.corp.emc.com ([10.254.93.49]) with mapi; Sat, 14 Sep 2013 01:13:49 -0400
From: "Black, David" <david.black@emc.com>
To: "Sharp, Robert O" <robert.o.sharp@intel.com>, "storm@ietf.org" <storm@ietf.org>
Date: Sat, 14 Sep 2013 01:13:48 -0400
Thread-Topic: idnits on rdmap-ext draft
Thread-Index: Ac6w84SmJQlI5vgLSq2GTc+cAN8/KQ==
Message-ID: <8D3D17ACE214DC429325B2B98F3AE712025DA1BD35@MX15A.corp.emc.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Sentrion-Hostname: mailusrhubprd04.lss.emc.com
X-EMM-GWVC: 1
X-RSA-Classifications: public
X-EMM-McAfeeVC: 1
Subject: [storm] idnits on rdmap-ext draft
X-BeenThere: storm@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Storage Maintenance WG <storm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/storm>, <mailto:storm-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/storm>
List-Post: <mailto:storm@ietf.org>
List-Help: <mailto:storm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/storm>, <mailto:storm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Sep 2013 05:14:13 -0000
> We are not sure what to do with these at this point: > > == Missing Reference: 'RFCXXXX' is mentioned on line 1266, but not > defined > 'RFC Editor: Please replace XXXX in all instances of [RFCXXXX] abo...' > == Missing Reference: 'RFC5226' is mentioned on line 1264, but not > defined > 'Allocation Policy: Standards Action ([RFC5226])...' Ignore the first nit - that's a typical nit in IANA Considerations when defining a new registry. When Tom or I prepare the writeup on this draft for the IESG, that'll be noted as ok to ignore. The second nit is indicating that RFC5226 needs to be added as a Normative Reference - do that, please. Thanks, --David > -----Original Message----- > From: storm-bounces@ietf.org [mailto:storm-bounces@ietf.org] On Behalf Of > Sharp, Robert O > Sent: Wednesday, September 11, 2013 5:03 PM > To: Tom Talpey; storm@ietf.org > Subject: Re: [storm] Review comments on updated draft-ietf-storm-rdmap-ext-05 > > Hi Tom, > > Again, thanks for the review and comments. Responses below... > > Thanks, > Bob > > > -----Original Message----- > > From: storm-bounces@ietf.org [mailto:storm-bounces@ietf.org] On Behalf > > Of Tom Talpey > > Sent: Friday, September 06, 2013 2:07 PM > > To: storm@ietf.org > > Subject: [storm] Review comments on updated draft-ietf-storm-rdmap-ext- > > 05 > > > > Authors, thanks for the updates to the RDMA Extensions draft based on > > comments received. > > > > I have some comments on the recent set of changes, which I would like to > > discuss before considering this version ready for Working Group Last Call. > > > > > > 1) Section 1.1 "Discovery of RDMAP Extensions" was added and addresses > > many of my earlier concerns. However, it says the following: > > > > " Today there are RDMA applications and/or ULPs that are aware of the > > existence of Atomic and Immediate data operations for RDMA > > transports such as [IB]. Today, these applications need to be aware > > that iWARP RNICs do not support these operations." > > and > > "Negotiation of Atomic Operations typically are to determine the > > scope of atomicity guarantees, not down to the individual Atomic > > Operations supported. Therefore, this specification requires all > > Atomic Operations defined within to be supported if an RNIC supports > > any Atomic Operations." > > Subsequently, section 5 now says: > > " The Atomic Operations specified in this document provide > > equivalent functionality to the [IB] RDMA transport, to allow > > applications that use these primitives to work interchangeably over > > iWARP. In addition, this document specifies a basic Swap operation." > > > > That last sentence extends Atomics beyond those of Infiniband, and this in > > turn contradicts the goal stated in section 1.1 that applications should not > > need to be aware of differences. This inconsistency needs to be addressed. > > > > The Swap operation has been removed and a reference to OFA Verbs extensions > for masked atomics has been added. > > > > > 2) While the text has been updated to specify the target of Atomic > > operations as a registered ULP buffer, it does not discuss the fact that > this is > > compatible with (indeed, required by) the RFC5042 security model. This > > should be made explicit, and the reference made explicit. > > > > Added reference to RFC 5042 and the ULP Buffer address reference to the 5042 > security model. > > > > > 3) In section 5.4, an "Implementation note" uses the invalid term "MAY > > NOT". Perhaps this means to say the behavior is "OPTIONAL"? Or is it "MUST > > NOT"? As a general comment, when implementation notes contain > > normative language, they are not actually notes,. It may be safer to make > > specific requirements here, and also check the other notes. > > > > The intention was to note that since this is a wire protocol, it is important > to note that it is an implementation decision to provide greater scope of > atomicity than just the RNIC. Changed MAY NOT to may not. We considered > making this a positive MAY requirement, but that didn't seem like a good idea > when we discussed it. > > > > > 4) In section 6, it is not clear what advice this statement is making. Is it > > intended to be normative, saying that Immediate Data operations always do > > this? If so, it should move to the processing text below. Also, the term > > "RDMA Completion" appears three times in this paragraph, but is not > > defined. Do you mean simply "Completion"? > > > > " An Immediate Data operation that is not preceded by an RDMA > > Write operation causes an RDMA Completion." > > > > This text is descriptive and intended to describe the expected usage, but > indicate that the expected usage is not absolutely required. For example, > there is no error checking if immediate data is not proceeded by an RDMA > Write. RDMA Completion is defined in RFC5040. > > > > > > > 5) Nits: > > > > Section 1.1 could use a paragraph break for improved readability. > > > > Fixed. > > > > > In the Glossary, ULP is defined as "Upper Level Protocol". The existing 504x > > RFCs, and I believe common usage, use "Upper Layer Protocol". Suggest > > using this definition. > > Thanks. Seems like we can just delete the definition then. Do you agree? > > > > > Also in the Glossary, this statement should be moved from the definition of > > Atomics, to section 5: > > " Atomicity guarantees > > across multiple RNICs or between other applications/ULPs running on > > the Responder with access to the ULP Buffer are outside the scope of > > this specification. > > > Fixed. > > > > In section 4.1, the sentence beginning "This extension defines RDMAP use > > Queue Number 3..." appears to be missing a word ("use of"?). > > > > Thanks! Fixed > > > RFC5042 is not referenced in the body, but it appears as a normative > > reference. It should be referenced, perhaps from section 5 in the discussion > > of the target of Atomic operations. > > > > The document has a small number of id-nits which should be corrected. > > Long lines have been fixed. > > We are not sure what to do with these at this point: > > == Missing Reference: 'RFCXXXX' is mentioned on line 1266, but not > defined > 'RFC Editor: Please replace XXXX in all instances of [RFCXXXX] abo...' > == Missing Reference: 'RFC5226' is mentioned on line 1264, but not > defined > 'Allocation Policy: Standards Action ([RFC5226])...'> > > > > _______________________________________________ > > storm mailing list > > storm@ietf.org > > https://www.ietf.org/mailman/listinfo/storm > _______________________________________________ > storm mailing list > storm@ietf.org > https://www.ietf.org/mailman/listinfo/storm
- [storm] idnits on rdmap-ext draft Black, David
- Re: [storm] idnits on rdmap-ext draft Sharp, Robert O