[Stox] My review on draft-ietf-stox-7284bis

Saúl Ibarra Corretgé <saul@ag-projects.com> Fri, 13 March 2015 16:04 UTC

Return-Path: <saul@ag-projects.com>
X-Original-To: stox@ietfa.amsl.com
Delivered-To: stox@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A6B41A8783 for <stox@ietfa.amsl.com>; Fri, 13 Mar 2015 09:04:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 2.311
X-Spam-Level: **
X-Spam-Status: No, score=2.311 tagged_above=-999 required=5 tests=[BAYES_50=0.8, HELO_MISMATCH_NET=0.611, J_CHICKENPOX_22=0.6, MIME_8BIT_HEADER=0.3] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MwwVf8S3JWJd for <stox@ietfa.amsl.com>; Fri, 13 Mar 2015 09:04:01 -0700 (PDT)
Received: from mail.sipthor.net (node16.dns-hosting.info [81.23.228.161]) by ietfa.amsl.com (Postfix) with ESMTP id 50BF01A87EA for <stox@ietf.org>; Fri, 13 Mar 2015 09:04:01 -0700 (PDT)
Received: from [192.168.99.53] (i19025.upc-i.chello.nl [62.195.19.25]) by mail.sipthor.net (Postfix) with ESMTPSA id BF55F16DC6B3 for <stox@ietf.org>; Fri, 13 Mar 2015 17:03:59 +0100 (CET)
From: =?windows-1252?Q?Sa=FAl_Ibarra_Corretg=E9?= <saul@ag-projects.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Message-Id: <AFA60318-E0A3-4BA2-BCFB-FD0F0685E44D@ag-projects.com>
Date: Fri, 13 Mar 2015 17:04:03 +0100
To: stox@ietf.org
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/stox/_cgpBm8Qaf4E7A70RaGif3O5x5U>
Subject: [Stox] My review on draft-ietf-stox-7284bis
X-BeenThere: stox@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: SIP-TO-XMPP Working Group discussion list <stox.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stox>, <mailto:stox-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/stox/>
List-Post: <mailto:stox@ietf.org>
List-Help: <mailto:stox-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stox>, <mailto:stox-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Mar 2015 16:04:08 -0000

Hi Peter and all!

So, review time!

Sec 4.2.1

Not sure if this was discussed (memory is fuzzy right now), but that diagram feels a bit odd. The SIP Server + S2X gateway entity gets SIP traffic but responds with XMPP replies. In practice, there would only be a X2S entity in that scenario, because the subscription started on the XMPP side. The X2S gateway would do the translation, and the SIP server knows nothing about XMPP.

Example 2:

Maybe add a To header? 

Example 4:

From and To tags don’t match those of the SUBSCRIBE / 200 OK, but the CallID does.

Section 4..2.3

Same as above, looks weird that the S2X gateway generated the XMPP response without ever getting the request.

Example 8:

The SUBSCRIBE needs to be in-dialog, so From and To tags need to match, and so does the Call-ID. Also the CSeq would need to be higher. Maybe put 100, thus implying that there have been a bunch of NOTIFY requests already.

Section 4.3.1

Opposite of my 2 other comments :-) Maybe I’m super confused today or we can have a quick chat / call next week to go over it?

Example 10:

Missing To header

Example 14:

Call-ID missmatch

Example 16:

The SUBSCRIBE must be in-dialog, same problem as Example 8.

Section 4.3.3

Point 2 it’s not very clear to me, upon receiving the SUBSCRIBE request with Expires 0, there is no need to send it again.

Example 18:

Maybe we need to mention that the XMPP resource can contain unicode and xs:ID is ASCII only?

Point 5: To terminate the subscription from the notifier side, a NOTIFY with Subscription-State: terminated is sent, not a SUBSCRIBE with Expires 0, that is used from the subscriber side.

Example 22:

A presence probe was a one-off presence request, right? If so, the CSeq should be 1, since this would be a new dialog. Also, missing To header.

Example 23:

Same as above.


That’s all I got! :-)

--
Saúl Ibarra Corretgé
AG Projects