Re: [Stox] WGLC for draft-ietf-stox-groupchat-04

Peter Saint-Andre <stpeter@stpeter.im> Mon, 21 April 2014 01:35 UTC

Return-Path: <stpeter@stpeter.im>
X-Original-To: stox@ietfa.amsl.com
Delivered-To: stox@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 623361A0102 for <stox@ietfa.amsl.com>; Sun, 20 Apr 2014 18:35:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.174
X-Spam-Level:
X-Spam-Status: No, score=-2.174 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.272, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EE4qAoZegPPS for <stox@ietfa.amsl.com>; Sun, 20 Apr 2014 18:35:01 -0700 (PDT)
Received: from stpeter.im (mailhost.stpeter.im [207.210.219.225]) by ietfa.amsl.com (Postfix) with ESMTP id A63E01A00FE for <stox@ietf.org>; Sun, 20 Apr 2014 18:35:01 -0700 (PDT)
Received: from aither.local (unknown [24.8.184.175]) (Authenticated sender: stpeter) by stpeter.im (Postfix) with ESMTPSA id 4769F4032A; Sun, 20 Apr 2014 19:34:54 -0600 (MDT)
Message-ID: <535475BF.1010508@stpeter.im>
Date: Sun, 20 Apr 2014 19:34:55 -0600
From: Peter Saint-Andre <stpeter@stpeter.im>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Philipp Hancke <fippo@goodadvice.pages.de>, stox@ietf.org
References: <0E1BD27E-E0B5-4B61-8451-5B3ED8B649A2@jitsi.org> <5353FEFA.8070907@goodadvice.pages.de>
In-Reply-To: <5353FEFA.8070907@goodadvice.pages.de>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: http://mailarchive.ietf.org/arch/msg/stox/cTGns-UWs-MRlGaiwqXxXaFYxAs
Subject: Re: [Stox] WGLC for draft-ietf-stox-groupchat-04
X-BeenThere: stox@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: SIP-TO-XMPP Working Group discussion list <stox.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stox>, <mailto:stox-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/stox/>
List-Post: <mailto:stox@ietf.org>
List-Help: <mailto:stox-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stox>, <mailto:stox-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Apr 2014 01:35:03 -0000

On 4/20/14, 11:08 AM, Philipp Hancke wrote:
> Am 06.04.2014 20:20, schrieb Yana Stamcheva:
>> The editors and the chairs believe that the following draft is now
>> ready and hereby start a 2-week Working Group Last Call for:
>>
>> draft-ietf-stox-groupchat-04 :
>> http://tools.ietf.org/html/draft-ietf-stox-groupchat-04 (Last updated
>> on 2014-03-25)
>>
>> The WGLC ends on April 21, 2014.
>>
>> Please review the document and bring any remaining issues, or issues
>> whose resolution is not satisfactory, to the attention of the Working
>> Group on this list before April 21.
>>
>> If after reviewing the document you find it complete and do not have
>> any comments, please send a note to that effect as well!
>
> Looking good to me.
>
> In some of the examples, a Content-Length header is given, in others
> there is an ellipsis. I'd recommend replacing the given lengths with
> an ellipsis whenever it is nonzero.
>
> The content-lengths affected by this would be 182, 214, 163, 20,
> I am pretty sure that some of these were calculated with linefeed
> instead of CRLF whereas others (163) seem just wrong.

I think we added those content-lengths quite a while ago and didn't 
necessarily keep them in sync with the payloads. Ellipsis solves that 
problem neatly :-)

Thanks for the review!

Peter