[Stox] review of core, chat, groupchat and presence

Philipp Hancke <fippo@goodadvice.pages.de> Thu, 08 August 2013 18:33 UTC

Return-Path: <fippo@goodadvice.pages.de>
X-Original-To: stox@ietfa.amsl.com
Delivered-To: stox@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BBC2511E80F4 for <stox@ietfa.amsl.com>; Thu, 8 Aug 2013 11:33:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.275
X-Spam-Level:
X-Spam-Status: No, score=-1.275 tagged_above=-999 required=5 tests=[AWL=0.124, BAYES_00=-2.599, J_CHICKENPOX_14=0.6, J_CHICKENPOX_34=0.6]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5EkRWE34Qopf for <stox@ietfa.amsl.com>; Thu, 8 Aug 2013 11:33:47 -0700 (PDT)
Received: from lo.psyced.org (lost.IN.psyced.org [188.40.42.221]) by ietfa.amsl.com (Postfix) with ESMTP id 34FB211E8149 for <stox@ietf.org>; Thu, 8 Aug 2013 11:33:47 -0700 (PDT)
Received: from [192.168.2.100] (p54972629.dip0.t-ipconnect.de [84.151.38.41]) (authenticated bits=0) by lo.psyced.org (8.14.3/8.14.3/Debian-9.4) with ESMTP id r78IXiuG016367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <stox@ietf.org>; Thu, 8 Aug 2013 20:33:46 +0200
Message-ID: <5203E484.4050902@goodadvice.pages.de>
Date: Thu, 08 Aug 2013 20:33:40 +0200
From: Philipp Hancke <fippo@goodadvice.pages.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7
MIME-Version: 1.0
To: stox@ietf.org
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Stox] review of core, chat, groupchat and presence
X-BeenThere: stox@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: SIP-TO-XMPP Working Group discussion list <stox.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/stox>, <mailto:stox-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/stox>
List-Post: <mailto:stox@ietf.org>
List-Help: <mailto:stox-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/stox>, <mailto:stox-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Aug 2013 18:33:59 -0000

I just noticed i reviewed -00 from the draft package... but anyway, 
quite a number of nits. Read them coming from XMPP land.

Comments prefixed with example of section number.
editorial comments:
- inconsistent usage of note. sometimes (Note: ...) other times (-im,
   presence) Note:
- chat and im prefix examples with '|'

chat:
     example f2: call-id: contain jid? how about uniqueness?.
	    Is there any text on the use of <thread/>?
	in -im @example.com callid is used
     	a=lang could be taken xml:lang?
     before example F4: the gateway acknowledges on behalf of juliet?

     example f5: the initial message in F1 should have an id
	attribute which gets mapped in f5. Does a786hjs2 map to
	thread/call id?

     example f6: shouldn't message-id should be different from f5?
         mapping of message-id to id attribute, should be randomly
	generated if not present

     section 4: sessinos -> sessions;

core:
     the draft says:
	     instant messaging and presence applications of XMPP also
	     need to support im: and pres: URIs
	     as specified in [RFC3860] and [RFC3859] respectively
	while this is encouraged in RFC 6121, those are informative
	references.

     4.2 bullet 1: ref to jid escaping xep here instead of in bullet 3
     5.1: <policy-violation/> is missing from the list.

groupchat:
     2: at least in RFC 6120, jid stands for jabber id, not jabber
	identifier.
     3.1: Room Nickname -> lowercase?
     3.1: example f2: conversion->conversation?
          table 1: thread<->call id
     3.2: example f7: possibly use by= on the error element?
	xep 0045 has the conflicting resource in the from
     3.4: "Occupant JID in another room" -- i don't think mediated
	invites work across different rooms.
         example f1: hecate is benvolio? c&p error from 0045
         example f2: contact juliet@juliet.example.com has a wrong host?
         reeived -> received
         example f3 is not shown
         below f4 there is a sip/2.0 200 ok on its own?
     3.5: table 2: xmpp From/To -> from/to
         ex f9: where is juliets own presence in msrp?
         ex f11: where is juliets own presence with code 110?
         ex f14: mapping <message id/> to Message-ID
         	does msrp have a concept of room history?
     3.6.2: do we have an equivalent disco feature for muc?
     3.7: does xmpp still support the <status/> when in muc? In IRC this
	has caused PART spam
     4.1: ex f5: lack of error until when? must wait until receiving 110
	status?
     4.4: presence broadcast before ack? must buffer until receiving 110
	ack?
     4.5.1: use message id instead of guessing?

im:
     table 4: align tables accross documents and put normative version
	to -core.

pres:
     should mention different concepts, long-lived vs short-lived in
	intro, not only in 3.3.2
     3.1: im uri of the form <pres:>?
     3.3.1: if a subscription already exists -> already defined in 6121,
	not sure if this was in 3921 already
     4.3: table 7 CSeq <-> id?! consistency...