[Suit] Manifest-12 review

"Rønningstad, Øyvind" <Oyvind.Ronningstad@nordicsemi.no> Tue, 25 May 2021 12:52 UTC

Return-Path: <Oyvind.Ronningstad@nordicsemi.no>
X-Original-To: suit@ietfa.amsl.com
Delivered-To: suit@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1167F3A1258 for <suit@ietfa.amsl.com>; Tue, 25 May 2021 05:52:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nordicsemi.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aHr4OfbVours for <suit@ietfa.amsl.com>; Tue, 25 May 2021 05:52:30 -0700 (PDT)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2A45D3A1256 for <suit@ietf.org>; Tue, 25 May 2021 05:52:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FjCgbAIdBMLN1NHnyiwAuQS9RUAQuKKml2mPCIu7mBz3NfbmX++flDE51Ifs7mUwBBi02ZoVKctVCfECIRnaKs1LffhroUVS6EWYYzsO7OzIGFnfT2kqF/8im4hAfdCkwhAGaqhRP7C7x0MAvzWg3cJmQxw0QUCBQcGpxtqS6XfEw5S/zQCQ0ZGiY2voiRytTLojG9cap8pa5Ux6eag/UVEagov1A/5w/0HuxpUtm3UJdsD+io3t5C7u9grj/I2R+kM5tc9cT48Ew4BLXM8c0l7jjRg+OSNl229u44g8ia2kroAtFV5q2QYtMoYnQc14P2KkMqyZRDPR7nPxgoJGdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgeWhqpqw/IWkwm9dgk9yaXG3K82tRzSvb79DFyLA6M=; b=laAun+tI4Yq80Ue1oJQMYu95sp404OAmPAJDGcHJFBs+0AmeDmBnQ2S6mfBsUpZf/8lWd9x05n6im84LgOCLkqEApbiIRhIYbxvOUvutFzdoyph0mhdW/EnCSKyMPfJL1SCqKaraiKMwYMMIKf26GMDFeeVZR7rAB//x1Xf6l6nk+s+2I2mfG4GMpjd4WIR1UPmU/kSah3gssAVmMptggyQtR7vm3v6UbKUoQDA7jqffIi3in9sNitJSfQbAiMF819SDR99qE8JPtObE9Vm6glLZGUxfBxx8qfxRm2JW38KI6VhoJ8v6IXjggYXsTo36aOCpM5+xGTzBaFQ2dCRkpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nordicsemi.no; dmarc=pass action=none header.from=nordicsemi.no; dkim=pass header.d=nordicsemi.no; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nordicsemi.onmicrosoft.com; s=selector2-nordicsemi-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgeWhqpqw/IWkwm9dgk9yaXG3K82tRzSvb79DFyLA6M=; b=JOatuITqvu3pRE/QNVGsdZ7y8x9AvndyeMAQ9CNB8HaikztFsQX4VQqCjKv3C/NvDDCJPK+Q+NR58idCByaCYwpilUvvu8iGh7Z0Jol8L/JwARvnA9pv7mFLH7LLSzHbw71hTZDgzKIsVMbGmEVmhWpRKkL4VaG2mfSi9/vzXUk=
Received: from AM9PR05MB7668.eurprd05.prod.outlook.com (2603:10a6:20b:2cc::13) by AM4PR0501MB2673.eurprd05.prod.outlook.com (2603:10a6:200:59::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.27; Tue, 25 May 2021 12:52:26 +0000
Received: from AM9PR05MB7668.eurprd05.prod.outlook.com ([fe80::50f9:55cc:9d13:76d6]) by AM9PR05MB7668.eurprd05.prod.outlook.com ([fe80::50f9:55cc:9d13:76d6%5]) with mapi id 15.20.4150.027; Tue, 25 May 2021 12:52:26 +0000
From: =?iso-8859-1?Q?R=F8nningstad=2C_=D8yvind?= <Oyvind.Ronningstad@nordicsemi.no>
To: suit <suit@ietf.org>
Thread-Topic: Manifest-12 review
Thread-Index: AddRYbRbIvK2zqP7TV6ZcHoP2hFlLw==
Date: Tue, 25 May 2021 12:52:26 +0000
Message-ID: <AM9PR05MB766850A0985F3D66D2BD4C6288259@AM9PR05MB7668.eurprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=nordicsemi.no;
x-originating-ip: [2001:8c0:5140:12:6c12:9b20:652:2f1]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5e290c1b-e19a-42b7-9bb4-08d91f7bf2b8
x-ms-traffictypediagnostic: AM4PR0501MB2673:
x-microsoft-antispam-prvs: <AM4PR0501MB2673EAEBC045379A68A09DF588259@AM4PR0501MB2673.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: nym2UfVOXXf2XhQ+FjUff+QtoweYZt3k1wkfz83zQ9csoxvN8ZFJ6Y72/KxjD/0HD5/fyuMK6GHUMhbWDvmDC+Zwb7jQY3rzTWwx36eIDv48gRaIAj5fcuoiwXzW+BuyETuNVxRmdEEe0vtjLcrh70nABYlakFu9sdCqx1qX/ME5ahEHztgdRvvw/+NjARw0BwmfPuXn58XFOKOb2Ng/v39ovRujSIUbEsY82Bw1/03Q04odolCiTJTTFn69VSQAO3a7wuakBrICzumN2F6x+8gnMsIF7nMClGAzpfZceHAaDXv9VPUZggT9+JVMku1I0N2IbNEurtt/IyIWv6MF7dOsaxsMOSZs4T854mHnGBsgdMDWGEs0dnjmqGKf+J9gbfbtLFewCpCXy6xwM49LJDr3Ny/FMU/2tiBLXJ2n7+UhKT1Dce4jHNezhaYYJG+yuhiJqJ8NKZ6TxXWdmT4PJoEL90Ey9vANUV5UrjKXbMQUtWygTSFjTGJqJD1XzsBuWfcuoWRQhIIfDkOKrcu7xSttaoRJMHRSZ5dkUCqapvV97wtkwoDptaxAWw+6Uq+LeUUzf9jUqwm48PPlxgumn3TFcozPgIjKZIKSDHDP9OX8iHfPWjEmSe8FsV4erIjkRZFSc3t6Z4aR28Ba6gLHXcmpEqzplyBpCBzq9+JRLeyACTk5dG/fEgvJSJvYbi7XO85K0+3grlCzFkJiUXvF/0DW1ZK380na1wppcjoOpPo=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR05MB7668.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39850400004)(366004)(136003)(346002)(396003)(66446008)(64756008)(8676002)(38100700002)(55016002)(66946007)(66556008)(122000001)(66476007)(6916009)(186003)(5660300002)(6506007)(316002)(86362001)(52536014)(9686003)(76116006)(478600001)(8936002)(83380400001)(2906002)(7696005)(966005)(71200400001)(33656002); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?i9r2JGlJiT+YpEd8jPombCRnhX3Uwqwqj5nPDbIWBpOaxjYZB+UJIx611v?= =?iso-8859-1?Q?4dE7ok8lsDt8XPyn1PYZVAmSKpER69Z9ZzGbDusjEcGPmSb6+7JEstfHlW?= =?iso-8859-1?Q?ls+tX0FuW9mUr6KhpICShaNSv8WcapVz1nT7k7zlFayKNzaeiTaddc+SHh?= =?iso-8859-1?Q?Nf+WCPPWuV7eswZtTA/fB8O2hNl+Qn34qfYWNRJNKETp7qyfz7DK3v3Lsd?= =?iso-8859-1?Q?Lewu/LfNqtyyHnYRbLY6RnmaiOEcogHETFX+hJHbYRBlTqSiEBbLsr8p3k?= =?iso-8859-1?Q?3PTtmM27WawXL4qIvcD/ZNp/0DZW0VPlWUM3VsOwRf4JjwxG2xwIjdcv16?= =?iso-8859-1?Q?erl+Y0ZzAWEwRWOcV/5DlrotiKzjlgfB5BSPBGKYPj0Y7xvszSRlL6KXKB?= =?iso-8859-1?Q?MFdwdHjbP8MJcS+08okErw7CRvnTIMWgRCsKi0So99r1uBnL+T516o3Qav?= =?iso-8859-1?Q?LcWnWaO99ruDHCp8Ow9py5fIc2GC+ew5VzH7W34JB2Wzo/tj0DYJMV14wG?= =?iso-8859-1?Q?vZmMctr8kz2cq0iIhTx8pVnLuZtoeLM07S8MLXH6AgkyLLwNifB0YPyOpO?= =?iso-8859-1?Q?EKW+/ky+4OzVL/iFl/DnP2z5T/KO1uwdFG75Yt+mM28y5Y5840CRX4/QzI?= =?iso-8859-1?Q?eT7czUiN6E4XJDC+TvFJED7o3r6GWhFT4V7m5ZhypU7bEfAQWd7Pbggt/x?= =?iso-8859-1?Q?IVMBinBmqucNoz+9CrzJVteKuISrHOFYeehrSH2v9eODzuWO0fH5b12b/X?= =?iso-8859-1?Q?3O5XGNk04EQdErys6NUW4JPbxWWz2Hp+PW4wv9ow/mh3rnsY6C/d+JkwSv?= =?iso-8859-1?Q?JMqCTDE+Lmf6+VePjBmlju0zMpA5C5Z0xj/oRt1/TbMAE2qXuGArGwunem?= =?iso-8859-1?Q?PuccD8tVrYT2r9dsJQWDSV4DHt55gHvEOhP8yuQYzCJSevR8gQGTqG9jd5?= =?iso-8859-1?Q?QqKKNVypcc9aWZ8WOeTkJY7Yuc07/cSjdHQEcBhMA8cbDMCVt7XDTJdXFp?= =?iso-8859-1?Q?8yi5JUm0a90HLJ3xZCr0Lh/FQ64lKicO9P1KWBi99+ArWFXzYRxxr844Oy?= =?iso-8859-1?Q?CQ1NNHTKgWZYYXLRurDEPHEUSmlyOZNhqT06RstayVvRjAFGi6NV41Z3fW?= =?iso-8859-1?Q?sIR6y8RDqrF8PLsjXNPup97rtKoAxHkACYRwy2Qpz7n29NwVli1OMk2Rk9?= =?iso-8859-1?Q?NZlkVjfO3wxBwtdNAOpt7E6Z1u1MMp/wnt2GlCHPhYo7IbkYMSZyp+1Dff?= =?iso-8859-1?Q?FsoGyUmWoxyZkX7e0bQBRMn2+CpVlDOgzLd5oPc9A28ZAIIBuiOuwbQoDp?= =?iso-8859-1?Q?GxsRqmXwYAL72KGVX8X2lQFKB5bvlsIYift1e2auol76e5w+T1hdddJuka?= =?iso-8859-1?Q?mq5d6xvrBkBsk+JQk6uexzGIgp8NNfOfT5w2q5yWjJnhIql87FIlQ=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nordicsemi.no
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR05MB7668.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e290c1b-e19a-42b7-9bb4-08d91f7bf2b8
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2021 12:52:26.1905 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 28e5afa2-bf6f-419a-8cf6-b31c6e9e5e8d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YX8XNkHAhJcmCcukWilUnyDt05rwDC3KN/BF66MBxBXAK+GCHmMNyo1ZSoV07KtWWnW6C29fGSHgOIYSBK4A3SafmCAevSB2k4JhhSNxRXoDC2mROK8siIOJTAyUgLNk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2673
Archived-At: <https://mailarchive.ietf.org/arch/msg/suit/EFE31WP1qyISKDYuE7KLmwrCSIw>
Subject: [Suit] Manifest-12 review
X-BeenThere: suit@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Software Updates for Internet of Things <suit.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/suit>, <mailto:suit-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/suit/>
List-Post: <mailto:suit@ietf.org>
List-Help: <mailto:suit-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/suit>, <mailto:suit-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 May 2021 12:52:34 -0000

Hi everyone

I collected some nits in a PR here: https://github.com/suit-wg/manifest-spec/pull/33

Additionally:

. I think integrated payloads / dependencies should be referenced by Component Identifier rather than URI, so they can be used in copy/validate/etc commands. As it is now, they can in principle only be referenced by component identifier after a fetch command which would mean a superfluous copy operation. This is unless fetch is specifically defined as a noop for integrated payloads and dependencies.
. Should there be a suit-future-reference-uri-list in parallel with suit-reference-uri that specifies where to find updates to the current manifest itself?
. I realized I never replied to Brendan's breakdown of my previous review (-07), but it was all fine, except one thing that is still unclear to me: I still do not quite understand what the "offset of the current component" in 8.7.6.5 refers to? "Who" manages this offset? What causes a component's offset to be updated? When, if ever, is the offset "reset"?
. Links from tables in htmlized output are sometimes truncated (part of the chapter number is lost leading to wrong links). e.g. suit-directive-set-component-index can be found at Section 8.7.7.1, but the link goes to Section 8.7.

See you in a few hours,
Øyvind