[Suit] draft-ietf-suit-manifest-12

Russ Housley <housley@vigilsec.com> Wed, 03 March 2021 21:50 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: suit@ietfa.amsl.com
Delivered-To: suit@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 41C0C3A1BCA for <suit@ietfa.amsl.com>; Wed, 3 Mar 2021 13:50:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oPbaWXbkiVpG for <suit@ietfa.amsl.com>; Wed, 3 Mar 2021 13:50:31 -0800 (PST)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 792B73A1BC8 for <suit@ietf.org>; Wed, 3 Mar 2021 13:50:31 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 443D1300B5D for <suit@ietf.org>; Wed, 3 Mar 2021 16:50:29 -0500 (EST)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0jpz0K_lHhnD for <suit@ietf.org>; Wed, 3 Mar 2021 16:50:27 -0500 (EST)
Received: from [192.168.1.161] (pool-141-156-161-153.washdc.fios.verizon.net [141.156.161.153]) by mail.smeinc.net (Postfix) with ESMTPSA id 7C5DE3001A8 for <suit@ietf.org>; Wed, 3 Mar 2021 16:50:27 -0500 (EST)
From: Russ Housley <housley@vigilsec.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
Date: Wed, 03 Mar 2021 16:50:27 -0500
References: <161402996821.6250.13411464878955966398@ietfa.amsl.com>
To: suit <suit@ietf.org>
In-Reply-To: <161402996821.6250.13411464878955966398@ietfa.amsl.com>
Message-Id: <064D8533-38F9-47E0-A6C1-046D12299B6C@vigilsec.com>
X-Mailer: Apple Mail (2.3445.104.17)
Archived-At: <https://mailarchive.ietf.org/arch/msg/suit/J8H8D-esw79-43lc_DX0G1Kp4jI>
Subject: [Suit] draft-ietf-suit-manifest-12
X-BeenThere: suit@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Software Updates for Internet of Things <suit.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/suit>, <mailto:suit-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/suit/>
List-Post: <mailto:suit@ietf.org>
List-Help: <mailto:suit-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/suit>, <mailto:suit-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Mar 2021 21:50:34 -0000

I did a quick review of draft-ietf-suit-manifest-12.  These are the things I noticed.


TECHNICAL SUGGESTIONS

I think that Section 8.7.5.1 should point to draft-ietf-cbor-tags-oid and it should use TBD112 (tag 111).

We talked about mandatory to support signature verification algorithms, but there is not a section about it.


EDITORIAL

In several big tables, using "Section" instead of "Reference" as the column heading would make the text fit on one line.

In Section 8.7.5.2, two numbered lists are formatted in a hard to read manner.

In Section 13, please fix "Krzysztof Chru&#347;ci&#324;ski"

Russ


> On Feb 22, 2021, at 4:39 PM, internet-drafts@ietf.org wrote:
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Software Updates for Internet of Things WG of the IETF.
> 
>        Title           : A Concise Binary Object Representation (CBOR)-based Serialization Format for the Software Updates for Internet of Things (SUIT) Manifest
>        Authors         : Brendan Moran
>                          Hannes Tschofenig
>                          Henk Birkholz
>                          Koen Zandberg
> 	Filename        : draft-ietf-suit-manifest-12.txt
> 	Pages           : 111
> 	Date            : 2021-02-22
> 
> Abstract:
>   This specification describes the format of a manifest.  A manifest is
>   a bundle of metadata about code/data obtained by a recipient (chiefly
>   the firmware for an IoT device), where to find the that code/data,
>   the devices to which it applies, and cryptographic information
>   protecting the manifest.  Software updates and Trusted Invocation
>   both tend to use sequences of common operations, so the manifest
>   encodes those sequences of operations, rather than declaring the
>   metadata.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-suit-manifest/
> 
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-suit-manifest-12
> https://datatracker.ietf.org/doc/html/draft-ietf-suit-manifest-12
> 
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-suit-manifest-12
> 
> 
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
> 
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/