Re: [Suit] architecture draft -v15

Michael Richardson <mcr+ietf@sandelman.ca> Tue, 19 January 2021 18:39 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: suit@ietfa.amsl.com
Delivered-To: suit@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0870F3A16AF for <suit@ietfa.amsl.com>; Tue, 19 Jan 2021 10:39:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.162
X-Spam-Level:
X-Spam-Status: No, score=-2.162 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.262, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VoGPMbiTssu7 for <suit@ietfa.amsl.com>; Tue, 19 Jan 2021 10:39:18 -0800 (PST)
Received: from tuna.sandelman.ca (tuna.sandelman.ca [209.87.249.19]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4EE33A16AB for <suit@ietf.org>; Tue, 19 Jan 2021 10:39:17 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by tuna.sandelman.ca (Postfix) with ESMTP id 17DC138B89 for <suit@ietf.org>; Tue, 19 Jan 2021 13:41:12 -0500 (EST)
Received: from tuna.sandelman.ca ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pkF6O_C6enLv for <suit@ietf.org>; Tue, 19 Jan 2021 13:41:10 -0500 (EST)
Received: from sandelman.ca (obiwan.sandelman.ca [IPv6:2607:f0b0:f:2::247]) by tuna.sandelman.ca (Postfix) with ESMTP id B66F238B83 for <suit@ietf.org>; Tue, 19 Jan 2021 13:41:10 -0500 (EST)
Received: from [IPv6:::1] (localhost [IPv6:::1]) by sandelman.ca (Postfix) with ESMTP id E6A4EE3 for <suit@ietf.org>; Tue, 19 Jan 2021 13:39:14 -0500 (EST)
To: suit@ietf.org
References: <AM0PR08MB37160310E8C190E0343123D7FAA40@AM0PR08MB3716.eurprd08.prod.outlook.com>
From: Michael Richardson <mcr+ietf@sandelman.ca>
Message-ID: <63688e32-6fb6-ae67-ff52-02f2f863f20e@sandelman.ca>
Date: Tue, 19 Jan 2021 13:39:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <AM0PR08MB37160310E8C190E0343123D7FAA40@AM0PR08MB3716.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/suit/WovRld9LnrYS-7dWOJ48zBYv0B0>
Subject: Re: [Suit] architecture draft -v15
X-BeenThere: suit@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Software Updates for Internet of Things <suit.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/suit>, <mailto:suit-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/suit/>
List-Post: <mailto:suit@ietf.org>
List-Help: <mailto:suit-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/suit>, <mailto:suit-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jan 2021 18:39:21 -0000

On 2021-01-18 1:42 a.m., Hannes Tschofenig wrote:
> Hi all,
> 
> I have just submitted version 15 of the architecture draft. This version 
> includes the review from the IESG and from various directorates.
> 
> Reviewers requested a lot of clarifications and hence the draft changed 
> quite a bit (on the editorial side). Here is the diff:

Yes, it did.  The change in the table of contents alone made me re-read 
it from the beginning rather than just the diff.

I found a number of places where the wording was poor due to grammar, 
and I'm trying to send that as a pull request since it does not affect 
the (intended) meaning.   I think you forgot to commit/push your -15 to 
github though.

Figure 5 and 6 are long and have some unfortunate page breaks.
I think that you could squeeze a few filler lines out of figure 6,
and perhaps when going to PDF, it will be fine.  We aren't doing page 
breaks in text RFCs, so it likely isn't as important.

Figure 5 is rather long though, and I suggest that you might want to 
split it up into two figures, repeating the 
author/firmware-server/consumer/bootloader headings.
I suggest splitting it at "Request Firmware", repeating "Request 
Firmware"/"Send Firmware" at the bottom of one diagram and the top of 
the other.  That split also means the second time-sequence does not need 
"Author" heading at all.

I can tell that you did a lot of work based upon the reviews, it all 
seems great. Thank you.