Return-Path: <Oyvind.Ronningstad@nordicsemi.no>
X-Original-To: suit@ietfa.amsl.com
Delivered-To: suit@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 00A2A130DF9
 for <suit@ietfa.amsl.com>; Wed,  4 Jul 2018 01:26:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level: 
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, 
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001]
 autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=nordicsemi.no
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id UJzfnal7b_a4 for <suit@ietfa.amsl.com>;
 Wed,  4 Jul 2018 01:26:29 -0700 (PDT)
Received: from ironport01.nordicsemi.no (mx01.nordicsemi.no [194.19.86.146])
 (using TLSv1.2 with cipher RC4-SHA (128/128 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id A39B912426A
 for <suit@ietf.org>; Wed,  4 Jul 2018 01:26:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=nordicsemi.no; l=10407; s=default; t=1530692788;
 h=from:to:subject:date:message-id:mime-version;
 bh=/kb0sUNLKC4amhsjB4Mgxalp1xm8fmFsuPMk0BwON38=;
 b=cPE/YFYE8PTl939L8LtNurXUmBUSpdYuYeI1LcGBqNLEoWqkvout/45p
 /ub0DYrz6y8AWmi2iIN07ZP2kkmojEoy+lr8f4CALUni8nVoJVArM3Een
 lEMh2oBrnA8Sp2eYlUOPRUxuKUvQL2uQDds8YfVBbt5SKXE7D82WRwViE 8=;
X-IronPort-AV: E=Sophos; i="5.51,306,1526335200"; d="scan'208,217";
 a="11226791"
From: =?iso-8859-1?Q?R=F8nningstad=2C_=D8yvind?=
 <Oyvind.Ronningstad@nordicsemi.no>
To: suit <suit@ietf.org>
Thread-Topic: draft-moran-suit-manifest-02
Thread-Index: AdQTbk+t1KsTGeClRXioTvYSJXY/hw==
Date: Wed, 4 Jul 2018 08:26:25 +0000
Message-ID: <edc46af214244a119950582014c8dbfe@nordicsemi.no>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [192.9.200.83]
Content-Type: multipart/alternative;
 boundary="_000_edc46af214244a119950582014c8dbfenordicsemino_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/suit/dE14TlmMDmb7SCYfOdn4uB7OHlg>
Subject: [Suit] draft-moran-suit-manifest-02
X-BeenThere: suit@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Software Updates for Internet of Things <suit.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/suit>,
 <mailto:suit-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/suit/>
List-Post: <mailto:suit@ietf.org>
List-Help: <mailto:suit-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/suit>,
 <mailto:suit-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2018 08:26:33 -0000

--_000_edc46af214244a119950582014c8dbfenordicsemino_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Thanks Brendan (and Hannes) for all your great work on the documents.

I have some of questions and comments regarding the manifest format:


  *   I'm still not 100% sure of the intended difference between extensions=
 and directives, can you put a sentence into the document?
  *   No element has more than one inode or onode. How would "one resource =
may be used by multiple processors" work?
  *   If a processing step or target takes multiple input resources (I assu=
me this happens when they all specify the same onode), how does the process=
 know which resource is which (which blob is the compression table, and whi=
ch is the data)? I.e. how is the order of arguments decided?
  *   What does it mean for a Target to be an alias (I'm referring to the c=
omment on Target::encoding: "the format of the resource (nil when alias)")?
  *   Can dependency resources serve as input to processors or targets? If =
so, what data does the dependency resource provide as input to that process=
or or target? If not, what should the onode value be?
  *   CDDL nitpicking:
     *   Some name inconsistencies: ProcessingStep vs Processor, TargetInfo=
 vs Target.
     *   There's probably a typo in the definition of Directive. Should it =
be an array of maps?
     *   Target::storageIdentifier and Target::componentIdentifier don't us=
e the custom types for StorageIdentifier and ComponentIdentifier.
     *   I think digests should have a type, so the user can more easily re=
strict its format after choosing a digest algorithm.
     *   Suggestion: Add nint to textKeys group.
     *   AuthenticatedManifest should probably contain an authenticatedMani=
festVersion or similar.
     *   "Processor" might be confusing ("does it mean CPU?").

=D8yvind


--_000_edc46af214244a119950582014c8dbfenordicsemino_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:=
//www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:Wingdings;
	panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin-top:0cm;
	margin-right:0cm;
	margin-bottom:0cm;
	margin-left:17.85pt;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;
	mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
	{mso-style-priority:34;
	margin-top:0cm;
	margin-right:0cm;
	margin-bottom:0cm;
	margin-left:36.0pt;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;
	mso-fareast-language:EN-US;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	mso-fareast-language:EN-US;}
.MsoPapDefault
	{mso-style-type:export-only;
	margin-left:17.85pt;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
	{page:WordSection1;}
/* List Definitions */
@list l0
	{mso-list-id:1773889417;
	mso-list-type:hybrid;
	mso-list-template-ids:-2136157150 68419585 68419587 68419589 68419585 6841=
9587 68419589 68419585 68419587 68419589;}
@list l0:level1
	{mso-level-number-format:bullet;
	mso-level-text:\F0B7;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-18.0pt;
	font-family:Symbol;}
@list l0:level2
	{mso-level-number-format:bullet;
	mso-level-text:o;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-18.0pt;
	font-family:"Courier New";}
@list l0:level3
	{mso-level-number-format:bullet;
	mso-level-text:\F0A7;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-18.0pt;
	font-family:Wingdings;}
@list l0:level4
	{mso-level-number-format:bullet;
	mso-level-text:\F0B7;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-18.0pt;
	font-family:Symbol;}
@list l0:level5
	{mso-level-number-format:bullet;
	mso-level-text:o;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-18.0pt;
	font-family:"Courier New";}
@list l0:level6
	{mso-level-number-format:bullet;
	mso-level-text:\F0A7;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-18.0pt;
	font-family:Wingdings;}
@list l0:level7
	{mso-level-number-format:bullet;
	mso-level-text:\F0B7;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-18.0pt;
	font-family:Symbol;}
@list l0:level8
	{mso-level-number-format:bullet;
	mso-level-text:o;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-18.0pt;
	font-family:"Courier New";}
@list l0:level9
	{mso-level-number-format:bullet;
	mso-level-text:\F0A7;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-18.0pt;
	font-family:Wingdings;}
ol
	{margin-bottom:0cm;}
ul
	{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=3D"NO-BOK" link=3D"#0563C1" vlink=3D"#954F72">
<div class=3D"WordSection1">
<p class=3D"MsoNormal" style=3D"margin-left:0cm"><span lang=3D"EN-US">Thank=
s Brendan (and Hannes) for all your great work on the documents.<o:p></o:p>=
</span></p>
<p class=3D"MsoNormal" style=3D"margin-left:0cm"><span lang=3D"EN-US"><o:p>=
&nbsp;</o:p></span></p>
<p class=3D"MsoNormal" style=3D"margin-left:0cm"><span lang=3D"EN-US">I hav=
e some of questions and comments regarding the manifest format:<o:p></o:p><=
/span></p>
<p class=3D"MsoNormal" style=3D"margin-left:0cm"><span lang=3D"EN-US"><o:p>=
&nbsp;</o:p></span></p>
<ul style=3D"margin-top:0cm" type=3D"disc">
<li class=3D"MsoListParagraph" style=3D"margin-left:0cm;mso-list:l0 level1 =
lfo1"><span lang=3D"EN-US">I'm still not 100% sure of the intended differen=
ce between extensions and directives, can you put a sentence into the docum=
ent?<o:p></o:p></span></li><li class=3D"MsoListParagraph" style=3D"margin-l=
eft:0cm;mso-list:l0 level1 lfo1"><span lang=3D"EN-US">No element has more t=
han one inode or onode. How would &quot;one resource may be used by multipl=
e processors&quot; work?<o:p></o:p></span></li><li class=3D"MsoListParagrap=
h" style=3D"margin-left:0cm;mso-list:l0 level1 lfo1"><span lang=3D"EN-US">I=
f a processing step or target takes multiple input resources (I assume this=
 happens when they all specify the same onode), how does the process know w=
hich resource
 is which (which blob is the compression table, and which is the data)? I.e=
. how is the order of arguments decided?<o:p></o:p></span></li><li class=3D=
"MsoListParagraph" style=3D"margin-left:0cm;mso-list:l0 level1 lfo1"><span =
lang=3D"EN-US">What does it mean for a Target to be an alias (I'm referring=
 to the comment on Target::encoding: &quot;the format of the resource (nil =
when alias)&quot;)?<o:p></o:p></span></li><li class=3D"MsoListParagraph" st=
yle=3D"margin-left:0cm;mso-list:l0 level1 lfo1"><span lang=3D"EN-US">Can de=
pendency resources serve as input to processors or targets? If so, what dat=
a does the dependency resource provide as input to that processor or target=
? If
 not, what should the onode value be?<o:p></o:p></span></li><li class=3D"Ms=
oListParagraph" style=3D"margin-left:0cm;mso-list:l0 level1 lfo1"><span lan=
g=3D"EN-US">CDDL nitpicking:<o:p></o:p></span>
<ul style=3D"margin-top:0cm" type=3D"circle">
<li class=3D"MsoListParagraph" style=3D"margin-left:0cm;mso-list:l0 level2 =
lfo1"><span lang=3D"EN-US">Some name inconsistencies: ProcessingStep vs Pro=
cessor, TargetInfo vs Target.<o:p></o:p></span></li><li class=3D"MsoListPar=
agraph" style=3D"margin-left:0cm;mso-list:l0 level2 lfo1"><span lang=3D"EN-=
US">There's probably a typo in the definition of Directive. Should it be an=
 array of maps?<o:p></o:p></span></li><li class=3D"MsoListParagraph" style=
=3D"margin-left:0cm;mso-list:l0 level2 lfo1"><span lang=3D"EN-US">Target::s=
torageIdentifier and Target::componentIdentifier don't use the custom types=
 for StorageIdentifier and ComponentIdentifier.<o:p></o:p></span></li><li c=
lass=3D"MsoListParagraph" style=3D"margin-left:0cm;mso-list:l0 level2 lfo1"=
><span lang=3D"EN-US">I think digests should have a type, so the user can m=
ore easily restrict its format after choosing a digest algorithm.<o:p></o:p=
></span></li><li class=3D"MsoListParagraph" style=3D"margin-left:0cm;mso-li=
st:l0 level2 lfo1"><span lang=3D"EN-US">Suggestion: Add nint to textKeys gr=
oup.<o:p></o:p></span></li><li class=3D"MsoListParagraph" style=3D"margin-l=
eft:0cm;mso-list:l0 level2 lfo1"><span lang=3D"EN-US">AuthenticatedManifest=
 should probably contain an authenticatedManifestVersion or similar.<o:p></=
o:p></span></li><li class=3D"MsoListParagraph" style=3D"margin-left:0cm;mso=
-list:l0 level2 lfo1"><span lang=3D"EN-US">&quot;Processor&quot; might be c=
onfusing (&#8220;does it mean CPU?&#8221;).<o:p></o:p></span></li></ul>
</li></ul>
<p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoNormal" style=3D"margin-left:0cm"><span lang=3D"EN-US" style=
=3D"mso-fareast-language:NO-BOK">=D8yvind<o:p></o:p></span></p>
<p class=3D"MsoNormal"><span lang=3D"EN-US"><o:p>&nbsp;</o:p></span></p>
</div>
</body>
</html>

--_000_edc46af214244a119950582014c8dbfenordicsemino_--

