Re: [tap] Valids subtests (was: RFC Status?)

["Bruno P. Kinoshita" <[e-mail]>]

Thanks Ovid!

Probably when we start discussing subtests I'll chip in with many questions. As, am I allowed to have subtests before and after test results?

1..2
ok 1 - foo
    not ok 1 - some text

ok 2 - bar passed
    not ok 1 - another text


1..2
    not ok 1 - some text

ok 1 - foo
    not ok 1 - another text

ok 2 - bar passed
    not ok 1 - another text

Because my first guess was that subtests would always come after test elements, and be linked to the previous element. 

Thanks again
Bruno


>________________________________
> From: Ovid <[e-mail]>
>To: Bruno P. Kinoshita <[e-mail]> 
>Cc: "[e-mail]" <[e-mail]> 
>Sent: Wednesday, September 17, 2014 4:40 PM
>Subject: Re: Valids subtests (was: [tap] RFC Status?)
> 
>
>
>Bruno,
>
>
>Yes, those are perfectly valid subtests. I, like an idiot, forgot to show the subtest plans in my examples. 
> 
>Best,
>Ovid
>--
>IT consulting, training, international recruiting
>       http://www.allaroundtheworld.fr/.
>Buy my book! - http://bit.ly/beginning_perl
>Live and work overseas -
 http://www.overseas-exile.com/
>
>
>
>On Wednesday, 17 September 2014, 21:16, Bruno P. Kinoshita <[e-mail]> wrote:
> 
>
>>
>>
>>Ovid, 
>>
>>
>>Would a subtest as follows be valid?
>>
>>
>>    ok 1 - subtest 1a
>>    ok 2 - subtest 1b
>>    1..2
>>ok 1 - Subtest 1
>>    ok 1 - subtest 2a
>>    ok 2 - subtest 2b
>>    1..2
>>ok 2 - Subtest 2
>>1..2
>>ok
>>
>>
>>A user posted this TAP stream generated with Test::More to tap4j [1]. I'll probably end up writing a custom parser for it to support streams generated by Perl tools, but I'd like to know whether it would be considered valid or not.
>>
>>
>>TIA
>>Bruno
>>
>>
>>
>>
>>[1] https://github.com/tupilabs/tap4j/issues/15
>>
>>
>>
>>
>>
>>>________________________________
>>> From: Ovid <[e-mail]>
>>>To: Leon Timmermans <[e-mail]>; Andrew de Andrade <[e-mail]> 
>>>Cc: "[e-mail]" <[e-mail]> 
>>>Sent: Wednesday, September 17, 2014 4:08 PM
>>>Subject: Re: [tap] RFC Status?
>>> 
>>>
>>>
>>>A few notes on this.
>>>
>>>
>>>For subtests, they are indented four spaces. Always four spaces. If they are indented eight spaces, you know they're a subtest of a subtest (assuming there's an intervening subtest. That means this is valid TAP, but there is no subtest because it's indented too far:
>>>ok 1 - foo
>>>>        ok 1 - bar indented too far
>>>>ok 2 - bar passed
>>>The "ok 1 - bar" line would be discarded as "unknown". 
>>>
>>>
>>>So if, in a stream of TAP, you find something which would be valid tap if it were unindented by four spaces, it's a subtest. The trailing, unindented summary line must mirror the status of the subtest. Thus, the following is invalid:
>>>
>>>
>>>ok 1 - foo
>>>>    not ok 1 - bar indented too far
>>>>ok 2 - bar passed
>>>>
>>>>Currently, Test::Harness treats the above as passing when it should not. I believe Schwern filed a bug for that. I know Andy Armstrong and I both took a quick swing at extending Test::Harness but discovered that it was more difficult than it appeared.
>>>
>>>
>>>The grammar would be modified to look sort of like this (modifying http://search.cpan.org/dist/Test-Harness/lib/TAP/Parser/Grammar.pm):
>>>
>>>line           ::= (comment | test | subtest | unknown | bailout ) "\n"
>>>>subtest        ::= subtest_line { subtest_line } test
>>>>subtest_line   ::= '    ' line
>>>That assumes we're OK with a recursive grammar. Also, the grammar doesn't really have a way of identifying the semantics of the trailing line on the subtest grammar line.
>>>
>>>
>>>If you have other questions about subtests, I think I can give definitive answers.
>>>
>>>
>>>As for the YAMLish structured diagnostics, those were never official, as far as I recall. There were several disputes, one of which was whether or not we should use YAML or JSON (I recall even XML being mentioned). Some argued that any structured diagnostic should be allowed, but I reject that firmly because that makes life hell for the parser. If you asked me what my stance is today, I would think that structured diagnostics should valid JSON, but that raises questions about whitespace issues, UTF-8, and so on. If we could agree on the format, then we'd need to agree on the keys in the structured diagnostic dictionary (and how to extend them).
>>>
>>>
>>>Best,
>>>Ovid
>>>--
>>>IT consulting, training, international recruiting
>>>       http://www.allaroundtheworld.fr/.
>>>Buy
 my book! - http://bit.ly/beginning_perl
>>>Live and work overseas -
 http://www.overseas-exile.com/
>>>
>>>
>>>
>>>On Wednesday, 17 September 2014, 20:07, Leon Timmermans <[e-mail]> wrote:
>>> 
>>>
>>>>
>>>>
>>>>On Mon, Aug 11, 2014 at 8:42 PM, Andrew de Andrade <[e-mail]> wrote:
>>>>
>>>>I'm working on some testing libraries for JavaScript based on TAP. Specifically, I'm trying to explore making it possible for library authors to not only check the results of their TAP tests, but also map-reduce the TAP results of the dependents of their library to see how changes to their library impact the correctness of their dependents. 
>>>>>
>>>>>
>>>>>e.g. I am the author of library A. I publish version 0.1.0. Another author includes my library as a dependency in library B and in library C and uses TAP to test those libraries. Given this scenario, it would be nice if I could, when modifying my library, run not only my tests, but also run the tests of all my dependents built with my previous version and my current version and compare how my changes impacted the "correctness" of their programs. 
>>>>>
>>>>>
>>>>>Beyond the benefits to a community, helping authors know when they can likely safely upgrade their deps, this type of runner would also help in an corporate environment with lots of code re-use between teams. 
>>>>>
>>>>>
>>>>>While thinking about this, I decided to go out and figure out if there is such a thing as nested TAP in the protocol specification. While searching for this, I came across this group, which is a great, but it appears there has been no activity here in a while and it looks like all the wiki pages with prior information about the state of the TAP protocol becoming an IETF RFC have disappeared. 
>>>>>
>>>>>
>>>>>What's the current state of TAP? Is there still interest in taking this to RFC status? I found some previous discussions on the list about nested TAP. Did those make it into the specification in any way? If so, where can I find examples of correct nested tap results?
>>>>>
>>>>>
>>>>>Furthermore, is there a standardized set of test fixtures for the current version that any implementation can be tested against for correctness and performance? Having worked a bit with JSON schema, I found that one of the most useful tools was a standardized set of tests to check if a particular implementation conforms to the protocol standard. (see: https://github.com/json-schema/JSON-Schema-Test-Suite )
>>>>>
>>>>>
>>>>I've been recently writing a TAP Harness, and for subtests I followed what Perl has been doing for years (just like TAP::Stream): have indented subtests follow by a non-indented summary line. None of this is described in detail anywhere though :-/, nor is the interaction with the barely defined YAMLish well-explored AFAIK.
>>>>
>>>>Leon
>>>>
>>>>
>>>>_______________________________________________
>>>>tap mailing list
>>>>[e-mail]
>>>>https://www.ietf.org/mailman/listinfo/tap
>>>>
>>>>
>>>>
>>>
>>>_______________________________________________
>>>tap mailing list
>>>[e-mail]
>>>https://www.ietf.org/mailman/listinfo/tap
>>>
>>>
>>>
>>
>>
>
>