Re: [tap] Wakey wakey

[Ovid <[e-mail]>]

--- On Tue, 2/3/10, Salve J Nilsen <[e-mail]> wrote:

> From: Salve J Nilsen <[e-mail]>

>   http://github.com/gaurav/test-anything-protocol/blob/master/draft-vaidya-test-anything-protocol-00.xml

First off, I think this is great work.  However, there are a few things I would like to point out.

1.  I assume the fact that it doesn't mention nested TAP is considered a feature?  Some of the descriptions are incorrect for nested TAP (e.g., only one plan -- unless it's made clear the plan is left-justified for its scope).

2.  Speaking of left-justified, I admit to not being overly familiar with ABNF and could be wrong, but it doesn't make it clear that the lines must left-justified.  This has significant implications for nested TAP.

3.  Plan TODO:

  Plan-Todo = Plan-Simple "todo" 1*(SP Test-Number) ";"

Wasn't that obsoleted?  No one uses it (that I'm aware of) and it turns out to be very fragile (though, annoyingly, it appears that TAP::Parser still supports this).

4.  There appears to be some inconsistency in skip and todo casing.  Specifically, they're case insensitive.  # TodO is annoying, but acceptable.

5.  Whitespace:

  Test-Result = Status [SP Test-Number] [SP Description]
                  [SP "#" SP Directive [SP Reason]] EOL

According to the ABNF spec (http://tools.ietf.org/html/rfc5234#appendix-B.1), SP is %x20 -- a single space.  Multiple spaces (sometimes no spaces) are allowed in various spots. I would suggest reading TAP::Parser::Grammar code. It indicates this and shows many examples of real-world fixes put in there.

http://cpansearch.perl.org/src/ANDYA/TAP-Parser-0.54/lib/TAP/Parser/Grammar.pm

The following is legal TAP, but doesn't match the spec:

  1..3
  ok 1
  not ok 2 #ToDo asdf
  ok 3 #    skIp

Cheers,
Ovid
--
Buy the book         - http://www.oreilly.com/catalog/perlhks/
Tech blog            - http://use.perl.org/~Ovid/journal/
Twitter              - http://twitter.com/OvidPerl
Official Perl 6 Wiki - http://www.perlfoundation.org/perl6