[Taps] YANG updates

"Holland, Jake" <jholland@akamai.com> Mon, 23 September 2019 17:17 UTC

Return-Path: <jholland@akamai.com>
X-Original-To: taps@ietfa.amsl.com
Delivered-To: taps@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 438B41200F4 for <taps@ietfa.amsl.com>; Mon, 23 Sep 2019 10:17:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=akamai.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I0EL3l5UNDA0 for <taps@ietfa.amsl.com>; Mon, 23 Sep 2019 10:17:39 -0700 (PDT)
Received: from mx0b-00190b01.pphosted.com (mx0b-00190b01.pphosted.com [IPv6:2620:100:9005:57f::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 34834120025 for <taps@ietf.org>; Mon, 23 Sep 2019 10:17:39 -0700 (PDT)
Received: from pps.filterd (m0122331.ppops.net [127.0.0.1]) by mx0b-00190b01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8NH1lea014484 for <taps@ietf.org>; Mon, 23 Sep 2019 18:17:37 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; h=from : to : subject : date : message-id : content-type : content-id : content-transfer-encoding : mime-version; s=jan2016.eng; bh=IL2/AdsjVD/YqfeI9w+/pa6D4RegB08/AWJnL2+1Q1I=; b=RVouxRsl4TGk4ij6XxE8TEnnf6w41U5+SSEf/zDt/wwoyf2kAZAq4ej5a36Z7Ox7bZEw NwPupmrgy9TwVcHgNA72bRHyctZylzNhxm1jR00db/+04QXvtttHX6Cbv/1+p+V+DZEp End0A2OS0XmI/a++wq+57PRtE9A6RK6TrCq5LsmOJOaE8tOhFpRqvBSUm1QQOwZpctAt PVOLYHY84cXBoveIZpTpRD0sYZY6k4nnan94rtKSPzmmT9iXspSefpryksydkM1wyVic jYgkSrhU8I0hepQ+7pBItXxhC4xdOYgIIZjfsOYZ8pNY8b5T3u+eaCo2OddyzBTT2bdc 2g==
Received: from prod-mail-ppoint8 (prod-mail-ppoint8.akamai.com [96.6.114.122] (may be forged)) by mx0b-00190b01.pphosted.com with ESMTP id 2v58qthnhb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <taps@ietf.org>; Mon, 23 Sep 2019 18:17:37 +0100
Received: from pps.filterd (prod-mail-ppoint8.akamai.com [127.0.0.1]) by prod-mail-ppoint8.akamai.com (8.16.0.27/8.16.0.27) with SMTP id x8NH4ceT032082 for <taps@ietf.org>; Mon, 23 Sep 2019 13:17:36 -0400
Received: from email.msg.corp.akamai.com ([172.27.27.21]) by prod-mail-ppoint8.akamai.com with ESMTP id 2v5f6xeh9a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for <taps@ietf.org>; Mon, 23 Sep 2019 13:17:36 -0400
Received: from USTX2EX-DAG1MB4.msg.corp.akamai.com (172.27.27.104) by ustx2ex-dag1mb3.msg.corp.akamai.com (172.27.27.103) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Sep 2019 12:16:44 -0500
Received: from USTX2EX-DAG1MB4.msg.corp.akamai.com ([172.27.6.134]) by ustx2ex-dag1mb4.msg.corp.akamai.com ([172.27.6.134]) with mapi id 15.00.1473.005; Mon, 23 Sep 2019 12:16:44 -0500
From: "Holland, Jake" <jholland@akamai.com>
To: "taps@ietf.org" <taps@ietf.org>
Thread-Topic: YANG updates
Thread-Index: AQHVcjKsERfqI9tViU2VYiHjV9QgGQ==
Date: Mon, 23 Sep 2019 17:16:44 +0000
Message-ID: <BB19AC36-ED37-4B6F-B732-A1DB78B8F777@akamai.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1d.0.190908
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [172.19.112.174]
Content-Type: text/plain; charset="utf-8"
Content-ID: <C7C9D7C45B082E4A952A94FF79E12380@akamai.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-09-23_05:, , signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1909230155
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-09-23_05:2019-09-23,2019-09-23 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 malwarescore=0 lowpriorityscore=0 clxscore=1011 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1909230155
Archived-At: <https://mailarchive.ietf.org/arch/msg/taps/WJlZelE_qcQtYfwz06nKQAcefvo>
Subject: [Taps] YANG updates
X-BeenThere: taps@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "IETF Transport Services \(TAPS\) Working Group" <taps.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/taps>, <mailto:taps-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/taps/>
List-Post: <mailto:taps@ietf.org>
List-Help: <mailto:taps-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/taps>, <mailto:taps-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Sep 2019 17:17:41 -0000

Hi taps,

It turns out sometimes forcing functions can do some work even
when the trigger is cancelled.  I have a few minor yang updates,
plus a question (in #4):


1. Tooling update

I cleaned up the make process for the yang module draft a bit, while
still keeping the structure of importing external files + automated
validation.

This version only requires pyang and rsync to build if you're not
validating, and adds in a requirement for the yanglint executable
(included with libyang), but only if you use 'make yanglint' or
set "VALIDATE_YANG=1" as an environment variable.  In return, it
removes my extra c file that linked to libyang.

It also no longer auto-builds its dependencies, it just complains
if you don't have the requirements installed.

The current Makefile points to my i-d-template fork that has these
changes, since otherwise it won't build a proper draft:
https://github.com/GrumpyOldTroll/ietf-taps-yang/blob/master/Makefile#L11

I've sent a pull request to merge the cleanup upstream:
https://github.com/martinthomson/i-d-template/pull/193

As far as I know, nobody has reviewed it, so it could use some
sanity-checking and probably some feedback.  Good chance some changes
would be in order, if only I knew what they were.


2. Theresa made a pull request to make the identity and algorithm
in the security container optional:
https://github.com/GrumpyOldTroll/ietf-taps-yang/commit/265e3a0219e115a181618915a73b893409ef5a29

It sounded plausible to me, so I pulled it.  (But not before checking
whether 'mandatory false' should be added also, and finding that I get
warnings from yanglint if I try making it explicit, so it's better as
written.)  Thanks Theresa!


3. I think I also addressed one of the 4 issues Theresa opened after
Montreal, by adding a constraint that there must be at least 1 remote
or local endpoint in a preconnection and adding a negative test for it:
https://github.com/GrumpyOldTroll/ietf-taps-yang/commit/886b5ee1e4a37c59c74c9b60b1dfbdd7097d156f

And thanks for the review and for opening the issues, Theresa!


4. I think in Montreal, Tommy suggested to me offline that I transfer the
ietf-taps-yang repo to https://github.com/ietf-tapswg.

I'll go ahead and do that if I get a couple of "yes, go ahead"s, but I
thought I'd check first, because right now I think I don't have consensus,
so much as a vague memory of a mumbled suggestion that I'm only 70%
certain I understood correctly.  I think it makes sense, but I don't want
to surprise anyone or clutter things up if people believe it needs work
before going there.

So does it sound right to just transfer the repo now?


Best regards,
Jake