Re: [Taps] YANG updates

["Holland, Jake" <[e-mail]>]

Hi Theresa,

Thanks for taking a look.

> By default, when I build the draft, it still reads the .yang and then
> dumps the XML and the tree structure, but it does not validate the
> model, right?

Yes, exactly.

> To test, I changed an identifier in the model, and the tool did complain
> about an unknown identifier -- but it still built the draft as .txt and
> .html. That's the intended behavior, right?
...
> "make" works for me, but "make yanglint" doesn't. It complains that
> there's no target called "yanglint".

This isn't what I expect, no.  This behavior sounds like the lib/ directory
is not hooked up--if you built it before, the old lib/ would still be there
(nothing auto-updates it).  That would probably explain what you're seeing.

To check whether that's right, something like this is expected if you start
from a clean ietf-taps-yang directory now (one without a lib/), after
running any kind of make (it does pull the lib/, but only if it's missing,
I think):

~~~
jake-lap:ietf-taps-yang jholland$ cd lib
jake-lap:lib jholland$ git status
On branch yang-support
Your branch is up to date with 'origin/yang-support'.

nothing to commit, working tree clean
jake-lap:lib jholland$ git remote -v
origin	https://github.com/GrumpyOldTroll/i-d-template (fetch)
origin	https://github.com/GrumpyOldTroll/i-d-template (push)
~~~

If that's not what you see (if it's on master instead of yang-support,
for instance), maybe try moving the lib/ directory away and then doing
a make again, or 'git pull; git checkout yang-support'.

What I expect if lib/ is on the right branch, and an error has been
introduced (e.g. by changing an identifier in an example):
- if you type 'make yanglint' it'll report the error
- regardless of whether you make yanglint, if you
  'export VALIDATE_YANG=1; make', it will NOT build a .txt/.html, and will
  report the same error as 'make yanglint'.
- if you unset VALIDATE_YANG or never used it and just 'make',
  you'll see no error*, and it'll build a .txt that contains the error.

* you might still see an error if you don't have pyang installed.  You
might also get warnings about missing imports if you haven't done a make
yanglint, which fetches them.  But it turns out those aren't required for
the tree-building, and won't stop the build from completing.

HTH.

Best,
Jake