Re: [tcpm] I-D Action: draft-ietf-tcpm-converters-12.txt

<mohamed.boucadair@orange.com> Mon, 21 October 2019 13:59 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C9371200C4 for <tcpm@ietfa.amsl.com>; Mon, 21 Oct 2019 06:59:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7UKWaLUQeBkc for <tcpm@ietfa.amsl.com>; Mon, 21 Oct 2019 06:59:36 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.41]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 345791200A3 for <tcpm@ietf.org>; Mon, 21 Oct 2019 06:59:36 -0700 (PDT)
Received: from opfedar00.francetelecom.fr (unknown [xx.xx.xx.11]) by opfedar22.francetelecom.fr (ESMTP service) with ESMTP id 46xdYL4YXMz2xpP; Mon, 21 Oct 2019 15:59:34 +0200 (CEST)
Received: from localhost.localdomain (unknown [127.0.0.1]) by opfedar00.francetelecom.fr (ESMTP service) with ESMTP id 46xdYL41JzzCqkV; Mon, 21 Oct 2019 15:59:34 +0200 (CEST)
Received: from opfedar00.bagnolet.francetelecom.fr by opfedar00.bagnolet.francetelecom.fr with queue id 1158788-21; Mon, 21 Oct 2019 13:59:34 GMT
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.101]) by opfedar00.francetelecom.fr (ESMTP service) with ESMTP id 46xdYL3fRmzCqkT; Mon, 21 Oct 2019 15:59:34 +0200 (CEST)
Received: from OPEXCAUBMA2.corporate.adroot.infra.ftgroup ([fe80::e878:bd0:c89e:5b42]) by OPEXCAUBM6F.corporate.adroot.infra.ftgroup ([fe80::c489:b768:686a:545b%23]) with mapi id 14.03.0468.000; Mon, 21 Oct 2019 15:59:34 +0200
From: <mohamed.boucadair@orange.com>
To: "philip.eardley@bt.com" <philip.eardley@bt.com>, "Michael.Scharf@hs-esslingen.de" <Michael.Scharf@hs-esslingen.de>
CC: "tcpm@ietf.org" <tcpm@ietf.org>
Thread-Topic: [tcpm] I-D Action: draft-ietf-tcpm-converters-12.txt
Thread-Index: AQHVesazxMnJ0MpTtUGYTCO0/wPXnKdKmMEAgBqMdbCAAAraUA==
Date: Mon, 21 Oct 2019 13:59:34 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B933031342F0D@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <157020217020.1400.989960668789303006@ietfa.amsl.com> <787AE7BB302AE849A7480A190F8B933031338ED7@OPEXCAUBMA2.corporate.adroot.infra.ftgroup> <CWLP123MB2579C2F8AE08479F02AD64DBEB690@CWLP123MB2579.GBRP123.PROD.OUTLOOK.COM>
In-Reply-To: <CWLP123MB2579C2F8AE08479F02AD64DBEB690@CWLP123MB2579.GBRP123.PROD.OUTLOOK.COM>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.245]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/-Wj4GKivnQEqTsPaiNp7B3Tx4SM>
Subject: Re: [tcpm] I-D Action: draft-ietf-tcpm-converters-12.txt
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Oct 2019 13:59:39 -0000

Hi Phil,

Thank you for double checking. 

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : philip.eardley@bt.com [mailto:philip.eardley@bt.com]
> Envoyé : lundi 21 octobre 2019 15:10
> À : BOUCADAIR Mohamed TGI/OLN; Michael.Scharf@hs-esslingen.de
> Cc : tcpm@ietf.org
> Objet : RE: [tcpm] I-D Action: draft-ietf-tcpm-converters-12.txt
> 
> Med,
> Thanks for creating these new pieces of text, I think they're helpful and
> it's looking good!
> 
> Comments:
> Section 3.3
> <<User data is unambiguously distinguished from Convert TLVs by a Transport
> Converter owing to the Total Length field in the Convert messages>>
> Better:
> User data is unambiguously distinguished from Convert TLVs by a Transport
> Converter by the Convert Fixed Header (Figure 12) in the Convert messages
> 

[Med] The OLD wording insisted on the importance of Total Length field to disambiguate TLVs when user data is also present, but OK to change as follows if you think this is better:  

User data is unambiguously distinguished from Convert TLVs by
a Transport Converter owing to the Convert Fixed Header in the
Convert messages (Section 4.1).


> In Section 3.3, I think you should move the text about MPTCP out of S3.3
> (into S3.4, maybe with some renumbering of S3.4 & 3.5 to make a section
> about mptcp)
> [this is the text "Note that for the Multipath TCP case..." to the Figure 8
> caption and the bullet "In reference to Figure 8"]
> Reason: handle the general case first, then the MPTCP variant.

[Med] No problem to rearrange the text if you think that is better. 

> 
> << Note that for the Multipath TCP case, the Transport Converter identifies
> an MPTCP connection by means, e.g., of the token assigned to the MPTCP
> connection.>>
> If I get it right, this is nothing to do with the token defined in MPTCP,

[Med] ", e.g., of the token assigned to the MPTCP connection." refers to the token defined in MPTCP: 

   Token:  A locally unique identifier given to a multipath connection
      by a host.  May also be referred to as a "Connection ID".

Any issue with that?

> but is simply an identifier internal to the Converter (to help it keep
> together entries for the same Client). Ie this token is not seen on the
> wire. Please could you re-phrase the para and the definition of "token" in
> the Figure 8 caption.
> 
> Section 4.1
> In the Figure 12 caption, I suggest deleting "-Sized" (so: "Figure 12: The
> Fixed Header of the Convert Protocol" or even "Figure 12: The Convert Fixed
> Header")

[Med] OK, changed to "Figure 12: The Convert Fixed Header)".

> 
> Section D.2
> Appendix D.1 has a final paragraph which doesn't appear at the end of D.2
> (<<The Transport Converter must be on the forwarding path of incoming
> traffic.>>)

[Med] D2.2 has already the following text: 

   Adequate forwarding policies are enforced so that traffic destined to
   an address of such pool is intercepted by the appropriate Transport
   Converter.

> I assume the same text is true for the IPv4 address sharing model. I
> suggest adding a comment at the end of D.2 that the same considerations
> apply (or repeating the paragraph, possibly with "IP address" changed to
> "IP address prefix")
> I also suggest changing the title "IPv4 Address Sharing" to "Address
> Sharing"

[Med] Changed the title to "Address/Prefix Sharing" to cover both IPv4 and IPv6.

Thank you.

> 
> Best wishes,
> phil
> 
> 
> -----Original Message-----
> From: mohamed.boucadair@orange.com [mailto:mohamed.boucadair@orange.com]
> Sent: 04 October 2019 16:20
> To: Eardley,PL,Philip,TUD1 R <philip.eardley@bt.com>om>; Scharf, Michael
> (Michael.Scharf@hs-esslingen.de) <Michael.Scharf@hs-esslingen.de>
> Cc: tcpm@ietf.org
> Subject: RE: [tcpm] I-D Action: draft-ietf-tcpm-converters-12.txt
> 
> Hi Phil, Michael,
> 
> This version implements the suggestions discussed so far: add a new section
> to discuss data processing once a state is created + appendix to discuss
> address sharing/preservation modes.
> 
> I think this version solves the concerns raised by Phil.
> 
> Looking forward to advance the document.
> 
> Cheers,
> Med
> 
> > -----Message d'origine-----
> > De : tcpm [mailto:tcpm-bounces@ietf.org] De la part de internet-
> > drafts@ietf.org Envoyé : vendredi 4 octobre 2019 17:16 À :
> > i-d-announce@ietf.org Cc : tcpm@ietf.org Objet : [tcpm] I-D Action:
> > draft-ietf-tcpm-converters-12.txt
> >
> >
> > A New Internet-Draft is available from the on-line Internet-Drafts
> > directories.
> > This draft is a work item of the TCP Maintenance and Minor Extensions
> > WG of the IETF.
> >
> >         Title           : 0-RTT TCP Convert Protocol
> >         Authors         : Olivier Bonaventure
> >                           Mohamed Boucadair
> >                           Sri Gundavelli
> >                           SungHoon Seo
> >                           Benjamin Hesmans
> > 	Filename        : draft-ietf-tcpm-converters-12.txt
> > 	Pages           : 52
> > 	Date            : 2019-10-04
> >
> > Abstract:
> >    This document specifies an application proxy, called Transport
> >    Converter, to assist the deployment of TCP extensions such as
> >    Multipath TCP.  This proxy is designed to avoid inducing extra delay
> >    when involved in a network-assisted connection (that is, 0-RTT).
> >
> >    This specification assumes an explicit model, where the proxy is
> >    explicitly configured on hosts.
> >
> >    -- Editorial Note (To be removed by RFC Editor)
> >
> >    Please update these statements with the RFC number to be assigned to
> >    this document: [This-RFC]
> >
> >    Please update TBA statements with the port number to be assigned to
> >    the 0-RTT TCP Convert Protocol.
> >
> >
> > The IETF datatracker status page for this draft is:
> > https://datatracker.ietf.org/doc/draft-ietf-tcpm-converters/
> >
> > There are also htmlized versions available at:
> > https://tools.ietf.org/html/draft-ietf-tcpm-converters-12
> > https://datatracker.ietf.org/doc/html/draft-ietf-tcpm-converters-12
> >
> > A diff from the previous version is available at:
> > https://www.ietf.org/rfcdiff?url2=draft-ietf-tcpm-converters-12
> >
> >
> > Please note that it may take a couple of minutes from the time of
> > submission until the htmlized version and diff are available at
> > tools.ietf.org.
> >
> > Internet-Drafts are also available by anonymous FTP at:
> > ftp://ftp.ietf.org/internet-drafts/
> >
> > _______________________________________________
> > tcpm mailing list
> > tcpm@ietf.org
> > https://www.ietf.org/mailman/listinfo/tcpm