[tcpm] Genart last call review of draft-ietf-tcpm-ao-test-vectors-05

Peter Yee via Datatracker <noreply@ietf.org> Sun, 30 January 2022 22:25 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tcpm@ietf.org
Delivered-To: tcpm@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B7F343A0C35; Sun, 30 Jan 2022 14:25:28 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Peter Yee via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-tcpm-ao-test-vectors.all@ietf.org, last-call@ietf.org, tcpm@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.44.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <164358152867.17369.12451192921874290368@ietfa.amsl.com>
Reply-To: Peter Yee <peter@akayla.com>
Date: Sun, 30 Jan 2022 14:25:28 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/0a7t-xZjvqurJHeFnvcWkkEuIQ0>
Subject: [tcpm] Genart last call review of draft-ietf-tcpm-ao-test-vectors-05
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Jan 2022 22:25:29 -0000

Reviewer: Peter Yee
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at


Document: draft-ietf-tcpm-ao-test-vectors-05
Reviewer: Peter Yee
Review Date: 2022-01-30
IETF LC End Date: 2022-02-01
IESG Telechat date: Not scheduled for a telechat

Summary: This document supplies test vectors for the MTI authentication
algorithms used in the TCP Authentication Option. There are a few nits that
should be corrected prior to publication. I'm not equipped to validate the test
vectors themselves and did not attempt to do so. [Ready with nits.]

Major issues: None

Minor issues: None

Nits/editorial comments:

Page 2, Abstract: move this entire section before the "Status of this Memo"
section, as required by RFC 7322, section 4.

Page 4, first full paragraph: move "[RFC6978]" after "experimental extension"
to avoid confusion.

Page 10, section 5, 1st paragraph: add a period at the end of the sentence.

Page 20, section 7, 1st sentence: add a period at the end of the sentence.

Page 24, section 8.2: add a comma after "e.g.".

Page 25, section 8.4, 2nd bullet item: change "to" to "in".

Page 25, section 8.4, 3rd bullet item: change first "to" to "in".

Page 25, section 9, 2nd paragraph: between the usage in section 3.1.1 and here,
choose a consistent case for "master_key". I know, RFC 5926 (Master_Key) and
RFC 5925 (master_key) are not consistent between themselves.